From abaa9106fbb662944e7097e338558c217888cc1c Mon Sep 17 00:00:00 2001 From: Aaron Bockelie Date: Sat, 16 May 2026 12:45:28 -0500 Subject: [PATCH] build: replace builtin-modules with native node:module builtinModules Obsidian source-code review flags builtin-modules as a package to replace. node:module has exposed builtinModules natively since Node 6.x; esbuild only used it to externalize Node builtins from the bundle. Behavior-equivalent swap, devDependency removed. --- esbuild.config.mjs | 4 ++-- package-lock.json | 14 -------------- package.json | 1 - 3 files changed, 2 insertions(+), 17 deletions(-) diff --git a/esbuild.config.mjs b/esbuild.config.mjs index 21e940a..a52ee2e 100644 --- a/esbuild.config.mjs +++ b/esbuild.config.mjs @@ -1,6 +1,6 @@ import esbuild from "esbuild"; import process from "process"; -import builtins from "builtin-modules"; +import { builtinModules } from "node:module"; const banner = `/* @@ -32,7 +32,7 @@ const context = await esbuild.context({ '@lezer/common', '@lezer/highlight', '@lezer/lr', - ...builtins], + ...builtinModules], format: 'cjs', target: 'es2018', logLevel: "info", diff --git a/package-lock.json b/package-lock.json index abf6125..0b0724a 100644 --- a/package-lock.json +++ b/package-lock.json @@ -29,7 +29,6 @@ "@types/minimatch": "^5.1.2", "@types/node": "^25.3.0", "@typescript-eslint/utils": "^8.56.0", - "builtin-modules": "^5.0.0", "esbuild": "^0.27.3", "eslint": "^9.39.2", "eslint-plugin-obsidianmd": "^0.3.0", @@ -3454,19 +3453,6 @@ "dev": true, "license": "MIT" }, - "node_modules/builtin-modules": { - "version": "5.0.0", - "resolved": "https://registry.npmjs.org/builtin-modules/-/builtin-modules-5.0.0.tgz", - "integrity": "sha512-bkXY9WsVpY7CvMhKSR6pZilZu9Ln5WDrKVBUXf2S443etkmEO4V58heTecXcUIsNsi4Rx8JUO4NfX1IcQl4deg==", - "dev": true, - "license": "MIT", - "engines": { - "node": ">=18.20" - }, - "funding": { - "url": "https://github.com/sponsors/sindresorhus" - } - }, "node_modules/bytes": { "version": "3.1.2", "resolved": "https://registry.npmjs.org/bytes/-/bytes-3.1.2.tgz", diff --git a/package.json b/package.json index e59ec2e..5a9dca7 100644 --- a/package.json +++ b/package.json @@ -33,7 +33,6 @@ "@types/minimatch": "^5.1.2", "@types/node": "^25.3.0", "@typescript-eslint/utils": "^8.56.0", - "builtin-modules": "^5.0.0", "esbuild": "^0.27.3", "eslint": "^9.39.2", "eslint-plugin-obsidianmd": "^0.3.0",