mirror of
https://github.com/aaronsb/obsidian-mcp-plugin.git
synced 2026-07-22 06:45:14 +00:00
926b8fb363
Code review refinements (no behavior change): - Make the SSE socket-exemption trade-off explicit: with setTimeout(0) there is no socket-layer idle reap, so a truly-dead SSE socket is bounded by the SessionManager's 1h idle eviction (which calls transport.close()) and the 32-session cap, not leaked unbounded. Note the finite-timeout alternative is deferred to live validation. - Clarify the comment: the exemption matches any GET, but non-SSE GETs are short-lived so it's a harmless no-op for them. - Add afterEach teardown disposing the SessionManager + connection-pool intervals (server.stop() short-circuits when never started), removing the test's leaked-timer warning. - Strengthen the missing-socket test to assert the request still routes to the spec §2 400, not just that it doesn't throw. Claude-Session: https://claude.ai/code/session_011yowKCMFCBp61DRBu5xQm4 |
||
|---|---|---|
| .. | ||
| config | ||
| formatters | ||
| indexing | ||
| security | ||
| semantic | ||
| tools | ||
| types | ||
| utils | ||
| validation | ||
| browser-mcp-server.ts | ||
| main-complex.ts | ||
| main-simple.ts | ||
| main.ts | ||
| mcp-server.ts | ||
| node-mcp-server.ts | ||
| version.ts | ||