obsidian-plugin/ahmetildirim_obsidian-inscribe
1
0
Fork 0
mirror of https://github.com/ahmetildirim/obsidian-inscribe.git synced 2026-07-22 05:44:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Refactor profile handling in settings to improve clarity and functionality

Browse source
This commit is contained in:
Ahmet Ildirim 2025-03-27 21:26:26 +01:00
parent be98b29ff4
commit 58136cee32
3 changed files with 17 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/settings/settings.ts
View file

@ -134,4 +134,8 @@ export function createPathConfig(settings: Settings, path: string, profile: Prof
export function resetSettings(settings: Settings): void {
Object.assign(settings, DEFAULT_SETTINGS);
}
export const isDefaultProfile = (profile: ProfileId): boolean => {
return profile === DEFAULT_PROFILE;
}

34
src/settings/tab.ts
View file

@ -3,13 +3,10 @@ import { TEMPLATE_VARIABLES } from "src/completions/prompt";
import { SplitStrategy } from "src/extension";
import Inscribe from "src/main";
import { ProviderType } from "src/providers";
import { createPathConfig, DEFAULT_PATH, DEFAULT_PROFILE, Profile, resetSettings } from "./settings";
import { createPathConfig, DEFAULT_PATH, DEFAULT_PROFILE, isDefaultProfile, Profile, resetSettings } from "./settings";
import { ProviderSettingsModal } from './provider';
import { createProfile } from ".";
/* --------------------------------------------------------------------------
* Main Settings Tab
* ------------------------------------------------------------------------ */
export default class InscribeSettingsTab extends PluginSettingTab {
private generalSection: GeneralSection;
private providersSection: ProvidersSection;
@ -45,7 +42,6 @@ export default class InscribeSettingsTab extends PluginSettingTab {
}
}
// General Section
class GeneralSection {
private container: HTMLElement;
private plugin: Inscribe;
@ -93,9 +89,6 @@ class GeneralSection {
}
}
/* --------------------------------------------------------------------------
* Providers Section
* ------------------------------------------------------------------------ */
class ProvidersSection {
private container: HTMLElement;
private plugin: Inscribe;
@ -156,14 +149,11 @@ class ProvidersSection {
}
}
/* --------------------------------------------------------------------------
* Profiles Section
* ------------------------------------------------------------------------ */
class ProfilesSection {
private container: HTMLElement;
private plugin: Inscribe;
private onProfileUpdate: () => void;
private displayedProfileId: string = DEFAULT_PROFILE;
private selectedProfileId: string = DEFAULT_PROFILE;
constructor(container: HTMLElement, plugin: Inscribe, onProfileUpdate: () => void) {
this.container = container;
@ -190,11 +180,12 @@ class ProfilesSection {
.addExtraButton((button: ExtraButtonComponent) => this.createDeleteProfileButton(button));
// Profile Name
const profile = this.plugin.settings.profiles[this.displayedProfileId];
const profile = this.plugin.settings.profiles[this.selectedProfileId];
new Setting(this.container)
.setName("Profile name")
.setDesc(`${profile.name} | Name of the profile`)
.addText((text) => {
text.setDisabled(isDefaultProfile(this.selectedProfileId));
text.setValue(profile.name).onChange(async (value) => {
profile.name = value;
await this.plugin.saveSettings();
@ -341,9 +332,9 @@ class ProfilesSection {
dropdown.addOption(id, profile.name);
});
dropdown
.setValue(this.displayedProfileId)
.setValue(this.selectedProfileId)
.onChange(async (value) => {
this.displayedProfileId = value;
this.selectedProfileId = value;
await this.render();
});
}
@ -353,7 +344,7 @@ class ProfilesSection {
.setIcon("plus")
.setTooltip("Create new profile")
.onClick(async () => {
this.displayedProfileId = createProfile(this.plugin.settings);
this.selectedProfileId = createProfile(this.plugin.settings);
await this.plugin.saveSettings();
await this.render();
this.onProfileUpdate();
@ -361,14 +352,14 @@ class ProfilesSection {
}
private createDeleteProfileButton(button: ExtraButtonComponent): void {
const isDefault = this.displayedProfileId === DEFAULT_PROFILE;
const isDefault = this.selectedProfileId === DEFAULT_PROFILE;
button
.setDisabled(isDefault)
.setIcon("trash")
.setTooltip(isDefault ? "Cannot delete default profile" : "Delete profile")
.onClick(async () => {
delete this.plugin.settings.profiles[this.displayedProfileId];
this.displayedProfileId = DEFAULT_PROFILE;
delete this.plugin.settings.profiles[this.selectedProfileId];
this.selectedProfileId = DEFAULT_PROFILE;
await this.plugin.saveSettings();
await this.render();
this.onProfileUpdate();
@ -460,11 +451,8 @@ class PathConfigsSection {
// Existing Mappings
Object.entries(this.plugin.settings.path_configs).forEach(([path, mapping]) => {
const row = table.createEl("tr");
row.setCssStyles({
"height": "40px"
});
const isDefaultMapping = path === DEFAULT_PATH;
row.createEl("td", { text: isDefaultMapping ? "/ (root)" : path });
row.createEl("td", { text: isDefaultMapping ? "Default (all paths)" : path });
// Create profile cell with dropdown
const profileCell = row.createEl("td");

4
src/statusbar/statusbar.ts
View file

@ -58,7 +58,7 @@ export default class StatusBarItem {
item.setTitle(`Profile: ${profile.name}`).setIsLabel(true);
});
menu.addItem((item) => {
item.setTitle(`${pathCompletionEnabled ? 'Disable' : 'Enable'} this path: {${path}]}`)
item.setTitle(`Completion is ${pathCompletionEnabled ? 'On' : 'Off'} for: {${path}]}`)
.setChecked(pathCompletionEnabled)
.onClick(() => {
const pathConfig = findPathConfig(this.plugin.settings, path);
@ -68,7 +68,7 @@ export default class StatusBarItem {
});
});
menu.addItem((item) => {
item.setTitle(`${globalCompletionEnabled ? 'Disable' : 'Enable'} globally`)
item.setTitle(`Global Completion is ${globalCompletionEnabled ? 'On' : 'Off'}`)
.setChecked(globalCompletionEnabled)
.onClick(() => {
this.plugin.settings.enabled = !globalCompletionEnabled;