obsidian-plugin/alberti42_obsidian-plugins-annotations
1
0
Fork 0
mirror of https://github.com/alberti42/obsidian-plugins-annotations.git synced 2026-07-22 10:10:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fixed bug where buttons resetting to default conditions did not properly save the new setting.

Browse source
This commit is contained in:
Andrea Alberti 2024-08-20 01:08:47 +02:00
parent cd12493409
commit f1cc2a84c4
2 changed files with 31 additions and 45 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
src/peggy.mjs
View file

@ -1410,40 +1410,6 @@ function peg$parse(input, options) {
return s0;
}
function peg$parseempty_line() {
var s0, s1, s2, s3;
s0 = peg$currPos;
s1 = peg$currPos;
s2 = peg$parse_();
if (s2 !== peg$FAILED) {
s3 = input.charAt(peg$currPos);
if (peg$r1.test(s3)) {
peg$currPos++;
} else {
s3 = peg$FAILED;
if (peg$silentFails === 0) { peg$fail(peg$e10); }
}
if (s3 !== peg$FAILED) {
s2 = [s2, s3];
s1 = s2;
} else {
peg$currPos = s1;
s1 = peg$FAILED;
}
} else {
peg$currPos = s1;
s1 = peg$FAILED;
}
if (s1 !== peg$FAILED) {
s0 = input.substring(s0, peg$currPos);
} else {
s0 = s1;
}
return s0;
}
function peg$parse_() {
var s0;

42
src/settings_tab.ts
View file

@ -97,6 +97,7 @@ export class PluginsAnnotationsSettingTab extends PluginSettingTab {
.setTooltip("Reset to default value")
.onClick(() => {
editable_toggle.setValue(DEFAULT_SETTINGS.editable);
this.plugin.debouncedSaveAnnotations(() => { this.uninstalledPluginsManager?.updateUninstalledPluginSettings(containerEl); });
});
});
@ -238,6 +239,7 @@ export class PluginsAnnotationsSettingTab extends PluginSettingTab {
.setTooltip("Reset to default value")
.onClick(() => {
md_filepath_text.setValue(DEFAULT_SETTINGS.markdown_file_path);
this.plugin.debouncedSaveAnnotations();
});
});
@ -266,6 +268,7 @@ export class PluginsAnnotationsSettingTab extends PluginSettingTab {
.setTooltip("Reset to default value")
.onClick(() => {
md_file_toggle.setValue(DEFAULT_SETTINGS.markdown_file_path !== '');
this.plugin.debouncedSaveAnnotations();
});
});
@ -285,20 +288,20 @@ export class PluginsAnnotationsSettingTab extends PluginSettingTab {
label = this.plugin.settings.label_mobile;
label_version = 'mobile';
label_cb = (value: string) => {
this.plugin.settings.label_mobile = value;
this.plugin.debouncedSaveAnnotations(() => {
this.uninstalledPluginsManager?.updateUninstalledPluginSettings(containerEl);
});
};
this.plugin.settings.label_mobile = value;
this.plugin.debouncedSaveAnnotations(() => {
this.uninstalledPluginsManager?.updateUninstalledPluginSettings(containerEl);
});
};
} else {
label = this.plugin.settings.label_desktop;
label_version = 'desktop';
label_cb = (value: string) => {
this.plugin.settings.label_desktop = value;
this.plugin.debouncedSaveAnnotations(() => {
this.uninstalledPluginsManager?.updateUninstalledPluginSettings(containerEl);
});
};
this.plugin.settings.label_desktop = value;
this.plugin.debouncedSaveAnnotations(() => {
this.uninstalledPluginsManager?.updateUninstalledPluginSettings(containerEl);
});
};
}
const label_setting = new Setting(containerEl)
@ -325,7 +328,18 @@ export class PluginsAnnotationsSettingTab extends PluginSettingTab {
.setIcon("reset")
.setTooltip("Reset to default value")
.onClick(() => {
label_text.setValue(Platform.isMobile ? DEFAULT_SETTINGS.label_mobile : DEFAULT_SETTINGS.label_desktop);
let label: string;
if(Platform.isMobile) {
label = DEFAULT_SETTINGS.label_mobile;
this.plugin.settings.label_mobile = label;
} else {
label = DEFAULT_SETTINGS.label_desktop;
this.plugin.settings.label_desktop = label;
}
label_text.setValue(label);
this.plugin.debouncedSaveAnnotations(() => {
this.uninstalledPluginsManager?.updateUninstalledPluginSettings(containerEl);
});
});
});
@ -358,6 +372,9 @@ export class PluginsAnnotationsSettingTab extends PluginSettingTab {
.setTooltip("Reset to default value")
.onClick(() => {
placeholder_text.setValue(DEFAULT_SETTINGS.label_placeholder);
this.plugin.debouncedSaveAnnotations(() => {
this.uninstalledPluginsManager?.updateUninstalledPluginSettings(containerEl);
});
});
});
@ -397,6 +414,7 @@ export class PluginsAnnotationsSettingTab extends PluginSettingTab {
.setTooltip("Reset to default value")
.onClick(() => {
hide_empty_annotations_toggle.setValue(DEFAULT_SETTINGS.hide_placeholders);
this.plugin.debouncedSaveAnnotations(() => { this.uninstalledPluginsManager?.updateUninstalledPluginSettings(containerEl); });
});
});
@ -424,6 +442,7 @@ export class PluginsAnnotationsSettingTab extends PluginSettingTab {
.setTooltip("Reset to default value")
.onClick(() => {
delete_placeholder_string_toggle.setValue(DEFAULT_SETTINGS.delete_placeholder_string_on_insertion);
this.plugin.debouncedSaveAnnotations(() => { this.uninstalledPluginsManager?.updateUninstalledPluginSettings(containerEl); });
});
});
@ -669,6 +688,7 @@ class UninstalledPluginsManager {
.setTooltip("Reset to default value")
.onClick(() => {
automatic_remove_toggle.setValue(DEFAULT_SETTINGS.automatic_remove);
this.plugin.debouncedSaveAnnotations();
});
});