obsidian-plugin/andy-stack_vaultkeeper-ai
1
0
Fork 0
mirror of https://github.com/andy-stack/vaultkeeper-ai.git synced 2026-07-22 06:42:03 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

test: add subscribeToSettingsChanged mock and update settings tests

Browse source 
Mock the new subscribeToSettingsChanged method in all AI provider test files to prevent test failures. Update SettingsService tests to use updateSettings method instead of direct settings modification and saveSettings calls, aligning with the new reactive settings API that notifies subscribers of changes.
This commit is contained in:
Andrew Beal 2026-05-04 16:31:49 +01:00
parent da2d777087
commit 31f0484114
7 changed files with 37 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
__tests__/AIClasses/BaseAIClass.test.ts
View file

@ -48,7 +48,8 @@ describe('BaseAIClass Shared Methods', () => {
if (provider === AIProvider.Gemini) return 'test-gemini-key';
return '';
}),
getApiKeyForCurrentModel: vi.fn(() => 'test-claude-key')
getApiKeyForCurrentModel: vi.fn(() => 'test-claude-key'),
subscribeToSettingsChanged: vi.fn()
};
RegisterSingleton(Services.SettingsService, mockSettingsService);

3
__tests__/AIClasses/Claude.test.ts
View file

@ -52,7 +52,8 @@ describe('Claude', () => {
if (provider === AIProvider.Gemini) return 'test-gemini-key';
return '';
}),
getApiKeyForCurrentModel: vi.fn(() => 'test-claude-key')
getApiKeyForCurrentModel: vi.fn(() => 'test-claude-key'),
subscribeToSettingsChanged: vi.fn()
};
RegisterSingleton(Services.SettingsService, mockSettingsService);

3
__tests__/AIClasses/CrossProviderIntegration.test.ts
View file

@ -61,7 +61,8 @@ describe('Cross-Provider Integration - Thought Signature Support', () => {
if (provider === AIProvider.Gemini) return 'test-gemini-key';
return '';
}),
getApiKeyForCurrentModel: vi.fn(() => 'test-gemini-key')
getApiKeyForCurrentModel: vi.fn(() => 'test-gemini-key'),
subscribeToSettingsChanged: vi.fn()
};
RegisterSingleton(Services.SettingsService, mockSettingsService);

3
__tests__/AIClasses/Gemini.test.ts
View file

@ -50,7 +50,8 @@ describe('Gemini', () => {
if (provider === AIProvider.Gemini) return 'test-gemini-key';
return '';
}),
getApiKeyForCurrentModel: vi.fn(() => 'test-gemini-key')
getApiKeyForCurrentModel: vi.fn(() => 'test-gemini-key'),
subscribeToSettingsChanged: vi.fn()
};
RegisterSingleton(Services.SettingsService, mockSettingsService);

3
__tests__/AIClasses/Mistral.test.ts
View file

@ -53,7 +53,8 @@ describe('Mistral', () => {
if (provider === AIProvider.Mistral) return 'test-mistral-key';
return '';
}),
getApiKeyForCurrentModel: vi.fn(() => 'test-mistral-key')
getApiKeyForCurrentModel: vi.fn(() => 'test-mistral-key'),
subscribeToSettingsChanged: vi.fn()
};
RegisterSingleton(Services.SettingsService, mockSettingsService);

3
__tests__/AIClasses/OpenAI.test.ts
View file

@ -53,7 +53,8 @@ describe('OpenAI', () => {
if (provider === AIProvider.Gemini) return 'test-gemini-key';
return '';
}),
getApiKeyForCurrentModel: vi.fn(() => 'test-openai-key')
getApiKeyForCurrentModel: vi.fn(() => 'test-openai-key'),
subscribeToSettingsChanged: vi.fn()
};
RegisterSingleton(Services.SettingsService, mockSettingsService);

43
__tests__/Services/SettingsService.test.ts
View file

@ -3,6 +3,7 @@ import { SettingsService, type IVaultkeeperAISettings } from '../../Services/Set
import { RegisterSingleton, DeregisterAllServices } from '../../Services/DependencyService';
import { Services } from '../../Services/Services';
import { AIProvider, AIProviderModel, fromModel } from '../../Enums/ApiProvider';
import { ChatMode } from 'Enums/ChatMode';
describe('SettingsService', () => {
let settingsService: SettingsService;
@ -110,7 +111,8 @@ describe('SettingsService', () => {
quickActionModel: AIProviderModel.ClaudeSonnet_4_6,
enableContextMenuActions: false,
enableToolbarActions: false,
hideDrawerElements: false
hideDrawerElements: false,
chatMode: ChatMode.ReadOnly
};
settingsService = new SettingsService(loadedSettings);
});
@ -160,7 +162,8 @@ describe('SettingsService', () => {
quickActionModel: AIProviderModel.ClaudeSonnet_4_6,
enableContextMenuActions: false,
enableToolbarActions: false,
hideDrawerElements: false
hideDrawerElements: false,
chatMode: ChatMode.ReadOnly
};
settingsService = new SettingsService(loadedSettings);
@ -190,7 +193,8 @@ describe('SettingsService', () => {
quickActionModel: AIProviderModel.GPT_5_4_Mini,
enableContextMenuActions: false,
enableToolbarActions: false,
hideDrawerElements: false
hideDrawerElements: false,
chatMode: ChatMode.ReadOnly
};
settingsService = new SettingsService(loadedSettings);
@ -220,7 +224,8 @@ describe('SettingsService', () => {
quickActionModel: AIProviderModel.GeminiFlash_2_5,
enableContextMenuActions: false,
enableToolbarActions: false,
hideDrawerElements: false
hideDrawerElements: false,
chatMode: ChatMode.ReadOnly
};
settingsService = new SettingsService(loadedSettings);
@ -278,7 +283,8 @@ describe('SettingsService', () => {
quickActionModel: AIProviderModel.ClaudeSonnet_4_6,
enableContextMenuActions: false,
enableToolbarActions: false,
hideDrawerElements: false
hideDrawerElements: false,
chatMode: ChatMode.ReadOnly
};
settingsService = new SettingsService(loadedSettings);
});
@ -342,23 +348,24 @@ describe('SettingsService', () => {
quickActionModel: AIProviderModel.ClaudeSonnet_4_6,
enableContextMenuActions: false,
enableToolbarActions: false,
hideDrawerElements: false
hideDrawerElements: false,
chatMode: ChatMode.ReadOnly
};
settingsService = new SettingsService(loadedSettings);
mockPlugin.saveData.mockClear();
});
it('should call plugin.saveData with current settings', async () => {
await settingsService.saveSettings();
await settingsService.updateSettings(() => {});
expect(mockPlugin.saveData).toHaveBeenCalledWith(settingsService.settings);
expect(mockPlugin.saveData).toHaveBeenCalledTimes(1);
});
it('should call plugin.saveData with updated settings after modification', async () => {
settingsService.setApiKeyForProvider(AIProvider.Claude, 'updated-key');
settingsService.settings.userInstruction = 'Updated instruction';
await settingsService.saveSettings();
await settingsService.updateSettings(settings => {
settings.apiKeys.claude = 'updated-key';
settings.userInstruction = 'Updated instruction';
});
expect(mockPlugin.saveData).toHaveBeenCalledWith(
expect.objectContaining({
@ -373,7 +380,7 @@ describe('SettingsService', () => {
it('should handle saveData errors gracefully', async () => {
mockPlugin.saveData.mockRejectedValue(new Error('Save failed'));
await expect(settingsService.saveSettings()).rejects.toThrow('Save failed');
await expect(settingsService.updateSettings(() => {})).rejects.toThrow('Save failed');
});
});
@ -520,7 +527,7 @@ describe('SettingsService', () => {
snippetSizeLimit: 250
});
await settingsService.saveSettings();
await settingsService.updateSettings(() => {});
expect(mockPlugin.saveData).toHaveBeenCalledWith(
expect.objectContaining({
@ -533,10 +540,10 @@ describe('SettingsService', () => {
it('should handle modified limits in saveSettings', async () => {
settingsService = new SettingsService({});
settingsService.settings.searchResultsLimit = 100;
settingsService.settings.snippetSizeLimit = 600;
await settingsService.saveSettings();
await settingsService.updateSettings(settings => {
settings.searchResultsLimit = 100;
settings.snippetSizeLimit = 600;
});
expect(mockPlugin.saveData).toHaveBeenCalledWith(
expect.objectContaining({