obsidian-plugin/andy-stack_vaultkeeper-ai
1
0
Fork 0
mirror of https://github.com/andy-stack/vaultkeeper-ai.git synced 2026-07-22 06:42:03 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor: bundle assets at build time instead of loading from disk

Browse source 
Remove runtime asset loading from AssetsService by importing assets directly and configuring esbuild loaders for SVG (text) and PNG (dataurl). This ensures assets work in release builds where only main.js is shipped without the Assets folder.
This commit is contained in:
Andrew Beal 2026-06-01 00:04:39 +01:00
parent ca00242cd3
commit e5a9e4a24b
4 changed files with 23 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
Services/AssetsService.ts
View file

@ -1,30 +1,20 @@
import type VaultkeeperAIPlugin from "main";
import { Resolve } from "./DependencyService";
import { Services } from "./Services";
import { addIcon } from "obsidian";
import iconSvg from "../Assets/vaultkeeper-mono.svg";
import bannerSource from "../Assets/vaultkeeper-social-1280x330.png";
export class AssetsService {
private readonly plugin: VaultkeeperAIPlugin;
public pluginIcon: string = "";
public bannerSource: string = "";
public pluginIcon: string;
public bannerSource: string;
// Assets are bundled into main.js at build time (see esbuild loader config).
// They must NOT be read from disk at runtime: released/mobile installs ship
// only main.js, manifest.json and styles.css, so the Assets/ folder is absent.
public constructor() {
this.plugin = Resolve<VaultkeeperAIPlugin>(Services.VaultkeeperAIPlugin);
this.pluginIcon = this.addIcon(iconSvg, "vaultkeeper-ai-icon");
this.bannerSource = bannerSource;
}
public async loadAssets(): Promise<void> {
this.pluginIcon = this.addIcon(
await this.plugin.app.vault.adapter.read(`${this.plugin.manifest.dir}/Assets/vaultkeeper-mono.svg`),
"vaultkeeper-ai-icon"
);
this.bannerSource = this.plugin.app.vault.adapter.getResourcePath(
`${this.plugin.manifest.dir}/Assets/vaultkeeper-social-1280x330.png`
);
}
private addIcon(icon: string, name: string): string {
addIcon(name, icon);
return name;

2
esbuild.config.mjs
View file

@ -296,6 +296,8 @@ const buildOptions = {
minify: prod,
loader: {
".css": "css",
".svg": "text",
".png": "dataurl",
".ttf": "file",
".woff": "file",
".woff2": "file",

10
global.d.ts vendored
View file

@ -2,3 +2,13 @@ declare module '*.css' {
const content: string;
export default content;
}
declare module '*.svg' {
const content: string;
export default content;
}
declare module '*.png' {
const content: string;
export default content;
}

5
main.ts
View file

@ -20,10 +20,6 @@ export default class VaultkeeperAIPlugin extends Plugin {
public async onload() {
await RegisterPlugin(this);
const assetsService = Resolve<AssetsService>(Services.AssetsService);
await assetsService.loadAssets();
RegisterDependencies();
this.registerView(
@ -43,6 +39,7 @@ export default class VaultkeeperAIPlugin extends Plugin {
}
});
const assetsService = Resolve<AssetsService>(Services.AssetsService);
this.addRibbonIcon(assetsService.pluginIcon, "Vaultkeeper AI", async () => {
await this.activateMainView();
});