asyouplz
d16c04883e
lint: Fix Obsidian plugin review bot errors ( #43 )
...
* lint: Fix console.info usage for Obsidian compliance
- Replace console.info with console.debug in Logger.ts
- Replace console.info with console.debug in DeepgramLogger.ts
Required for ObsidianReviewBot compliance - only console.warn, console.error, console.debug are allowed.
* lint: Add ESLint configuration and auto-fix
- Add .eslintrc.json with Obsidian-compliant rules
- Run eslint --fix on all TypeScript files
- Configure console usage rules (warn, error, debug only)
- Enable prefer-const and no-var rules
- Add typescript-eslint recommended rules
Remaining: 162 warnings (0 errors)
All warnings are non-blocking (mostly @typescript-eslint/no-explicit-any)
Part of PR #8004 lint fixes for Obsidian Review Bot compliance.
* lint: Replace deprecated substr() with slice()
- NotificationSystem.ts: substr(2,9) → slice(2,11)
- NotificationManager.ts: substr(2,9) → slice(2,11)
Obsidian plugin review guideline compliance - substr is deprecated.
Part of PR #8004 lint fixes.
* lint: Replace confirm() with ConfirmationModal (1/5)
- SettingsTabOptimized.ts: Replace window.confirm with ConfirmationModal
- Add ConfirmationModal import
Obsidian plugin review guideline compliance - no window.confirm allowed.
Using Obsidian Modal API instead.
Remaining: 4 more confirm() calls to replace
Part of PR #8004 lint fixes.
* lint: Replace all confirm() calls with ConfirmationModal (5/5)
- AdvancedSettings.ts: 2 confirm() → ConfirmationModal
- SettingsTab.ts: 1 confirm() → ConfirmationModal
- StatisticsDashboard.ts: 1 confirm() → ConfirmationModal
- SettingsTabOptimized.ts: 1 confirm() → ConfirmationModal (previous commit)
All window.confirm() calls now use Obsidian Modal API.
Build successful.
Part of PR #43 - Obsidian lint fixes.
* lint: Fix UI text sentence case (49 instances)
Automated conversion to sentence case for UI text:
- .setName(), .setDesc(), .setButtonText(), .setPlaceholder()
- First letter capitalized, rest lowercase (except acronyms)
- Acronyms preserved: API, URL, HTTP, JSON, XML, ID, UI, CSS, HTML, TTL, SDK, CSV
Files modified (10):
- FormatOptions.ts: 4 changes
- EnhancedSettingsTab.ts: 6 changes
- SettingsTab.ts: 7 changes
- SettingsTabOptimized.ts: 1 change
- SettingsTabRefactored.ts: 1 change
- SimpleSettingsTab.ts: 4 changes
- DeepgramSettings.ts: 6 changes
- ProviderSettings.ts: 8 changes
- ProviderSettingsContainer.ts: 6 changes
- AdvancedSettingsPanel.ts: 6 changes
Build successful.
Part of PR #43 - Obsidian lint fixes.
* fix: Apply Prettier formatting to resolve CI errors
* chore: enhance CI/CD with Obsidian-level linting and release automation
- Consolidated ESLint config with TypeScript strict rules
- Added Obsidian plugin review bot compatible linting checks
- Fixed 45 TypeScript strict mode errors for type safety
- Implemented automatic version bump workflow via PR labels
- Created manual release script for local version management
- Added pre-commit hooks with Husky and lint-staged
- Updated release pipeline with tag-based trigger
- Enhanced documentation (LINT_RULES.md, RELEASE.md, BRANCH_PROTECTION.md)
- Updated README with comprehensive contributing and release guidelines
* fix(ci): Improve ESLint error detection in CI workflow
- Change grep pattern from 'error' to '[1-9][0-9]* error'
- Prevents false positive from '0 errors' string in lint output
- Fixes CI failure for PR #43
2026-01-19 02:08:56 +09:00
