Commit graph

10 commits

Author SHA1 Message Date
tslee
14af775f15 fix(review): reduce portal warnings 2026-05-18 17:31:02 +09:00
asyouplz
1b0c80b0ad
fix(ui): namespace review-target css selectors (#84) 2026-03-19 12:31:42 +09:00
asyouplz
98210a349f
Fix/pr8004 settings sentence case followups (#80)
* fix(ui): align settings review follow-ups

Standardize remaining runtime settings copy to English, namespace provider settings selectors,
and apply the sentence-case cleanup flagged in review.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(ui): align sentence case for settings copy

Normalize the settings UI strings flagged by the review bot to plain sentence case
and remove emoji-prefixed labels from the affected headings and options.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(ui): enforce sentence case for settings copy

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-15 21:57:42 +09:00
asyouplz
0f6c3ac218
fix(ui): address pr 8004 human review feedback (#70)
Standardize reviewed UI copy to English, namespace plugin CSS selectors,
and replace ad hoc SVG creation with shared Obsidian-friendly icons.
Also remove the empty fundingUrl field and start tracking styles.css
so the review fixes ship with the plugin.

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-10 15:16:31 +09:00
asyouplz
5cf1effdeb Address PR #8004 Review Feedback and Improve Compliance (#44)
* fix: address PR #8004 review feedback and improve type safety

* fix: restore legacy password factors and fix formatting

* fix: finalize PR feedback following Obsidian review compliance

* fix: finalize PR feedback with technical refinements and obsidian compliance

* fix: finalize PR refinements following Claude Code feedback and repo cleanup

* fix: remove legacy migration logic and further simplify codebase for obsidian compliance

* refactor: final cleanup of unused variables and improved type safety for PR #44

* style: fix formatting issues to resolve CI pipeline error
2026-01-19 17:23:06 +09:00
asyouplz
daa575efd3 fix: address reviewbot style issues and bump 3.0.3 (#36)
* feat: migrate Deepgram to Nova 3

* fix: address reviewbot style issues and bump 3.0.3
2025-12-16 11:11:56 +09:00
Taesun Lee
c49e75e157 chore: merge main and resolve conflicts
- Merged latest main branch changes
- Resolved conflicts in main.js, SettingsTab.ts, styles.css
- Added Support Section from main (createSupportSection method)
- Preserved review bot fixes (console.debug, DOM API)
- Combined utility classes and support separator styles
- Rebuilt bundle: 148.51 KB

Changes:
- SettingsTab: Added createSupportSection while keeping debug method
- styles.css: Combined sn-* utilities with speech-to-text-separator
- main.js: Rebuilt with all changes

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-10-09 14:49:44 +09:00
Taesun Lee
82a4af22ac fix: address Obsidian community plugin review requirements
Required fixes:
- Replace innerHTML/outerHTML with DOM API methods for XSS prevention
- Move inline styles to CSS classes for theme compatibility
- Add instanceof type guards for TFile/TFolder handling
- Remove console.log statements from production code
- Convert fetch() to requestUrl() for cross-platform support

Technical changes:
- Security: All innerHTML/outerHTML replaced with createEl/createDiv/createSvg
  - StatisticsDashboard: DOM-based table/chart rendering
  - UI components: SVG icons built programmatically
  - Error/notification systems: Safe DOM construction

- Styling: Inline styles migrated to CSS classes
  - Added utility classes: .sn-hidden, .sn-fade, .sn-info-box
  - Preserved dynamic styles for progress bars and charts
  - Enhanced theme compatibility

- Type safety: Added file/folder type guards
  - New: src/utils/fs/typeGuards.ts with assertTFile helper
  - Replaced unsafe casts with instanceof checks
  - Improved test mocking with structural typing

- Logging: Cleaned up console statements
  - Removed production console.log calls
  - Preserved console.debug for debug mode
  - Routed logs through Logger class

- Networking: fetch() → requestUrl() migration
  - APIKeyManager: 2 API validation calls converted
  - BatchRequestManager: Updated for Obsidian compatibility

Test improvements:
- E2E: Implemented settings flow mocking (15/15 tests passing)
- Fixed: Settings migration for legacy language codes (korean→ko)
- Fixed: NotificationManager duplicate prevention (timer-based)
- Fixed: WhisperService cancellation logging
- Fixed: FileUploadManager compression fallback
- Fixed: EditorService workspace.off guard

Build verification:
- Bundle size: 148KB (within 150KB target)
- Console statements: Removed from production build
- All 222 tests passing
- Lint:  (167 warnings, no errors)
- TypeCheck: 

Ready for Obsidian review bot re-check.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-10-09 13:53:54 +09:00
asyouplz
67d05c9239 feat: add support section to settings page (#30)
Add a dedicated support section at the bottom of the settings page that includes:
- Visual separator to distinguish from other settings
- Thank you message to users
- "Buy me a coffee" button with CTA styling
- Opens support link in new tab

This provides users with an easy way to support the plugin development while maintaining a non-intrusive placement.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude <noreply@anthropic.com>
2025-10-03 00:04:02 +09:00
asyouplz
7f776af999 Initial commit: Obsidian Speech-to-Text Plugin
- Set up project structure and architecture
- Implement core transcription services with OpenAI Whisper API
- Add comprehensive UI components and settings
- Create documentation in Korean and English
- Establish testing framework and examples

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-08-25 20:00:43 +09:00