obsidian-plugin/callumalpass_tasknotes
1
0
Fork 0
mirror of https://github.com/callumalpass/tasknotes.git synced 2026-07-22 12:50:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(docs): correct PropertyMappingService.basesToInternal() logic

Browse source 
The original plan had a critical bug: after stripping the Bases property prefix
(note./task./file.), it never tried FieldMapper on the stripped name.

Example scenario:
- User configures: "state" → "status" (in FieldMapper)
- Bases provides: "note.state"
- Bug: Would return "state" instead of "status"

Fixed logic now:
1. Try FieldMapper on full ID (edge case)
2. Strip prefix: "note.state" → "state"
3. Try FieldMapper on stripped name: "state" → "status"
4. Return internal field name: "status"

This ensures TaskCard properly recognizes user-configured property names
and renders the appropriate UI (e.g., status checkbox for "state" property).
This commit is contained in:
callumalpass 2025-11-04 10:32:42 +11:00
parent 39fa73fee1
commit 7e61a0ee13
1 changed files with 62 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

79
REFACTOR_PLAN.md
View file

@ -334,12 +334,17 @@ import { FieldMapper } from "../services/FieldMapper";
/**
* Complete property mapping chain:
* 1. Bases Property ID → TaskCard Property ID
* 2. TaskCard Property ID → Internal Field Name
* 3. Internal Field Name → User-Configured Property Name
* 1. Bases Property ID → Internal Field Name (via FieldMapper)
* 2. Internal Field Name → User-Configured Property Name (for frontmatter I/O)
*
* Example flow:
* "note.status" → "status" → "status" → "task-status" (if user configured)
* Example flow (user configured "state" as their status property):
* - User adds "note.state" column in Bases
* - basesToInternal("note.state"):
* 1. Strip prefix: "note.state" → "state"
* 2. FieldMapper.fromUserField("state") → "status"
* 3. Returns: "status" (internal field name)
* - TaskCard uses PROPERTY_EXTRACTORS["status"] to get task.status
* - TaskCard uses PROPERTY_RENDERERS["status"] to render status UI (checkbox, dot)
*/
export class PropertyMappingService {
constructor(
@ -351,13 +356,17 @@ export class PropertyMappingService {
* Map Bases property ID to the internal field name used by TaskInfo.
* This is the complete chain: Bases → TaskCard → Internal.
*
* @param basesPropertyId - Property ID from Bases (e.g., "note.status", "file.name")
* Example: User configures "state" as their status property
* - Bases gives us: "note.state"
* - We strip prefix: "state"
* - FieldMapper maps: "state" → "status"
* - Returns: "status" (internal field name)
*
* @param basesPropertyId - Property ID from Bases (e.g., "note.state", "file.name")
* @returns Internal field name (e.g., "status", "title")
*/
basesToInternal(basesPropertyId: BasesPropertyId): string {
let mapped = basesPropertyId;
// Step 1: Try custom field mapping first (highest priority)
// Step 1: Try custom field mapping on full ID first (edge case: user configured "note.state")
if (this.fieldMapper) {
const internalFieldName = this.fieldMapper.fromUserField(basesPropertyId);
if (internalFieldName) {
@ -365,22 +374,58 @@ export class PropertyMappingService {
}
}
// Step 2: Handle dotted prefixes (note., task., file., formula.)
// Step 2: Handle dotted prefixes - strip and try FieldMapper again
if (basesPropertyId.startsWith("note.")) {
mapped = basesPropertyId.substring(5);
} else if (basesPropertyId.startsWith("task.")) {
mapped = basesPropertyId.substring(5);
} else if (basesPropertyId.startsWith("file.")) {
const stripped = basesPropertyId.substring(5); // "note.state" → "state"
// Try custom field mapping on stripped name (main case!)
if (this.fieldMapper) {
const internalFieldName = this.fieldMapper.fromUserField(stripped);
if (internalFieldName) {
return this.applySpecialTransformations(internalFieldName);
}
}
// Handle known note properties
if (stripped === "dateCreated") return "dateCreated";
if (stripped === "dateModified") return "dateModified";
if (stripped === "completedDate") return "completedDate";
return this.applySpecialTransformations(stripped);
}
if (basesPropertyId.startsWith("task.")) {
const stripped = basesPropertyId.substring(5);
// Try custom field mapping on stripped name
if (this.fieldMapper) {
const internalFieldName = this.fieldMapper.fromUserField(stripped);
if (internalFieldName) {
return this.applySpecialTransformations(internalFieldName);
}
}
return this.applySpecialTransformations(stripped);
}
if (basesPropertyId.startsWith("file.")) {
// Map file properties to TaskInfo equivalents
if (basesPropertyId === "file.ctime") return "dateCreated";
if (basesPropertyId === "file.mtime") return "dateModified";
if (basesPropertyId === "file.name") return "title";
if (basesPropertyId === "file.basename") return "title";
mapped = basesPropertyId.substring(5);
const stripped = basesPropertyId.substring(5);
return this.applySpecialTransformations(stripped);
}
// Step 3: Apply special transformations
return this.applySpecialTransformations(mapped);
// Step 3: Keep formula properties unchanged
if (basesPropertyId.startsWith("formula.")) {
return basesPropertyId;
}
// Step 4: Direct property (no prefix) - apply special transformations
return this.applySpecialTransformations(basesPropertyId);
}
/**