From 15118b9423cc56970e8e7d896e72d6a3c9bf18ac Mon Sep 17 00:00:00 2001
From: Gabriele Cannata <Canna71@users.noreply.github.com>
Date: Mon, 7 Aug 2023 18:14:43 +0200
Subject: [PATCH] Min height constraint

---
 src/Views/SheetView.ts |  4 ++++
 styles.scss            | 20 ++++++++++++++++++++
 2 files changed, 24 insertions(+)

diff --git a/src/Views/SheetView.ts b/src/Views/SheetView.ts
index a18bd0f..10b7ca0 100644
--- a/src/Views/SheetView.ts
+++ b/src/Views/SheetView.ts
@@ -32,6 +32,8 @@ const DEFAULT_OPTIONS = {
     cellWidth: 100,
 };
 
+const MINHEIGHT = 400;
+
 const saveIcon =
     "data:image/svg+xml;base64,PD94bWwgdmVyc2lvbj0iMS4wIiBzdGFuZGFsb25lPSJubyI/PjwhRE9DVFlQRSBzdmcgUFVCTElDICItLy9XM0MvL0RURCBTVkcgMS4xLy9FTiIgImh0dHA6Ly93d3cudzMub3JnL0dyYXBoaWNzL1NWRy8xLjEvRFREL3N2ZzExLmR0ZCI+PHN2ZyB0PSIxNTc3MTc3MDkyOTg4IiBjbGFzcz0iaWNvbiIgdmlld0JveD0iMCAwIDEwMjQgMTAyNCIgdmVyc2lvbj0iMS4xIiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHAtaWQ9IjI2NzgiIHdpZHRoPSIxOCIgaGVpZ2h0PSIxOCIgeG1sbnM6eGxpbms9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGxpbmsiPjxkZWZzPjxzdHlsZSB0eXBlPSJ0ZXh0L2NzcyI+PC9zdHlsZT48L2RlZnM+PHBhdGggZD0iTTIxMy4zMzMzMzMgMTI4aDU5Ny4zMzMzMzRhODUuMzMzMzMzIDg1LjMzMzMzMyAwIDAgMSA4NS4zMzMzMzMgODUuMzMzMzMzdjU5Ny4zMzMzMzRhODUuMzMzMzMzIDg1LjMzMzMzMyAwIDAgMS04NS4zMzMzMzMgODUuMzMzMzMzSDIxMy4zMzMzMzNhODUuMzMzMzMzIDg1LjMzMzMzMyAwIDAgMS04NS4zMzMzMzMtODUuMzMzMzMzVjIxMy4zMzMzMzNhODUuMzMzMzMzIDg1LjMzMzMzMyAwIDAgMSA4NS4zMzMzMzMtODUuMzMzMzMzeiBtMzY2LjkzMzMzNCAxMjhoMzQuMTMzMzMzYTI1LjYgMjUuNiAwIDAgMSAyNS42IDI1LjZ2MTE5LjQ2NjY2N2EyNS42IDI1LjYgMCAwIDEtMjUuNiAyNS42aC0zNC4xMzMzMzNhMjUuNiAyNS42IDAgMCAxLTI1LjYtMjUuNlYyODEuNmEyNS42IDI1LjYgMCAwIDEgMjUuNi0yNS42ek0yMTMuMzMzMzMzIDIxMy4zMzMzMzN2NTk3LjMzMzMzNGg1OTcuMzMzMzM0VjIxMy4zMzMzMzNIMjEzLjMzMzMzM3ogbTEyOCAwdjI1NmgzNDEuMzMzMzM0VjIxMy4zMzMzMzNoODUuMzMzMzMzdjI5OC42NjY2NjdhNDIuNjY2NjY3IDQyLjY2NjY2NyAwIDAgMS00Mi42NjY2NjcgNDIuNjY2NjY3SDI5OC42NjY2NjdhNDIuNjY2NjY3IDQyLjY2NjY2NyAwIDAgMS00Mi42NjY2NjctNDIuNjY2NjY3VjIxMy4zMzMzMzNoODUuMzMzMzMzek0yNTYgMjEzLjMzMzMzM2g4NS4zMzMzMzMtODUuMzMzMzMzeiBtNDI2LjY2NjY2NyAwaDg1LjMzMzMzMy04NS4zMzMzMzN6IG0wIDU5Ny4zMzMzMzR2LTEyOEgzNDEuMzMzMzMzdjEyOEgyNTZ2LTE3MC42NjY2NjdhNDIuNjY2NjY3IDQyLjY2NjY2NyAwIDAgMSA0Mi42NjY2NjctNDIuNjY2NjY3aDQyNi42NjY2NjZhNDIuNjY2NjY3IDQyLjY2NjY2NyAwIDAgMSA0Mi42NjY2NjcgNDIuNjY2NjY3djE3MC42NjY2NjdoLTg1LjMzMzMzM3ogbTg1LjMzMzMzMyAwaC04NS4zMzMzMzMgODUuMzMzMzMzek0zNDEuMzMzMzMzIDgxMC42NjY2NjdIMjU2aDg1LjMzMzMzM3oiIHAtaWQ9IjI2NzkiIGZpbGw9IiMyYzJjMmMiPjwvcGF0aD48L3N2Zz4=";
 
@@ -59,6 +61,8 @@ export function processCodeBlock(
 
     const options = { ...DEFAULT_OPTIONS, ...parseYaml(source) };
     
+    options.height = Math.max(options.height, MINHEIGHT);
+
     const {
         filename,
         height,
diff --git a/styles.scss b/styles.scss
index 527689c..65c2a9d 100644
--- a/styles.scss
+++ b/styles.scss
@@ -197,3 +197,23 @@ ul.x-spreadsheet-menu {
         font-weight: bold;
     }
  }
+
+.x-spreadsheet-icon-img.arrow-down {
+    margin: 0;
+    border: 0;
+}
+
+// TODO: create custom classes for each dropdown item, then sets limits accordingly
+// we suppose a min height of 400px for the whole spreadhsheet
+
+// .x-spreadsheet-dropdown .x-spreadsheet-dropdown-content {
+//     max-height: 300px;
+//     overflow-y: auto;
+// }
+
+// .x-spreadsheet-dropdown-content .x-spreadsheet-dropdown-content {
+//     z-index: 201;
+//     .x-spreadsheet-dropdown-content {
+//         z-index: 202;
+//     }
+// }
\ No newline at end of file