From d9c7cd65f94644fbc76321f4dba19f0140bc1c38 Mon Sep 17 00:00:00 2001
From: celeste <parafactual@gmail.com>
Date: Wed, 22 Nov 2023 04:12:04 -0600
Subject: [PATCH] fix best of ux

---
 manifest.json | 2 +-
 package.json  | 2 +-
 views.ts      | 5 +++--
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/manifest.json b/manifest.json
index 91cc8be..f848528 100644
--- a/manifest.json
+++ b/manifest.json
@@ -1,7 +1,7 @@
 {
 	"id": "loom",
 	"name": "Loom",
-	"version": "1.20.0",
+	"version": "1.20.1",
 	"minAppVersion": "0.15.0",
 	"description": "Loom in Obsidian",
 	"author": "celeste",
diff --git a/package.json b/package.json
index 860dff4..ca03e10 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
 	"name": "obsidian-loom",
-	"version": "1.20.0",
+	"version": "1.20.1",
 	"description": "Loom in Obsidian",
 	"main": "main.js",
 	"scripts": {
diff --git a/views.ts b/views.ts
index 34a6f2e..b55dab7 100644
--- a/views.ts
+++ b/views.ts
@@ -340,13 +340,14 @@ export class LoomView extends ItemView {
 	  label: string,
 	  setting: string,
 	  value: string,
-	  type: "string" | "int" | "float"
+	  type: "string" | "int" | "int?" | "float"
 	) => {
 	  if (!settings.visibility[setting]) return;
 
       const parsers = {
 	    "string": (value: string) => value,
 		"int": (value: string) => parseInt(value),
+		"int?": (value: string) => value === "" ? 0 : parseInt(value),
 		"float": (value: string) => parseFloat(value),
 	  };
 
@@ -364,7 +365,7 @@ export class LoomView extends ItemView {
 
 	setting("Length (in tokens)", "maxTokens", String(settings.maxTokens), "int");
 	setting("Number of completions", "n", String(settings.n), "int");
-    setting("Best of (0 = no beam search)", "bestOf", String(settings.bestOf), "int");
+    setting("Best of", "bestOf", settings.bestOf === 0 ? "" : String(settings.bestOf), "int?");
 	setting("Temperature", "temperature", String(settings.temperature), "float");
 	setting("Top p", "topP", String(settings.topP), "float");
 	setting("Frequency penalty", "frequencyPenalty", String(settings.frequencyPenalty), "float");