From 16b0436e450ceb7c6ea9d1944b2e1eaeb310bf23 Mon Sep 17 00:00:00 2001 From: Aleix Soler Date: Mon, 5 May 2025 15:14:43 +0200 Subject: [PATCH] chore: use the setTooltip function --- ui/components/status-bar.ts | 10 ++++------ ui/components/status-dropdown-component.ts | 8 +++----- ui/integrations/explorer-integration.ts | 5 ++--- 3 files changed, 9 insertions(+), 14 deletions(-) diff --git a/ui/components/status-bar.ts b/ui/components/status-bar.ts index 1eff005..44c38a6 100644 --- a/ui/components/status-bar.ts +++ b/ui/components/status-bar.ts @@ -1,3 +1,4 @@ +import { setTooltip } from 'obsidian'; import { NoteStatusSettings } from '../../models/types'; import { StatusService } from '../../services/status-service'; @@ -65,8 +66,7 @@ export class StatusBar { }); // Add tooltip - statusText.setAttribute('aria-label', tooltipValue); - statusText.setAttribute('data-tooltip-position', 'top'); + setTooltip(statusText, tooltipValue); // Create status icon const statusIcon = this.statusBarEl.createEl('span', { @@ -75,8 +75,7 @@ export class StatusBar { }); // Add tooltip to icon too - statusIcon.setAttribute('aria-label', tooltipValue); - statusIcon.setAttribute('data-tooltip-position', 'top'); + setTooltip(statusIcon, tooltipValue); } else { // Display multiple statuses // Create status text @@ -100,8 +99,7 @@ export class StatusBar { }); // Add tooltip - badge.setAttribute('aria-label', tooltipValue); - badge.setAttribute('data-tooltip-position', 'top'); + setTooltip(badge, tooltipValue); badge.createEl('span', { text: this.statusService.getStatusIcon(status), diff --git a/ui/components/status-dropdown-component.ts b/ui/components/status-dropdown-component.ts index 7b86ca8..c3a993d 100644 --- a/ui/components/status-dropdown-component.ts +++ b/ui/components/status-dropdown-component.ts @@ -1,4 +1,4 @@ -import { App, setIcon, TFile } from 'obsidian'; +import { App, setIcon, TFile, setTooltip } from 'obsidian'; import { NoteStatusSettings, Status } from '../../models/types'; import { StatusService } from '../../services/status-service'; @@ -320,8 +320,7 @@ export class StatusDropdownComponent { const tooltipValue = statusObj?.description ? `${status} - ${statusObj.description}`: status; // Add tooltip to the chip element - chipEl.setAttribute('aria-label', tooltipValue); - chipEl.setAttribute('data-tooltip-position', 'top'); + setTooltip(chipEl, tooltipValue); const removeBtn = chipEl.createDiv({ cls: 'note-status-chip-remove', @@ -456,8 +455,7 @@ export class StatusDropdownComponent { // Add tooltip with description if available if (status.description) { - optionEl.setAttribute('aria-label', `${status.name} - ${status.description}`); - optionEl.setAttribute('data-tooltip-position', 'right'); + setTooltip(optionEl, `${status.name} - ${status.description}`); } // Check icon for selected status diff --git a/ui/integrations/explorer-integration.ts b/ui/integrations/explorer-integration.ts index d1652fc..df2b21b 100644 --- a/ui/integrations/explorer-integration.ts +++ b/ui/integrations/explorer-integration.ts @@ -1,4 +1,4 @@ -import { App, TFile, debounce } from 'obsidian'; +import { App, TFile, debounce, setTooltip } from 'obsidian'; import { FileExplorerView, NoteStatusSettings } from '../../models/types'; import { StatusService } from '../../services/status-service'; @@ -237,8 +237,7 @@ export class ExplorerIntegration { // Add tooltip with status name const statusObj = this.statusService.getAllStatuses().find(s => s.name === status); const tooltipValue = statusObj?.description ? `${status} - ${statusObj.description}`: status; - iconEl.setAttribute('aria-label', tooltipValue); - iconEl.setAttribute('data-tooltip-position', 'right'); + setTooltip(iconEl, tooltipValue); } /**