From bdb8ce457f9a0adc7c8a2e56e35599debf0331c3 Mon Sep 17 00:00:00 2001
From: Aleix Soler <aleixsoler64@gmail.com>
Date: Sat, 19 Jul 2025 17:36:58 +0200
Subject: [PATCH] chore: remove insert metadata command; no status icon

---
 components/StatusBar/StatusBar.tsx            | 10 ++++-
 .../StatusDashboard/QuickActionsPanel.tsx     |  9 -----
 core/commandsService.ts                       | 38 +------------------
 core/noteStatusService.ts                     | 36 +++++++++++-------
 integrations/views/status-dashboard-view.tsx  |  5 ---
 wiki/User Manual.md                           |  1 -
 6 files changed, 32 insertions(+), 67 deletions(-)

diff --git a/components/StatusBar/StatusBar.tsx b/components/StatusBar/StatusBar.tsx
index 23ad753..45ff688 100644
--- a/components/StatusBar/StatusBar.tsx
+++ b/components/StatusBar/StatusBar.tsx
@@ -23,7 +23,15 @@ export const StatusBar: FC<Props> = ({
 
 	if (!hasStatuses) {
 		if (hideIfNotStatuses) return null;
-		return <span className="status-bar-item">❓</span>;
+		return (
+			<span
+				className="status-bar-item mod-clickable"
+				onClick={() => onStatusClick({ name: "", icon: "" })}
+				style={{ cursor: "pointer" }}
+			>
+				No status
+			</span>
+		);
 	}
 
 	return (
diff --git a/components/StatusDashboard/QuickActionsPanel.tsx b/components/StatusDashboard/QuickActionsPanel.tsx
index 5534d24..f7286bd 100644
--- a/components/StatusDashboard/QuickActionsPanel.tsx
+++ b/components/StatusDashboard/QuickActionsPanel.tsx
@@ -3,7 +3,6 @@ export type DashboardAction =
 	| "open-grouped-view"
 	| "find-unassigned"
 	| "change-status"
-	| "insert-metadata"
 	| "cycle-status"
 	| "clear-status"
 	| "copy-status"
@@ -88,14 +87,6 @@ export const QuickActionsPanel = ({
 					>
 						📝 Change Status
 					</button>
-					<button
-						className="quick-action-btn"
-						onClick={() => onAction("insert-metadata")}
-						disabled={!hasCurrentFile}
-						title="Insert status metadata in editor"
-					>
-						📝 Insert Metadata
-					</button>
 					<button
 						className="quick-action-btn"
 						onClick={() => onAction("cycle-status")}
diff --git a/core/commandsService.ts b/core/commandsService.ts
index 5f57a80..a7a1e47 100644
--- a/core/commandsService.ts
+++ b/core/commandsService.ts
@@ -1,4 +1,4 @@
-import { Plugin, Notice, Editor, MarkdownView, TFile, App } from "obsidian";
+import { Plugin, Notice, TFile, App } from "obsidian";
 import { NoteStatusService, BaseNoteStatusService } from "./noteStatusService";
 import settingsService from "./settingsService";
 import eventBus from "./eventBus";
@@ -40,42 +40,6 @@ export class CommandsService {
 		});
 		this.registeredCommands.add("change-status");
 
-		// Insert status metadata
-		this.plugin.addCommand({
-			id: "insert-status-metadata",
-			name: "Insert status metadata",
-			editorCheckCallback: (
-				checking: boolean,
-				editor: Editor,
-				view: MarkdownView,
-			) => {
-				if (!view.file) return false;
-
-				const cache = this.plugin.app.metadataCache.getFileCache(
-					view.file,
-				);
-				const frontmatter = cache?.frontmatter;
-
-				// Check if any frontmatter property starts with tagPrefix
-				let hasFronttmatter = false;
-				if (frontmatter) {
-					hasFronttmatter = Object.keys(frontmatter).some((key) =>
-						key.startsWith(settingsService.settings.tagPrefix),
-					);
-				}
-
-				if (!checking && !hasFronttmatter) {
-					BaseNoteStatusService.insertStatusMetadataInEditor(
-						view.file,
-					).then(() => {
-						new Notice("Status metadata inserted");
-					});
-				}
-				return !hasFronttmatter;
-			},
-		});
-		this.registeredCommands.add("insert-status-metadata");
-
 		// Cycle through statuses
 		this.plugin.addCommand({
 			id: "cycle-status",
diff --git a/core/noteStatusService.ts b/core/noteStatusService.ts
index 97f9274..e797587 100644
--- a/core/noteStatusService.ts
+++ b/core/noteStatusService.ts
@@ -38,20 +38,20 @@ export abstract class BaseNoteStatusService {
 		return availableStatuses;
 	}
 
-	static async insertStatusMetadataInEditor(file: TFile): Promise<void> {
-		const tagPrefix = settingsService.settings.tagPrefix;
-
-		await BaseNoteStatusService.app.fileManager.processFrontMatter(
-			file,
-			(frontmatter) => {
-				const noteStatusFrontmatter =
-					(frontmatter?.[tagPrefix] as string[]) || [];
-				if (!noteStatusFrontmatter.length) {
-					frontmatter[tagPrefix] = [];
-				}
-			},
-		);
-	}
+	// static async insertStatusMetadataInEditor(file: TFile): Promise<void> {
+	// 	const tagPrefix = settingsService.settings.tagPrefix;
+	//
+	// 	await BaseNoteStatusService.app.fileManager.processFrontMatter(
+	// 		file,
+	// 		(frontmatter) => {
+	// 			const noteStatusFrontmatter =
+	// 				(frontmatter?.[tagPrefix] as string[]) || [];
+	// 			if (!noteStatusFrontmatter.length) {
+	// 				frontmatter[tagPrefix] = [];
+	// 			}
+	// 		},
+	// 	);
+	// }
 
 	protected statusNameToObject(statusName: NoteStatusType["name"]) {
 		const availableStatuses =
@@ -204,6 +204,14 @@ export class NoteStatusService extends BaseNoteStatusService {
 					frontmatter[frontmatterTagName] = [statusIdentifier];
 					added = true;
 				} else {
+					// Ensure frontmatter property exists as an array
+					if (
+						!frontmatter[frontmatterTagName] ||
+						!Array.isArray(frontmatter[frontmatterTagName])
+					) {
+						frontmatter[frontmatterTagName] = [];
+					}
+
 					const i = noteStatusFrontmatter.findIndex(
 						(statusName: string) => statusName === statusIdentifier,
 					);
diff --git a/integrations/views/status-dashboard-view.tsx b/integrations/views/status-dashboard-view.tsx
index a3e6176..734f7a4 100644
--- a/integrations/views/status-dashboard-view.tsx
+++ b/integrations/views/status-dashboard-view.tsx
@@ -169,11 +169,6 @@ export class StatusDashboardView extends ItemView {
 					"note-status:change-status",
 				);
 				break;
-			case "insert-metadata":
-				appWithCommands.commands.executeCommandById(
-					"note-status:insert-status-metadata",
-				);
-				break;
 			case "cycle-status":
 				appWithCommands.commands.executeCommandById(
 					"note-status:cycle-status",
diff --git a/wiki/User Manual.md b/wiki/User Manual.md
index 62d0851..eddce00 100644
--- a/wiki/User Manual.md	
+++ b/wiki/User Manual.md	
@@ -177,7 +177,6 @@ All commands available via Command Palette:
 - `Open status pane` - Show status sidebar
 - `Change status of current note` - Open dropdown
 - `Add status to current note` - Add mode dropdown
-- `Insert status metadata` - Add frontmatter
 - `Cycle to next status` - Rotate through statuses
 - `Clear status` - Set to unknown