From 187c0d17b2decfc080139ecbbb15af76016498fc Mon Sep 17 00:00:00 2001 From: Claude Date: Wed, 29 Apr 2026 08:07:48 +0000 Subject: [PATCH] fix(i18n): pass translated Cancel/OK labels to confirmRegenerateEditedCards Adds cancelLabel and okLabel parameters with safe English defaults; caller in main.ts now passes plugin.t() values so button text matches UI language. https://claude.ai/code/session_012cK5rUGQvqkuxUZ59x7dLn --- main.ts | 8 +++++++- src/modal.ts | 12 +++++++++--- 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/main.ts b/main.ts index 367f6a1..c541d9f 100644 --- a/main.ts +++ b/main.ts @@ -327,7 +327,13 @@ class ParallelReaderPlugin extends Plugin { } confirmRegenerateEditedCards(): Promise { - return confirmRegenerateEditedCards(this.app, this.t('displayName'), this.t('confirmRegenerateEditedCards')); + return confirmRegenerateEditedCards( + this.app, + this.t('displayName'), + this.t('confirmRegenerateEditedCards'), + this.t('editCardCancel'), + this.t('editCardSave'), + ); } addFileMenuItems(menu: ObsidianMenu, file: unknown) { diff --git a/src/modal.ts b/src/modal.ts index fac1687..4b89e20 100644 --- a/src/modal.ts +++ b/src/modal.ts @@ -4,7 +4,13 @@ import { type App, Modal } from 'obsidian'; import type { CardPatch, PluginHost, ResolvedCard } from './types'; import { addTextButton } from './ui-helpers'; -export function confirmRegenerateEditedCards(app: App, title: string, message: string): Promise { +export function confirmRegenerateEditedCards( + app: App, + title: string, + message: string, + cancelLabel = 'Cancel', + okLabel = 'OK', +): Promise { return new Promise((resolve) => { let settled = false; const settle = (value: boolean) => { @@ -16,11 +22,11 @@ export function confirmRegenerateEditedCards(app: App, title: string, message: s modal.titleEl.setText(title); modal.contentEl.createEl('p', { text: message }); const btnRow = modal.contentEl.createDiv({ cls: 'modal-button-container' }); - btnRow.createEl('button', { text: 'Cancel' }).addEventListener('click', () => { + btnRow.createEl('button', { text: cancelLabel }).addEventListener('click', () => { modal.close(); settle(false); }); - btnRow.createEl('button', { text: 'OK', cls: 'mod-cta' }).addEventListener('click', () => { + btnRow.createEl('button', { text: okLabel, cls: 'mod-cta' }).addEventListener('click', () => { modal.close(); settle(true); });