From d058348f6f0dcb70b909a8a424d3bc36c31b9815 Mon Sep 17 00:00:00 2001
From: fancivez <fancive@gmail.com>
Date: Sat, 2 May 2026 14:10:49 +0800
Subject: [PATCH] =?UTF-8?q?fix:=20regressions=20in=201.0.12=20=E2=80=94=20?=
 =?UTF-8?q?sidebar=20render=20guard=20+=20open-view=20toggle?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Two regressions reported after 1.0.12 was installed:

1. Hotkey-triggered Generate did not update the sidebar. PR2 added
   `viewIsShowingFile(view, file)` guards to renderLoading/loadFor/
   renderError in runForFile to keep batch (silentView) jobs from
   disturbing a panel showing a different note. The guard was applied
   to all paths, breaking the interactive case: when the sidebar had
   never been opened (sourceFile=null) or was showing a different note,
   every render call was skipped and the sidebar stayed blank while
   generation completed in the background.

   Fix: compute `shouldRender = !silentView || viewIsShowingFile(...)`
   once. Non-silent (user pressed Generate on this file) renders
   unconditionally; silentView keeps the existing "only if it's already
   this file" behaviour.

2. The open-view command had no toggle behaviour. Pressing the hotkey a
   second time silently re-opened the same panel.

   Fix: if a parallel-reader leaf already exists, detach it; otherwise
   ensureView + sync.

Change-Id: I1db3d70806d8d07965d18bf3717023de027ac577
---
 main.ts | 19 +++++++++++++++----
 1 file changed, 15 insertions(+), 4 deletions(-)

diff --git a/main.ts b/main.ts
index 02b4bc2..4eeb252 100644
--- a/main.ts
+++ b/main.ts
@@ -90,6 +90,11 @@ class ParallelReaderPlugin extends Plugin {
       id: 'open-view',
       name: this.t('cmdOpenView'),
       callback: async () => {
+        const leaves = this.app.workspace.getLeavesOfType(VIEW_TYPE_PARALLEL);
+        if (leaves.length > 0) {
+          for (const leaf of leaves) leaf.detach();
+          return;
+        }
         const active = this.getActiveView();
         const view = await this.ensureView();
         if (!view) return;
@@ -497,12 +502,18 @@ class ParallelReaderPlugin extends Plugin {
         }
         job.throwIfCancelled();
 
+        // In non-silent mode the user explicitly asked to generate THIS file —
+        // bind the view to it (so subsequent viewIsShowingFile guards pass and
+        // streaming/loadFor render correctly even if the panel was previously
+        // showing a different note).
+        const shouldRender = !options.silentView || this.viewIsShowingFile(view, file);
+
         job.setPhase('cache-check');
         if (!force) {
           const entry = this.cacheManager.get(file.path);
           if (entry && cacheEntryMatches(entry, content, this.settings)) {
             this.cacheTouch(file.path);
-            if (view && this.activeFileStillMatches(file)) {
+            if (view && shouldRender && this.activeFileStillMatches(file)) {
               view.loadFor(file, resolveCardAnchors(content, entry.cards), false);
             }
             outcome = 'cached';
@@ -510,7 +521,7 @@ class ParallelReaderPlugin extends Plugin {
           }
         }
 
-        if (view && this.viewIsShowingFile(view, file)) view.renderLoading(file, this.t('loadingGenerating'));
+        if (view && shouldRender) view.renderLoading(file, this.t('loadingGenerating'));
         const maxDocChars = Number(this.settings.maxDocChars) || DEFAULT_SETTINGS.maxDocChars;
         if (content.length > maxDocChars) new Notice(this.t('longNoteTruncated', { count: maxDocChars }));
         new Notice(this.t('generatingNotice'));
@@ -519,7 +530,7 @@ class ParallelReaderPlugin extends Plugin {
         const sections = await summarizeDocument(content, this.settings, job, this.streamProgressFor(view, file));
         job.throwIfCancelled();
         if (sections.length === 0) {
-          if (view && this.viewIsShowingFile(view, file)) view.renderError(file, this.t('noCardsReturned'));
+          if (view && shouldRender) view.renderError(file, this.t('noCardsReturned'));
           new Notice(this.t('noCardsReturned'));
           outcome = 'empty';
           return;
@@ -528,7 +539,7 @@ class ParallelReaderPlugin extends Plugin {
         job.setPhase('saving');
         await this.cacheManager.put(file.path, content, rawCards, this.settings);
         job.throwIfCancelled();
-        if (view && this.viewIsShowingFile(view, file)) view.loadFor(file, sections, false);
+        if (view && shouldRender) view.loadFor(file, sections, false);
         const unanchored = sections.filter((s) => s.startLine < 0).length;
         new Notice(
           this.t('generationDone', {