mirror of
https://github.com/fancive/obsidian-parallel-reader.git
synced 2026-07-22 06:53:43 +00:00
7986f1c308
Two valid findings from an opposite-model (Codex) review of this branch:
- provider-request: drop bare `unknown`/`unrecognized` from the structured-output
rejection keywords. They false-positive on model-name errors ("unknown model",
"unrecognized model ID" from Ollama/Bedrock), triggering a wasted fallback
retry. The specific feature tokens + bare `schema` still cover real structured-
output rejections, so true-positive detection is unaffected.
- streaming: streamErrorMessage's OpenAI-style `{error:{...}}` branch now only
treats the payload as an error when it carries a message/type, so a stray empty
`error: {}` (or code-only object) in a normal chunk no longer aborts the stream.
The Anthropic `{type:'error'}` branch still always signals an error.
Declined: Codex's suggestion to convert streaming's HTTP>=400 to ProviderApiError
+ add fallback — the streaming path always sends `structured:false`, so there is
no structured request to fall back from.
Tests updated/added: model-name 400s do not retry; empty/code-only error objects
do not throw.
Change-Id: I413d633c8ce7036365f97e2d8e1287c111e0902f
|
||
|---|---|---|
| .. | ||
| anchor.test.js | ||
| architecture.test.js | ||
| backend-test.test.js | ||
| cache.test.js | ||
| cards-nav.test.js | ||
| catalog.json | ||
| cli.test.js | ||
| coverage-sourcemap.js | ||
| direct-batch.test.js | ||
| direct-cache.test.js | ||
| direct-generation.test.js | ||
| direct-i18n.test.js | ||
| direct-markdown.test.js | ||
| direct-prompt.test.js | ||
| direct-providers.test.js | ||
| direct-settings-extra.test.js | ||
| direct-settings.test.js | ||
| direct-streaming.test.js | ||
| direct-test-setup.js | ||
| generation-job-manager.test.js | ||
| i18n.test.js | ||
| markdown.test.js | ||
| obsidian-mock.js | ||
| plugin-batch.test.js | ||
| providers.test.js | ||
| schema.test.js | ||
| scroll.test.js | ||
| settings.test.js | ||
| streaming.test.js | ||
| test-exports.test.js | ||
| test-setup.js | ||
| vault-batch.test.js | ||
| view-render.test.js | ||