mirror of
https://github.com/fancive/obsidian-parallel-reader.git
synced 2026-07-22 06:53:43 +00:00
76d2e8050a
Findings from the original review (P2): - streaming: flush unterminated final SSE event at EOF (some providers close the stream without a trailing blank line, dropping the last delta) - cache-manager: validate entry shape on load — drop entries where cards is not an array, anchor is not a string, or bullets is not an array. Tolerates missing optional fields (treated as cache miss). - view: card edit/delete now check cacheReplaceCards return and surface failures via a localized Notice instead of pretending success - main: clear-current / clear-all / file-menu-clear refresh open view via renderEmpty so stale UI does not display deleted data - prompt + settings-tab: card count is normalized via a single helper used by buildPrompts and onChange. Prompt and fingerprint stay in sync. UI value is written back to the textbox after clamping. - generation-job-manager: global concurrency limit (default 3) with a cancellable wait queue. Race-safe slot accounting via a reserved counter so resolved-but-not-yet-set waiters are visible to fast-path start() callers. - runForFile: now returns RunForFileResult; accepts preloadedContent + silentView + skipEditConfirm options used by batch (and reflected on the PluginHost interface). - batch: avoid double file read, do not steal UI focus, classify results correctly (generated / cached / already-running / empty / ...) Follow-up from the 1.0.11 review: - generationFingerprint: codex backend excludes settings.model from the hash. Codex ignores --model; previously editing model spuriously invalidated all codex cache. Codex review pass: - generation-job-manager: race fix — releaseSlot's resolve microtask and a synchronous start() fast-path could briefly overshoot maxConcurrent. Reserve the slot synchronously inside the wrapped resolve to close the window. - cache-manager: anchor type validation in addition to bullets. NOTE: Codex backend users will see a one-time "stale cache" banner on existing notes due to the fingerprint change; regenerate to refresh. Change-Id: I7721c7dfe51dea3f51b0215764f721523c2f6806 |
||
|---|---|---|
| .. | ||
| anchor.ts | ||
| batch.ts | ||
| cache-manager.ts | ||
| cache.ts | ||
| cards.ts | ||
| cli.ts | ||
| generation-job-manager.ts | ||
| generation.ts | ||
| i18n-strings.ts | ||
| i18n.ts | ||
| markdown.ts | ||
| modal.ts | ||
| navigation.ts | ||
| prompt.ts | ||
| provider-bodies.ts | ||
| provider-parsers.ts | ||
| provider-presets.ts | ||
| provider-request.ts | ||
| providers.ts | ||
| schema.ts | ||
| scroll.ts | ||
| settings-tab.ts | ||
| settings.ts | ||
| streaming.ts | ||
| test-exports.ts | ||
| types.ts | ||
| ui-helpers.ts | ||
| vault.ts | ||
| view.ts | ||