obsidian-plugin/firstsun-dev_git-files-sync
1
0
Fork 0
mirror of https://github.com/firstsun-dev/git-files-sync.git synced 2026-07-22 17:20:30 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(settings): mask personal access token fields

Browse source 
Token fields for GitLab, GitHub, and Gitea were plain text inputs, so
tokens were visible in plaintext during screen shares, recordings, or
on shared machines. They're now password-type inputs with a toggle
(eye icon) to reveal them when the user needs to verify what they
pasted.
This commit is contained in:
ClaudiaFang 2026-07-05 05:19:46 +00:00
parent 1111308a2d
commit 235d9e0976
1 changed files with 61 additions and 34 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

95
src/settings.ts
View file

@ -1,4 +1,4 @@
import {App, PluginSettingTab, Setting, Notice} from 'obsidian';
import {App, PluginSettingTab, Setting, Notice, TextComponent} from 'obsidian';
import GitLabFilesPush from "./main";
export interface SyncMetadata {
@ -193,18 +193,45 @@ export class GitLabSyncSettingTab extends PluginSettingTab {
}));
}
private displayGitLabSettings(containerEl: HTMLElement): void {
// Token fields are masked like a password input (with a toggle to reveal
// them) since they're secrets that shouldn't sit in plaintext on screen
// during screen shares, recordings, or shared machines.
private addTokenSetting(containerEl: HTMLElement, name: string, desc: string, getValue: () => string, onChange: (value: string) => void): void {
let textComponent: TextComponent;
new Setting(containerEl)
.setName('GitLab personal access token')
.setDesc('Create a token in GitLab user settings > access tokens with "API" scope')
.addText(text => text
.setPlaceholder('Enter your token')
.setValue(this.plugin.settings.gitlabToken)
.onChange((value) => {
this.plugin.settings.gitlabToken = value;
void this.plugin.saveSettings();
this.plugin.initializeGitService();
}));
.setName(name)
.setDesc(desc)
.addText(text => {
textComponent = text;
text.inputEl.type = 'password';
text.setPlaceholder('Enter your token')
.setValue(getValue())
.onChange(onChange);
})
.addExtraButton(btn => {
btn.setIcon('eye')
.setTooltip('Show token')
.onClick(() => {
const revealing = textComponent.inputEl.type === 'password';
textComponent.inputEl.type = revealing ? 'text' : 'password';
btn.setIcon(revealing ? 'eye-off' : 'eye');
btn.setTooltip(revealing ? 'Hide token' : 'Show token');
});
});
}
private displayGitLabSettings(containerEl: HTMLElement): void {
this.addTokenSetting(
containerEl,
'GitLab personal access token',
'Create a token in GitLab user settings > access tokens with "API" scope',
() => this.plugin.settings.gitlabToken,
(value) => {
this.plugin.settings.gitlabToken = value;
void this.plugin.saveSettings();
this.plugin.initializeGitService();
}
);
new Setting(containerEl)
.setName('GitLab base URL')
@ -232,17 +259,17 @@ export class GitLabSyncSettingTab extends PluginSettingTab {
}
private displayGiteaSettings(containerEl: HTMLElement): void {
new Setting(containerEl)
.setName('Gitea personal access token')
.setDesc('Create a token in user settings > applications > access tokens')
.addText(text => text
.setPlaceholder('Enter your token')
.setValue(this.plugin.settings.giteaToken)
.onChange((value) => {
this.plugin.settings.giteaToken = value;
void this.plugin.saveSettings();
this.plugin.initializeGitService();
}));
this.addTokenSetting(
containerEl,
'Gitea personal access token',
'Create a token in user settings > applications > access tokens',
() => this.plugin.settings.giteaToken,
(value) => {
this.plugin.settings.giteaToken = value;
void this.plugin.saveSettings();
this.plugin.initializeGitService();
}
);
new Setting(containerEl)
.setName('Gitea base URL')
@ -282,17 +309,17 @@ export class GitLabSyncSettingTab extends PluginSettingTab {
}
private displayGitHubSettings(containerEl: HTMLElement): void {
new Setting(containerEl)
.setName('GitHub personal access token')
.setDesc('Create a token in GitHub settings > developer settings > personal access tokens with "repo" scope')
.addText(text => text
.setPlaceholder('Enter your token')
.setValue(this.plugin.settings.githubToken)
.onChange((value) => {
this.plugin.settings.githubToken = value;
void this.plugin.saveSettings();
this.plugin.initializeGitService();
}));
this.addTokenSetting(
containerEl,
'GitHub personal access token',
'Create a token in GitHub settings > developer settings > personal access tokens with "repo" scope',
() => this.plugin.settings.githubToken,
(value) => {
this.plugin.settings.githubToken = value;
void this.plugin.saveSettings();
this.plugin.initializeGitService();
}
);
new Setting(containerEl)
.setName('Repository owner')