obsidian-plugin/firstsun-dev_git-files-sync
1
0
Fork 0
mirror of https://github.com/firstsun-dev/git-files-sync.git synced 2026-07-22 06:54:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(tests): dedupe TextComponent/TextAreaComponent mocks

Browse source 
Extract shared setPlaceholder/setValue/onChange/triggerChange logic
into a BaseTextComponent<T> generic to fix SonarCloud's new-code
duplication gate on PR #49 (8.3% > 3% threshold).
This commit is contained in:
ClaudiaFang 2026-07-13 12:33:11 +00:00
parent 597989b53c
commit f5ae8ef16d
1 changed files with 17 additions and 32 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

49
tests/setup.ts
View file

@ -41,13 +41,12 @@ export const PluginSettingTab = class {
}
};
export const TextComponent = class {
inputEl: HTMLInputElement;
private changeHandler?: (value: string) => void;
class BaseTextComponent<T extends HTMLInputElement | HTMLTextAreaElement> {
inputEl: T;
protected changeHandler?: (value: string) => void;
constructor(containerEl?: HTMLElement) {
this.inputEl = document.createElement('input');
containerEl?.appendChild(this.inputEl);
constructor(inputEl: T) {
this.inputEl = inputEl;
}
setPlaceholder(value: string) {
@ -69,35 +68,21 @@ export const TextComponent = class {
this.inputEl.value = value;
this.changeHandler?.(value);
}
}
export const TextComponent = class extends BaseTextComponent<HTMLInputElement> {
constructor(containerEl?: HTMLElement) {
const inputEl = document.createElement('input');
containerEl?.appendChild(inputEl);
super(inputEl);
}
};
export const TextAreaComponent = class {
inputEl: HTMLTextAreaElement;
private changeHandler?: (value: string) => void;
export const TextAreaComponent = class extends BaseTextComponent<HTMLTextAreaElement> {
constructor(containerEl?: HTMLElement) {
this.inputEl = document.createElement('textarea');
containerEl?.appendChild(this.inputEl);
}
setPlaceholder(value: string) {
this.inputEl.placeholder = value;
return this;
}
setValue(value: string) {
this.inputEl.value = value;
return this;
}
onChange(handler: (value: string) => void) {
this.changeHandler = handler;
return this;
}
triggerChange(value: string) {
this.inputEl.value = value;
this.changeHandler?.(value);
const inputEl = document.createElement('textarea');
containerEl?.appendChild(inputEl);
super(inputEl);
}
};