mirror of
https://github.com/firstsun-dev/git-files-sync.git
synced 2026-07-22 17:20:30 +00:00
This commit consolidates several improvements to satisfy SonarCloud Quality Gate and enhance the overall plugin stability: - Code Quality & Refactoring: - Reduced duplication to 0% by refactoring SyncManager and SyncStatusView. - Implemented centralized 'processBatch' logic for multi-file sync operations. - Fixed security hotspots by replacing legacy atob/btoa with Buffer. - Added memory safety limits to the diff algorithm to prevent DoS. - Test Coverage & Reliability: - Improved SyncManager coverage to 81.8% and GitignoreManager to 92.8%. - Added comprehensive unit tests for batch operations and complex .gitignore patterns. - Resolved all ESLint 'unsafe-member-access' and 'unbound-method' warnings in tests. - Infrastructure & Metadata: - Consolidated GitHub Actions into a single optimized 'ci.yml' using latest versions (v6-v8). - Synchronized manifest.json and versions.json to v1.1.0. - Fixed workflow permission issues identified by CodeQL.
288 lines
12 KiB
TypeScript
288 lines
12 KiB
TypeScript
import { describe, it, expect, vi, beforeEach } from 'vitest';
|
|
import { SyncManager } from '../../src/logic/sync-manager';
|
|
|
|
// Mock dependencies
|
|
import { App, TFile, Notice } from 'obsidian';
|
|
import { SyncConflictModal } from '../../src/ui/SyncConflictModal';
|
|
|
|
vi.mock('../../src/ui/SyncConflictModal');
|
|
import { GitLabService } from '../../src/services/gitlab-service';
|
|
import { GitLabFilesPushSettings } from '../../src/settings';
|
|
|
|
const mockApp = {
|
|
vault: {
|
|
read: vi.fn(),
|
|
modify: vi.fn(),
|
|
getFileByPath: vi.fn(),
|
|
}
|
|
} as unknown as App;
|
|
|
|
const mockGitLab = {
|
|
pushFile: vi.fn(),
|
|
getFile: vi.fn(),
|
|
} as unknown as GitLabService;
|
|
|
|
const mockSettings: GitLabFilesPushSettings = {
|
|
serviceType: 'gitlab',
|
|
gitlabToken: 'token',
|
|
gitlabBaseUrl: 'https://gitlab.com',
|
|
projectId: '123',
|
|
githubToken: '',
|
|
githubOwner: '',
|
|
githubRepo: '',
|
|
branch: 'main',
|
|
rootPath: '',
|
|
syncMetadata: {},
|
|
vaultFolder: ''
|
|
};
|
|
|
|
describe('SyncManager', () => {
|
|
let manager: SyncManager;
|
|
|
|
beforeEach(() => {
|
|
vi.clearAllMocks();
|
|
// Default: file exists in vault
|
|
vi.spyOn(mockApp.vault, 'getFileByPath').mockReturnValue(new TFile());
|
|
manager = new SyncManager(mockApp, mockGitLab, mockSettings);
|
|
});
|
|
|
|
it('should push file content correctly', async () => {
|
|
const mockFile = Object.assign(new TFile(), { path: 'test.md', name: 'test.md' });
|
|
const readSpy = vi.spyOn(mockApp.vault, 'read').mockResolvedValue('local content');
|
|
const getSpy = vi.spyOn(mockGitLab, 'getFile').mockResolvedValue({ content: '', sha: '' });
|
|
const pushSpy = vi.spyOn(mockGitLab, 'pushFile').mockResolvedValue('test.md');
|
|
|
|
await manager.pushFile(mockFile);
|
|
|
|
expect(readSpy).toHaveBeenCalledWith(mockFile);
|
|
expect(getSpy).toHaveBeenCalled();
|
|
expect(pushSpy).toHaveBeenCalledWith(
|
|
'test.md',
|
|
'local content',
|
|
'main',
|
|
'Update test.md from Obsidian',
|
|
''
|
|
);
|
|
});
|
|
|
|
it('should detect conflict when remote SHA differs from last synced SHA', async () => {
|
|
const mockFile = Object.assign(new TFile(), { path: 'test.md', name: 'test.md' });
|
|
|
|
// Setup metadata with an old SHA
|
|
mockSettings.syncMetadata['test.md'] = {
|
|
lastSyncedSha: 'old-sha',
|
|
lastSyncedAt: Date.now()
|
|
};
|
|
|
|
vi.spyOn(mockApp.vault, 'read').mockResolvedValue('local content');
|
|
// Mock GitLab returning a different remote SHA
|
|
vi.spyOn(mockGitLab, 'getFile').mockResolvedValue({ content: 'remote content', sha: 'new-remote-sha' });
|
|
|
|
const modalMock = vi.mocked(SyncConflictModal);
|
|
|
|
await manager.pushFile(mockFile);
|
|
|
|
expect(modalMock).toHaveBeenCalled();
|
|
});
|
|
|
|
it('should handle conflict by choosing local', async () => {
|
|
const mockFile = Object.assign(new TFile(), { path: 'test.md', name: 'test.md' });
|
|
mockSettings.syncMetadata['test.md'] = { lastSyncedSha: 'old', lastSyncedAt: 0 };
|
|
|
|
vi.spyOn(mockApp.vault, 'read').mockResolvedValue('local content');
|
|
vi.spyOn(mockGitLab, 'getFile').mockResolvedValueOnce({ content: 'remote content', sha: 'remote-sha' });
|
|
vi.spyOn(mockGitLab, 'pushFile').mockResolvedValue('test.md');
|
|
vi.spyOn(mockGitLab, 'getFile').mockResolvedValue({ content: 'local content', sha: 'new-sha' });
|
|
|
|
const modalMock = vi.mocked(SyncConflictModal);
|
|
|
|
// Capture the callback passed to the modal
|
|
let callback: (choice: 'local' | 'remote') => void = () => { };
|
|
modalMock.mockImplementation(function (this: SyncConflictModal, app: App, fileName: string, local: string, remote: string, onChoose: (choice: 'local' | 'remote') => void) {
|
|
callback = onChoose;
|
|
(this as unknown as Record<string, unknown>).open = vi.fn();
|
|
(this as unknown as Record<string, unknown>).close = vi.fn();
|
|
(this as unknown as Record<string, unknown>).app = app;
|
|
(this as unknown as Record<string, unknown>).setTitle = vi.fn().mockReturnThis();
|
|
});
|
|
|
|
await manager.pushFile(mockFile);
|
|
|
|
// Simulate user choosing 'local'
|
|
callback('local');
|
|
|
|
// Wait for async operations in callback
|
|
await new Promise(resolve => setTimeout(resolve, 0));
|
|
|
|
const pushSpy = vi.spyOn(mockGitLab, 'pushFile');
|
|
expect(pushSpy).toHaveBeenCalledWith('test.md', 'local content', 'main', 'Update test.md from Obsidian', 'remote-sha');
|
|
expect(mockSettings.syncMetadata['test.md']?.lastSyncedSha).toBe('new-sha');
|
|
});
|
|
|
|
it('should handle conflict by choosing remote', async () => {
|
|
const mockFile = Object.assign(new TFile(), { path: 'test.md', name: 'test.md' });
|
|
mockSettings.syncMetadata['test.md'] = { lastSyncedSha: 'old', lastSyncedAt: 0 };
|
|
|
|
vi.spyOn(mockApp.vault, 'read').mockResolvedValue('local content');
|
|
vi.spyOn(mockGitLab, 'getFile').mockResolvedValue({ content: 'remote content', sha: 'remote-sha' });
|
|
const modifySpy = vi.spyOn(mockApp.vault, 'modify').mockResolvedValue();
|
|
|
|
const modalMock = vi.mocked(SyncConflictModal);
|
|
|
|
let callback: (choice: 'local' | 'remote') => void = () => { };
|
|
modalMock.mockImplementation(function (this: SyncConflictModal, app: App, fileName: string, local: string, remote: string, onChoose: (choice: 'local' | 'remote') => void) {
|
|
callback = onChoose;
|
|
(this as unknown as Record<string, unknown>).open = vi.fn();
|
|
(this as unknown as Record<string, unknown>).close = vi.fn();
|
|
(this as unknown as Record<string, unknown>).app = app;
|
|
(this as unknown as Record<string, unknown>).setTitle = vi.fn().mockReturnThis();
|
|
});
|
|
|
|
await manager.pushFile(mockFile);
|
|
|
|
// Simulate user choosing 'remote'
|
|
callback('remote');
|
|
|
|
// Wait for async operations in callback
|
|
await new Promise(resolve => setTimeout(resolve, 50));
|
|
|
|
expect(modifySpy).toHaveBeenCalledWith(mockFile, 'remote content');
|
|
expect(mockSettings.syncMetadata['test.md']?.lastSyncedSha).toBe('remote-sha');
|
|
});
|
|
|
|
it('should update metadata after successful push', async () => {
|
|
const mockFile = Object.assign(new TFile(), { path: 'test.md', name: 'test.md' });
|
|
mockSettings.syncMetadata = {};
|
|
|
|
vi.spyOn(mockApp.vault, 'read').mockResolvedValue('local content');
|
|
// First call for conflict detection
|
|
vi.spyOn(mockGitLab, 'getFile').mockResolvedValueOnce({ content: '', sha: '' });
|
|
vi.spyOn(mockGitLab, 'pushFile').mockResolvedValue('test.md');
|
|
|
|
// Second call for metadata update
|
|
vi.spyOn(mockGitLab, 'getFile').mockResolvedValue({ content: 'local content', sha: 'new-sha' });
|
|
|
|
await manager.pushFile(mockFile);
|
|
|
|
expect(mockSettings.syncMetadata['test.md']).toBeDefined();
|
|
expect(mockSettings.syncMetadata['test.md']?.lastSyncedSha).toBe('new-sha');
|
|
});
|
|
|
|
it('should pull and modify file content correctly and update metadata', async () => {
|
|
const mockFile = Object.assign(new TFile(), { path: 'test.md', name: 'test.md' });
|
|
mockSettings.syncMetadata = {};
|
|
|
|
vi.spyOn(mockApp.vault, 'read').mockResolvedValue('old content');
|
|
const modifySpy = vi.spyOn(mockApp.vault, 'modify').mockResolvedValue();
|
|
const getSpy = vi.spyOn(mockGitLab, 'getFile').mockResolvedValue({ content: 'new content', sha: 'sha' });
|
|
|
|
await manager.pullFile(mockFile);
|
|
|
|
expect(modifySpy).toHaveBeenCalledWith(mockFile, 'new content');
|
|
expect(getSpy).toHaveBeenCalled();
|
|
expect(mockSettings.syncMetadata['test.md']?.lastSyncedSha).toBe('sha');
|
|
});
|
|
|
|
it('should handle file not existing in vault', async () => {
|
|
const mockFile = Object.assign(new TFile(), { path: 'non-existent.md', name: 'non-existent.md' });
|
|
vi.spyOn(mockApp.vault, 'getFileByPath').mockReturnValue(null);
|
|
|
|
await manager.pushFile(mockFile);
|
|
|
|
const getFileSpy = vi.spyOn(mockGitLab, 'getFile');
|
|
const pushFileSpy = vi.spyOn(mockGitLab, 'pushFile');
|
|
expect(getFileSpy).not.toHaveBeenCalled();
|
|
expect(pushFileSpy).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it('should add new file to repo when it exists locally but not on remote', async () => {
|
|
const mockFile = Object.assign(new TFile(), { path: 'new.md', name: 'new.md' });
|
|
mockSettings.syncMetadata = {};
|
|
|
|
vi.spyOn(mockApp.vault, 'read').mockResolvedValue('new local content');
|
|
// Remote returns 404/empty
|
|
vi.spyOn(mockGitLab, 'getFile').mockResolvedValueOnce({ content: '', sha: '' });
|
|
vi.spyOn(mockGitLab, 'pushFile').mockResolvedValue('new.md');
|
|
vi.spyOn(mockGitLab, 'getFile').mockResolvedValue({ content: 'new local content', sha: 'new-sha' });
|
|
|
|
await manager.pushFile(mockFile);
|
|
|
|
const pushFileSpy = vi.spyOn(mockGitLab, 'pushFile');
|
|
expect(pushFileSpy).toHaveBeenCalledWith(
|
|
'new.md',
|
|
'new local content',
|
|
'main',
|
|
'Update new.md from Obsidian',
|
|
''
|
|
);
|
|
expect(mockSettings.syncMetadata['new.md']?.lastSyncedSha).toBe('new-sha');
|
|
});
|
|
|
|
describe('Renames and Moves', () => {
|
|
it('should detect and handle file rename', async () => {
|
|
const oldPath = 'old.md';
|
|
const newPath = 'new.md';
|
|
const mockFile = Object.assign(new TFile(), { path: newPath, name: 'new.md' });
|
|
|
|
// Setup metadata for the old path
|
|
mockSettings.syncMetadata[oldPath] = {
|
|
lastSyncedSha: 'old-sha',
|
|
lastSyncedAt: Date.now(),
|
|
lastKnownPath: oldPath
|
|
};
|
|
|
|
// Mock: old file no longer exists in vault
|
|
vi.spyOn(mockApp.vault, 'getFileByPath').mockImplementation((path) => {
|
|
if (path === oldPath) return null;
|
|
if (path === newPath) return mockFile;
|
|
return null;
|
|
});
|
|
|
|
vi.spyOn(mockApp.vault, 'read').mockResolvedValue('content');
|
|
vi.spyOn(mockGitLab, 'pushFile').mockResolvedValue(newPath);
|
|
vi.spyOn(mockGitLab, 'getFile').mockResolvedValue({ content: 'content', sha: 'new-sha' });
|
|
|
|
await manager.pushFile(mockFile);
|
|
|
|
expect(mockGitLab.pushFile).toHaveBeenCalledWith(
|
|
newPath,
|
|
'content',
|
|
'main',
|
|
`Rename ${oldPath} to ${newPath}`,
|
|
undefined
|
|
);
|
|
expect(mockSettings.syncMetadata[oldPath]).toBeUndefined();
|
|
expect(mockSettings.syncMetadata[newPath]?.lastSyncedSha).toBe('new-sha');
|
|
});
|
|
});
|
|
|
|
describe('Error Handling', () => {
|
|
it('should handle push errors gracefully', async () => {
|
|
const mockFile = Object.assign(new TFile(), { path: 'fail.md', name: 'fail.md' });
|
|
vi.spyOn(mockApp.vault, 'read').mockResolvedValue('content');
|
|
vi.spyOn(mockGitLab, 'getFile').mockResolvedValue({ content: '', sha: '' });
|
|
vi.spyOn(mockGitLab, 'pushFile').mockRejectedValue(new Error('Network error'));
|
|
|
|
const consoleSpy = vi.spyOn(console, 'error').mockImplementation(() => {});
|
|
|
|
await manager.pushFile(mockFile);
|
|
|
|
expect(consoleSpy).toHaveBeenCalled();
|
|
expect(vi.mocked(Notice)).toHaveBeenCalledWith(expect.stringContaining('Failed to push'));
|
|
});
|
|
|
|
it('should handle rename errors gracefully', async () => {
|
|
const oldPath = 'old.md';
|
|
const newPath = 'new.md';
|
|
const mockFile = Object.assign(new TFile(), { path: newPath, name: 'new.md' });
|
|
mockSettings.syncMetadata[oldPath] = { lastSyncedSha: 's', lastSyncedAt: 0, lastKnownPath: oldPath };
|
|
|
|
vi.spyOn(mockApp.vault, 'getFileByPath').mockImplementation(p => p === oldPath ? null : mockFile);
|
|
vi.spyOn(mockApp.vault, 'read').mockResolvedValue('c');
|
|
vi.spyOn(mockGitLab, 'pushFile').mockRejectedValue(new Error('Rename failed'));
|
|
|
|
await manager.pushFile(mockFile);
|
|
expect(vi.mocked(Notice)).toHaveBeenCalledWith(expect.stringContaining('Failed to handle rename'));
|
|
});
|
|
});
|
|
});
|