refactor: remove redundant eslint-disable comments from setting definitions

This commit is contained in:
Rhys 2026-05-05 08:20:36 +02:00
parent 227d36fd4c
commit de92cd3d01

View file

@ -117,13 +117,11 @@ class DocDropSettingTab extends PluginSettingTab {
.setDesc(
// /skip -- PATH is an environment variable, all-caps is correct
// /skip -- "markitdown" is the tool's actual lowercase name
// eslint-disable-next-line obsidianmd/ui/sentence-case -- PATH is an env var (all-caps correct); "markitdown" is the tool's canonical lowercase name
'Full path to the markitdown binary, or just "markitdown" if it is on your PATH.'
)
.addText((text) =>
text
// /skip -- "markitdown" is the tool's actual lowercase name
// eslint-disable-next-line obsidianmd/ui/sentence-case -- "markitdown" is the tool's canonical lowercase name
.setPlaceholder("markitdown")
.setValue(this.plugin.settings.executablePath)
.onChange((value) => {
@ -152,7 +150,6 @@ class DocDropSettingTab extends PluginSettingTab {
.setName("Custom output folder")
.setDesc(
// /skip -- "Converted" is an example folder name shown verbatim, not a UI label
// eslint-disable-next-line obsidianmd/ui/sentence-case -- "Converted" is an example folder name shown verbatim, not a UI label
'Vault-relative path, e.g. "Converted". The folder must already exist.'
)
.addText((text) =>
@ -188,7 +185,6 @@ class DocDropSettingTab extends PluginSettingTab {
new Setting(containerEl)
// /skip -- MIME is an acronym, all-caps is correct
// eslint-disable-next-line obsidianmd/ui/sentence-case -- MIME is an acronym, all-caps correct
.setName("MIME type hint")
.setDesc(
"Tells markitdown what kind of file it is receiving, e.g. \"application/pdf\". " +
@ -198,7 +194,6 @@ class DocDropSettingTab extends PluginSettingTab {
.addText((text) =>
text
// /skip -- "application/pdf" is a MIME type string, lowercase per spec
// eslint-disable-next-line obsidianmd/ui/sentence-case -- "application/pdf" is a MIME type string, lowercase per spec
.setPlaceholder("application/pdf")
.setValue(this.plugin.settings.mimeType)
.onChange((value) => {
@ -227,7 +222,6 @@ class DocDropSettingTab extends PluginSettingTab {
new Setting(containerEl)
// /skip -- "markitdown-ocr" is the tool's actual lowercase name
// eslint-disable-next-line obsidianmd/ui/sentence-case -- "markitdown-ocr" is the tool's canonical lowercase name
.setName("markitdown-ocr plugin (optional)")
.setHeading();
@ -268,7 +262,6 @@ class DocDropSettingTab extends PluginSettingTab {
.addText((text) => {
text
// /skip -- "sk-proj-..." is an API key format placeholder, lowercase is the actual format
// eslint-disable-next-line obsidianmd/ui/sentence-case -- "sk-proj-..." is an API key format placeholder, lowercase is the actual format
.setPlaceholder("sk-proj-...")
.setValue(this.plugin.settings.openAiApiKey)
.onChange((value) => {
@ -288,7 +281,6 @@ class DocDropSettingTab extends PluginSettingTab {
.addText((text) =>
text
// /skip -- "gpt-4o" is the model's API identifier, lowercase per OpenAI convention
// eslint-disable-next-line obsidianmd/ui/sentence-case -- "gpt-4o" is the model's API identifier, lowercase per OpenAI convention
.setPlaceholder("gpt-4o")
.setValue(this.plugin.settings.openAiModel)
.onChange((value) => {
@ -308,7 +300,6 @@ class DocDropSettingTab extends PluginSettingTab {
.addText((text) =>
text
// /skip -- URL placeholder, case-sensitive and must match actual endpoint
// eslint-disable-next-line obsidianmd/ui/sentence-case -- URL placeholder, case-sensitive and must match actual endpoint
.setPlaceholder("https://api.openai.com/v1")
.setValue(this.plugin.settings.openAiBaseUrl)
.onChange((value) => {
@ -322,7 +313,6 @@ class DocDropSettingTab extends PluginSettingTab {
new Setting(containerEl)
// /skip -- "Document Intelligence" is a proper Microsoft product name
// eslint-disable-next-line obsidianmd/ui/sentence-case -- "Azure Document Intelligence" is a proper Microsoft product name
.setName("Azure Document Intelligence (optional)")
.setHeading();
@ -337,7 +327,6 @@ class DocDropSettingTab extends PluginSettingTab {
new Setting(containerEl)
// /skip -- "Document Intelligence" is a proper Microsoft product name
// eslint-disable-next-line obsidianmd/ui/sentence-case -- "Document Intelligence" is a proper Microsoft product name
.setName("Use Document Intelligence")
.setDesc(
"Send the PDF to Microsoft Azure for conversion instead of processing it locally. " +
@ -364,7 +353,6 @@ class DocDropSettingTab extends PluginSettingTab {
.addText((text) =>
text
// /skip -- URL placeholder, case-sensitive and must match actual endpoint format
// eslint-disable-next-line obsidianmd/ui/sentence-case -- URL placeholder, case-sensitive and must match actual endpoint format
.setPlaceholder("https://your-resource.cognitiveservices.azure.com/")
.setValue(this.plugin.settings.docIntelEndpoint)
.onChange((value) => {
@ -383,7 +371,6 @@ class DocDropSettingTab extends PluginSettingTab {
.addText((text) => {
text
// /skip -- "Azure" is a proper noun
// eslint-disable-next-line obsidianmd/ui/sentence-case -- "Azure" is a proper noun
.setPlaceholder("Your Azure API key")
.setValue(this.plugin.settings.docIntelApiKey)
.onChange((value) => {
@ -431,7 +418,6 @@ export default class DocDropPlugin extends Plugin {
menu.addItem((item) => {
item
// /skip -- "DocDrop" is the plugin's proper name
// eslint-disable-next-line obsidianmd/ui/sentence-case -- "DocDrop" is the plugin's proper name
.setTitle("Convert to Markdown with DocDrop")
.setIcon("file-text")
.onClick(() => this.convertPdf(file));
@ -454,7 +440,6 @@ export default class DocDropPlugin extends Plugin {
const adapter = this.app.vault.adapter;
if (!(adapter instanceof FileSystemAdapter)) {
// /skip -- "DocDrop" is the plugin's proper name
// eslint-disable-next-line obsidianmd/ui/sentence-case -- "DocDrop" is the plugin's proper name
new Notice("DocDrop only works on desktop (local vault).");
return;
}