test(08): persist human verification items as UAT

.planning/phases/08-type-hygiene-conventions/08-HUMAN-UAT.md

@@ -0,0 +1,28 @@
+---
+status: partial
+phase: 08-type-hygiene-conventions
+source: [08-VERIFICATION.md]
+started: 2026-05-17T14:00:00Z
+updated: 2026-05-17T14:00:00Z
+---
+
+## Current Test
+
+[awaiting human testing]
+
+## Tests
+
+### 1. Fresh Obsidian community-plugin Review scorecard run against v1.15 main-branch snapshot
+expected: Zero remaining "Avoid ..." findings from the v1.13.1 report — the milestone-level closing criterion
+result: [pending]
+
+## Summary
+
+total: 1
+passed: 0
+issues: 0
+pending: 1
+skipped: 0
+blocked: 0
+
+## Gaps

.planning/phases/08-type-hygiene-conventions/08-VERIFICATION.md

@@ -0,0 +1,131 @@
+---
+phase: 08-type-hygiene-conventions
+verified: 2026-05-17T14:00:00Z
+status: human_needed
+score: 5/6 must-haves verified
+overrides_applied: 0
+human_verification:
+  - test: "Run a fresh Obsidian community-plugin Review scorecard against the v1.15 main-branch snapshot"
+    expected: "Zero remaining 'Avoid ...' findings from the v1.13.1 report"
+    why_human: "The scorecard is an external tool that must be run manually against the deployed plugin; cannot be verified programmatically from the source tree alone. Success Criterion 6 (milestone-level scorecard clean) requires running the actual review tool."
+---
+
+# Phase 8: Type Hygiene & Conventions Verification Report
+
+**Phase Goal:** Close the final cluster of directory findings — console logging, TypeScript hygiene (`any`, nullish-on-LHS-of-`??`, lexical decls in `case`, unnecessary regex escapes), and the 21 named unused vars/imports — and land the conventions document as the closing commit so every rule learned across the milestone is captured for future work.
+**Verified:** 2026-05-17T14:00:00Z
+**Status:** human_needed
+**Re-verification:** No — initial verification
+
+## Goal Achievement
+
+### Observable Truths
+
+| # | Truth | Status | Evidence |
+|---|-------|--------|---------|
+| 1 | The four scorecard-flagged `console.*` sites are gone; full source tree has zero bare `console.*` lines; remaining 6 forensic sites are gated behind `const DEBUG = false` | ✓ VERIFIED | `grep -rnE '^\s*console\.' src/` returns 0; `grep -rcE 'if \(DEBUG\) console\.' src/` shows `CalendarService.ts:4` and `timezoneUtils.ts:2`; `const DEBUG = false` declared in both files |
+| 2 | `npm run lint` reports zero `no-explicit-any`, zero `no-case-declarations`, zero `no-useless-escape`, and zero `??`-with-constant-LHS violations | ✓ VERIFIED | `npm run lint` exits 0 with no output; `src/utils/pathUtils.ts:47` has block-scoped case body; `src/utils/viewRenderers.ts:370` has `[-/]` (not `[-\/]`); `??` audit shows only a docs-comment hit at SettingsTab.ts:262 |
+| 3 | `npm run lint` reports zero `no-unused-vars` violations; all 21 scorecard-named symbols are deleted or genuinely consumed | ✓ VERIFIED | `npm run lint` exits 0; all 18 violation-sites from the research inventory are gone (confirmed by per-symbol greps per 08-01-SUMMARY.md); `convertTimezone`, `DEFAULT_CALENDAR_URLS`, `TextAreaComponent`, `DropdownComponent`, `CalendarNotesSettings`, `Property`, `MemoChronSettings`, `TFile`, `Notice`, `App`, `DropdownComponent`, `DateElements`, `CalendarEvent` imports removed; `controls` and `title` locals inlined |
+| 4 | The Phase-5 ESLint overrides for `no-console`, `no-explicit-any`, `no-unused-vars`, `no-case-declarations`, and `no-useless-escape` are removed; `npm run lint` passes against a clean configuration with no per-rule or per-file disables tied to scorecard findings | ✓ VERIFIED | `grep -c "// Phase 8" eslint.config.mjs` returns 0; `grep -c '"no-console": "off"' eslint.config.mjs` returns 0; `grep -c "no-case-declarations" eslint.config.mjs` returns 0; `grep -c "no-useless-escape" eslint.config.mjs` returns 0; `npm run lint` exits 0 clean. D-08-extension (`no-unsafe-*` off) is present — it is NOT tied to a scorecard finding and is documented as a companion to the existing `**/*.d.ts` exclusion (same root: ical.js untyped APIs, FRAG-02 deferred) |
+| 5 | `CLAUDE.md` and `.planning/codebase/CONVENTIONS.md` carry a "Directory Compliance" do/don't section with one short rule per scorecard finding, each with rationale and a docs URL | ✓ VERIFIED | CONVENTIONS.md has `## Directory Compliance` (1 hit), 4 cluster sub-sections (DOM API, Lifecycle & Compatibility, Type Hygiene, Release & Docs), 16 rule blocks each with `**Don't:**`/`**Do:**`/`**Why:**`/`**Docs:**` format, and `### Verifying compliance` bash snippet; CLAUDE.md has `## Directory Compliance` pointer section linking to `CONVENTIONS.md#directory-compliance`; stale TODO block gone |
+| 6 | Milestone-level: a fresh Obsidian community-plugin Review scorecard run shows zero remaining "Avoid ..." findings from the v1.13.1 report | ? UNCERTAIN | Requires running the external Obsidian review tool against the live plugin build — cannot be verified programmatically from the source tree |
+
+**Score:** 5/6 truths verified
+
+### Required Artifacts
+
+| Artifact | Expected | Status | Details |
+|----------|----------|--------|---------|
+| `src/services/CalendarService.ts` | Unused `convertTimezone` import removed; catch binding converted; 10 console sites deleted; 4 gated behind DEBUG | ✓ VERIFIED | `grep -c "convertTimezone" src/services/CalendarService.ts` = 0; `grep -c "const DEBUG = false"` = 1; `grep -cE 'if \(DEBUG\) console\.' = 4`; `grep -rnE '^\s*console\.'` = 0 |
+| `src/services/IcsImportService.ts` | Unused `Property` import removed; 2 console sites deleted | ✓ VERIFIED | `Property` import absent; no bare console lines |
+| `src/settings/SettingsTab.ts` | `TextAreaComponent`, `DropdownComponent`, `CalendarNotesSettings` imports removed; catch binding converted; 2 console sites deleted; `generatePreviewPath` uses `Pick<CalendarEvent>` | ✓ VERIFIED | All removed; `grep -n "Pick<CalendarEvent" SettingsTab.ts` returns line 1183 |
+| `src/settings/types.ts` | `DEFAULT_CALENDAR_URLS` import removed | ✓ VERIFIED | `grep -rn "DEFAULT_CALENDAR_URLS" src/` returns 0 |
+| `src/utils/constants.ts` | `DEFAULT_CALENDAR_URLS` export removed (adjacent cleanup) | ✓ VERIFIED | Confirmed by 08-01-SUMMARY.md deviation note; `grep -rn "DEFAULT_CALENDAR_URLS" src/` = 0 |
+| `src/utils/viewRenderers.ts` | 4 unused imports removed; regex `[-\/]` fixed to `[-/]` | ✓ VERIFIED | `MemoChronSettings`, `TFile`, `Notice`, `App` absent; `[-/]` at line 370 |
+| `src/views/CalendarView.ts` | 4 unused symbols removed; `(window as any).moment` casts replaced; 6 console sites deleted | ✓ VERIFIED | `DropdownComponent`, `DateElements`, `controls`, `title` all absent; `moment` imported from `"obsidian"`; no bare console lines; no `if (!moment)` branches |
+| `src/views/EmbeddedCalendarView.ts` | `CalendarEvent` import removed; `title` local inlined; cast replaced; 1 console site deleted | ✓ VERIFIED | `grep -c "CalendarEvent" EmbeddedCalendarView.ts` = 0; `moment` from obsidian; no console |
+| `src/views/EmbeddedAgendaView.ts` | `(window as any).moment` cast replaced; 1 console site deleted | ✓ VERIFIED | `moment` from obsidian; no bare console |
+| `src/services/NoteService.ts` | 6 console sites deleted | ✓ VERIFIED | `grep -cE '^\s*console\.' NoteService.ts` = 0 |
+| `src/main.ts` | 2 console sites deleted | ✓ VERIFIED | `grep -cE '^\s*console\.' main.ts` = 0 |
+| `src/utils/timezoneUtils.ts` | 3 console sites deleted; 2 gated behind DEBUG | ✓ VERIFIED | `const DEBUG = false` present; `grep -cE 'if \(DEBUG\) console\.'` = 2; no bare console lines |
+| `src/utils/pathUtils.ts` | `case PathType.FILE_URL` body wrapped in block scope | ✓ VERIFIED | `case PathType.FILE_URL: {` present at line 47 |
+| `src/types/ical.d.ts` | `getValues()` return tightened; `jCal: unknown[]` added | ✓ VERIFIED | `getValues(): Array<Time | Duration | string>` at line 14; `jCal: unknown[]` at line 15 |
+| `eslint.config.mjs` | Phase-8 override block deleted; D-08-extension block added; `**/*.d.ts` exclusion preserved | ✓ VERIFIED | `grep -c "// Phase 8"` = 0; `grep -c "D-08-extension"` = 1; `grep -c '"**/*.d.ts"'` = 1; `grep -c "globalIgnores"` = 2; `npm run lint` exits 0 |
+| `.planning/codebase/CONVENTIONS.md` | `## Directory Compliance` section with 4 clusters, 16 rule blocks, verification snippet | ✓ VERIFIED | 1 `## Directory Compliance` heading; 4 `###` cluster headings; 16 `**Don't:**` blocks = 16 `**Do:**` = 16 `**Why:**` = 16 `**Docs:**`; `### Verifying compliance` present |
+| `CLAUDE.md` | TODO block replaced with Directory Compliance pointer; Memory Reminders and Beta Release Strategy preserved | ✓ VERIFIED | `## Directory Compliance` = 1; `### Beta Release Strategy` = 1; `### Memory Reminders` = 1; `CONVENTIONS.md#directory-compliance` link present; `High Priority Issues` = 0 |
+
+### Key Link Verification
+
+| From | To | Via | Status | Details |
+|------|----|-----|--------|---------|
+| `src/views/CalendarView.ts` | `obsidian` module moment export | `import { moment } from "obsidian"` | ✓ WIRED | Line 1 imports `moment` from obsidian; all 3 cast sites removed; no `if (!moment)` or `if (moment)` branches remain |
+| `src/views/EmbeddedCalendarView.ts` | `obsidian` module moment export | `import { moment } from "obsidian"` | ✓ WIRED | Line 1 imports moment from obsidian; cast site removed |
+| `src/views/EmbeddedAgendaView.ts` | `obsidian` module moment export | `import { moment } from "obsidian"` | ✓ WIRED | Line 1 imports moment from obsidian; cast site removed |
+| `src/settings/SettingsTab.ts:1183` | `src/services/CalendarService.ts CalendarEvent` | `Pick<CalendarEvent, "title" | "start" | "end" | "source">` | ✓ WIRED | Confirmed by grep at line 1183 |
+| `src/services/CalendarService.ts:317` | canonical `isValidCache` type guard | `cache: unknown` + `Record<string, unknown>` narrowing | ✓ WIRED | `cache as Record<string, unknown>` at line 319 |
+| `eslint.config.mjs` | all `src/**/*.ts` files | Phase-5 tightening + D-08 `.d.ts` exclusion + D-08-extension `no-unsafe-*` off + globalIgnores | ✓ WIRED | `npm run lint` exits 0 with no errors; clean config with no Phase-8 markers |
+| `CLAUDE.md ## Directory Compliance` | `.planning/codebase/CONVENTIONS.md#directory-compliance` | markdown link | ✓ WIRED | `grep -c 'CONVENTIONS.md#directory-compliance' CLAUDE.md` = 1 |
+
+### Data-Flow Trace (Level 4)
+
+Not applicable — Phase 8 is a code-hygiene and documentation phase. No new components rendering dynamic data were introduced. All artifacts are source file refactors or documentation additions.
+
+### Behavioral Spot-Checks
+
+| Behavior | Command | Result | Status |
+|----------|---------|--------|--------|
+| `npm run lint` exits 0 with zero errors and zero warnings | `npm run lint` | Exit 0, no output | ✓ PASS |
+| `npm run build` exits 0 | `npm run build` | Exit 0; tsc + esbuild production clean | ✓ PASS |
+| No bare `console.*` in src/ | `grep -rnE '^\s*console\.' src/` | Exit 1 (no matches found) | ✓ PASS |
+| DEBUG-gated forensic sites only in CalendarService + timezoneUtils | `grep -rcE 'if \(DEBUG\) console\.' src/` | CalendarService: 4, timezoneUtils: 2, all others: 0 | ✓ PASS |
+| No `(window as any).moment` in src/ | `grep -rn "(window as any)" src/` | 0 matches | ✓ PASS |
+| Phase-8 override marker gone from eslint.config.mjs | `grep -c "// Phase 8" eslint.config.mjs` | 0 | ✓ PASS |
+| D-08-extension block present | `grep -c "D-08-extension" eslint.config.mjs` | 1 | ✓ PASS |
+
+### Probe Execution
+
+No conventional probe scripts (`scripts/*/tests/probe-*.sh`) exist for this project. Phase 8 is a pure code-hygiene phase — the lint/build checks above serve as the functional probes.
+
+### Requirements Coverage
+
+| Requirement | Source Plan | Description | Status | Evidence |
+|-------------|------------|-------------|--------|---------|
+| DIR-01 | 08-03-PLAN, 08-04-PLAN | No `console.*` calls in shipped code; audit complete; remaining sites gated behind debug flag | ✓ SATISFIED | 33 sites deleted, 6 gated; `grep -rnE '^\s*console\.'` = 0; `npm run lint` exits 0 |
+| DIR-09 | 08-02-PLAN, 08-04-PLAN | No `any` in shipped `.ts` sources; `??` with constant LHS; no lexical decls in `case`; no useless escapes | ✓ SATISFIED | 16 `any` sites closed; `no-case-declarations` fixed; `no-useless-escape` fixed; `??` audit clean; lint exits 0 |
+| DIR-10 | 08-01-PLAN, 08-04-PLAN | Zero `no-unused-vars` violations; all 21 scorecard-named symbols deleted or consumed | ✓ SATISFIED | All 18 violation-sites removed per plan; lint exits 0 |
+| DOC-02 | 08-05-PLAN | `CLAUDE.md` and `CONVENTIONS.md` carry "Directory Compliance" do/don't section | ✓ SATISFIED | CONVENTIONS.md has 16 rule blocks in 4 clusters; CLAUDE.md has pointer section; stale TODO block gone |
+
+### Anti-Patterns Found
+
+| File | Line | Pattern | Severity | Impact |
+|------|------|---------|----------|--------|
+| None found | — | — | — | Phase 8 is a deletion/hygiene phase; no new stubs or debt markers introduced. All modified files pass lint. No `TBD`, `FIXME`, `XXX` markers found in `src/`. The only `eslint-disable-next-line` comments remaining in `src/` are pre-existing `obsidianmd/ui/sentence-case` suppressions for proper nouns and acronyms in SettingsTab.ts — these are unrelated to Phase 8 findings and were already in place before Phase 8 began. |
+
+### Human Verification Required
+
+### 1. Fresh Obsidian Scorecard Run (Success Criterion 6)
+
+**Test:** Run the Obsidian community-plugin Review scorecard against the current main-branch snapshot of the plugin (v1.15 build). The scorecard is the external evaluation tool referenced in REQUIREMENTS.md and the Phase 8 success criteria.
+**Expected:** Zero remaining "Avoid ..." findings from the v1.13.1 report (DIR-01 through DIR-12 all green, since Phases 5-8 collectively closed every finding).
+**Why human:** The Obsidian community-plugin scorecard is an external tool that must be run by a human with access to Obsidian and the plugin in an installed state. It evaluates the built plugin artifact (`main.js` + `manifest.json` + `styles.css`), not the source tree. Programmatic grep/lint checks verify source-level compliance; the scorecard confirms the directory's own review criteria pass. Note: Phases 6 and 7 closed DIR-02 through DIR-08; Phase 5 closed DIR-11 and DIR-12. The scorecard run validates the full milestone, not just Phase 8.
+
+---
+
+## Gaps Summary
+
+No gaps blocking the Phase 8 goal. All 5 directly-verifiable success criteria are satisfied:
+
+1. Console logging: 33 sites deleted, 6 forensic sites gated behind `const DEBUG = false` — zero bare `console.*` in shipped code.
+2. TypeScript hygiene: 16 `any` sites closed, `no-case-declarations` fixed, `no-useless-escape` fixed, `??` audit clean.
+3. Unused vars: 18 violation sites eliminated across 8 files; `npm run lint` exits 0.
+4. ESLint config clean: Phase-8 override block deleted; `npm run lint` passes with only legitimate permanent overrides (Phase-5 tightening, D-08 `.d.ts` exclusion, D-08-extension `no-unsafe-*` for ical.js cascade).
+5. Conventions document: CONVENTIONS.md has 16 rule blocks across 4 clusters; CLAUDE.md pointer section in place.
+
+Success Criterion 6 (milestone-level fresh scorecard run) requires human action — it cannot be verified from the source tree. The phase goal is achieved at the code level; only the external validation step is outstanding.
+
+**Notes on D-08-extension:** The `src/**/*.ts no-unsafe-*: off` override block in `eslint.config.mjs` is a documented exception, not a scorecard-finding suppressor. It addresses the typed-linting cascade from ical.js's fundamentally-untyped APIs — the same root cause as the already-present `**/*.d.ts no-explicit-any: off` exclusion. It is explicitly NOT tied to any DIR-NN scorecard finding. The Rule-4 escalation that surfaced it (documented in 08-04-CHECKPOINT.md) and the user's selection of Option B are preserved as planning artifacts.
+
+---
+
+_Verified: 2026-05-17T14:00:00Z_
+_Verifier: Claude (gsd-verifier)_