obsidian-plugin/gapmiss_substack-clipper
1
0
Fork 0
mirror of https://github.com/gapmiss/substack-clipper.git synced 2026-07-22 07:48:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: replace DOMParser createElement with regex to resolve prefer-create-el false positive

Browse source
This commit is contained in:
@gapmiss 2026-07-18 16:22:19 -05:00
parent 5070666786
commit 7a885e6aa7
2 changed files with 9 additions and 29 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
eslint.config.mjs
View file

@ -11,13 +11,6 @@ export default [
})),
// Obsidian plugin rules (v0.3.0+)
...obsidianmd.configs.recommended,
// converter.ts uses DOMParser documents, not Obsidian DOM
{
files: ["src/converter.ts"],
rules: {
"obsidianmd/prefer-create-el": "off",
},
},
// Project-specific config
{
files: ["src/**/*.ts"],

31
src/converter.ts
View file

@ -9,29 +9,16 @@ function isSubstackImageUrl(url: string): boolean {
const VIDEO_PLACEHOLDER_RE = /VIDEOEMBED([a-f0-9-]{36})ENDVIDEO/g;
function replaceVideoDivs(html: string, downloadedUrls: Set<string>): string {
const parser = new DOMParser();
const doc = parser.parseFromString(html, 'text/html');
for (const div of Array.from(doc.querySelectorAll('div[id^="media-"]'))) {
const id = div.getAttribute('id') ?? '';
if (id.length !== 42) continue;
const videoId = id.replace('media-', '');
const videoUrl = `https://substack.com/api/v1/video/upload/${videoId}/src`;
// eslint-disable-next-line obsidianmd/prefer-create-el -- DOMParser document, not Obsidian DOM
const p = doc.createElement('p');
if (downloadedUrls.has(videoUrl)) {
p.textContent = `VIDEOEMBED${videoId}ENDVIDEO`;
} else {
// eslint-disable-next-line obsidianmd/prefer-create-el -- DOMParser document, not Obsidian DOM
const a = doc.createElement('a');
a.href = videoUrl;
a.textContent = 'Video';
p.appendChild(a);
return html.replace(
/<div[^>]+id="media-([^"]{36})"[^>]*>[\s\S]*?<\/div>/g,
(_match, videoId: string) => {
const videoUrl = `https://substack.com/api/v1/video/upload/${videoId}/src`;
if (downloadedUrls.has(videoUrl)) {
return `<p>VIDEOEMBED${videoId}ENDVIDEO</p>`;
}
return `<p><a href="${videoUrl}">Video</a></p>`;
}
div.replaceWith(p);
}
return doc.body.innerHTML;
);
}
function restoreVideoWikilinks(md: string): string {