obsidian-plugin/h-sphere_sql-seal
1
0
Fork 0
mirror of https://github.com/h-sphere/sql-seal.git synced 2026-07-22 10:10:28 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: fixing parsing with SELECT keywords outside sql queries

Browse source
This commit is contained in:
Kacper Kula 2026-03-29 11:13:16 +01:00
parent a2021a98eb
commit 0df95981a2
2 changed files with 58 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

57
src/modules/editor/parser.test.ts
View file

@ -450,4 +450,61 @@ SELECT id, value FROM data`, DEFAULT_VIEWS, DEFAULTS)).toEqual({
}]
})
})
it('should not treat "select" as SQL keyword when it appears as a quoted config property key', () => {
// Test case for fix: quoted string "select" as a property key should not break the parser
expect(parseWithDefaults(`
GRID {
"select": 4
}
SELECT * FROM files`, DEFAULT_VIEWS, DEFAULTS)).toEqual({
flags: { explain: false, refresh: true },
query: 'SELECT * FROM files',
renderer: {
type: 'GRID',
options: `{
"select": 4
}`,
},
tables: []
})
})
it('should not treat "select" as SQL keyword when it appears as an unquoted config property key', () => {
// Bonus test: unquoted property key with colon immediately following
expect(parseWithDefaults(`
GRID {
select: 4
}
SELECT * FROM files`, DEFAULT_VIEWS, DEFAULTS)).toEqual({
flags: { explain: false, refresh: true },
query: 'SELECT * FROM files',
renderer: {
type: 'GRID',
options: `{
select: 4
}`,
},
tables: []
})
})
it('should handle "select" as property key with space before colon', () => {
// Edge case: space between quoted key and colon
expect(parseWithDefaults(`
GRID {
"select" : 4
}
SELECT * FROM files`, DEFAULT_VIEWS, DEFAULTS)).toEqual({
flags: { explain: false, refresh: true },
query: 'SELECT * FROM files',
renderer: {
type: 'GRID',
options: `{
"select" : 4
}`,
},
tables: []
})
})
})

2
src/modules/editor/parser.ts
View file

@ -53,7 +53,7 @@ export const SQLSealLangDefinition = (views: ViewDefinition[], flags: readonly F
anyObject = "{" (~selectKeyword any)*
handlebarsTemplate = (~selectKeyword any)*
javascriptTemplate = (~selectKeyword any)*
selectKeyword = (caseInsensitive<"WITH"> | caseInsensitive<"SELECT">) ~(alnum | "_")
selectKeyword = (caseInsensitive<"WITH"> | caseInsensitive<"SELECT">) &(space | nl | end)
tableKeyword = caseInsensitive<"TABLE">
nl = "\n"
character = (alnum | "." | "-" | space | "_")