Commit graph

5 commits

Author SHA1 Message Date
Claude
1f4aa8a6da
Fix Obsidian plugin review lint errors and warnings
- Replace document.createElement with createDiv/createSpan/createFragment (Obsidian globals)
- Replace document with activeDocument throughout for popout window compatibility
- Replace setTimeout with activeWindow.setTimeout in ReferenceSidebarView
- Replace inline style.top/style.left with setCssProps + CSS custom properties in ReferencePopover
- Add CSS variables --ref-popover-top/left to styles.css for dynamic popover positioning
- Fix while-loop assignment pattern in ReferenceParser (no-cond-assign)
- Add @codemirror/view and @codemirror/state to dependencies
- Remove unused builtin-modules dev dependency

https://claude.ai/code/session_01NwoSBvufhvXrvTcTenDfGE
2026-05-20 08:01:07 +00:00
Mark Bloomfield
1e6737fc62 Address automated plugin review feedback
- Replace fetch with requestUrl (Obsidian API requirement)
- Remove CSS style injection; Obsidian loads styles.css automatically
- Remove console.log; use only warn/error/debug
- Mark all unhandled promises with void operator
- Remove unnecessary async keywords from methods without await
- Fix rightSplit type cast (any → proper union type)
- Fix querySelector type assertions to use generic form
- Move remaining inline styles to CSS
- Fix sentence case in UI text (Modal dialog, View on wol.jw.org)
- Fix while-loop assignment expression lint warning

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-03-26 14:35:56 +02:00
Mark Bloomfield
045021e6bd implement obsidian guidelines 2026-03-26 13:26:42 +02:00
Mark Bloomfield
434ee84573 wol verse styles + sidebar cache 2026-03-26 11:59:43 +02:00
Mark Bloomfield
db1f9eee38 reference popover 2026-03-26 10:50:58 +02:00