code review 2b - reorg, version 1.1

This commit is contained in:
idanlib 2025-08-03 01:12:48 +03:00
parent 4a297bc369
commit 198807bfbc
4 changed files with 5 additions and 304 deletions

View file

@ -1,300 +0,0 @@
// import { getLinkpath, Plugin, Notice, TFolder, TFile } from "obsidian";
// import RedirectSettingsTab from "components/Settings";
// interface RedirectSettings {
// openInNewTab: boolean;
// switchToNewTab: boolean;
// }
// const DEFAULT_SETTINGS: RedirectSettings = {
// openInNewTab: false,
// switchToNewTab: false,
// };
// export default class RedirectPlugin extends Plugin {
// settings: RedirectSettings;
// redirectsFolder: TFolder | null = null;
// isMovingNote = false;
// isBypassRedirect = false;
// private async createRedirectsFolder(): Promise<void> {
// try {
// this.redirectsFolder = await this.app.vault.createFolder(
// "/_forwards"
// );
// } catch (error) {
// console.warn(
// "`_forwards` folder not created or already exists.",
// error
// );
// }
// }
// private async getCurrentFile(): Promise<{
// currentFile: TFile;
// content: string;
// } | null> {
// const currentFile = this.app.workspace.getActiveFile();
// if (!currentFile) {
// return null;
// }
// return {
// currentFile: currentFile,
// content: (await this.getCurrentFileContent(currentFile)) || "",
// };
// }
// private getTargetFile(currentFileContent: string): TFile | null {
// const linkTextRegex = /::>\[\[(.*?)\]\]/i;
// const targetNoteName = currentFileContent.match(linkTextRegex)?.at(1);
// if (!targetNoteName) {
// return null;
// }
// const targetNoteFile = this.app.metadataCache.getFirstLinkpathDest(
// getLinkpath(targetNoteName),
// ""
// );
// if (!targetNoteFile) {
// new Notice(
// "Target note not found. Create one and try again.",
// 3500
// );
// console.error(
// `No target note file found for target: ${targetNoteName}. You can create one manually and try again.`
// );
// return null;
// }
// return targetNoteFile;
// }
// private async redirect(): Promise<void> {
// // 1. Get the current file content
// const fileAndContent = await this.getCurrentFile();
// if (!fileAndContent) return;
// const { currentFile, content } = fileAndContent;
// // 2. Checks if this is a redirecting note and get the target file
// const targetNoteFile = this.getTargetFile(content);
// if (!targetNoteFile) return;
// // 3. If the redirecting file is not in the _forwards folder, move it there
// // if (currentFile.path !== `_forwards/${currentFile.name}`) {
// // new Notice(
// // `Moving ${currentFile.name} to the _forwards folder.`,
// // 2000
// // );
// // await this.moveRedirectNote(currentFile);
// // }
// await this.moveRedirectNote(currentFile);
// // 4. Open the target note
// await this.openTargetNote(targetNoteFile);
// // await this.app.workspace.openLinkText(
// // targetNoteFile.name,
// // targetNoteFile.path,
// // this.settings.openInNewTab,
// // { active: this.settings.switchToNewTab }
// // );
// }
// private async openTargetNote(targetNoteFile: TFile) {
// await this.app.workspace.openLinkText(
// targetNoteFile.name,
// targetNoteFile.path,
// this.settings.openInNewTab,
// { active: this.settings.switchToNewTab }
// );
// }
// private async getCurrentFileContent(
// currentFile: TFile
// ): Promise<string | null> {
// try {
// return await this.app.vault.read(currentFile);
// } catch (error) {
// new Notice(`Cannot read ${currentFile}.`);
// console.error(`Failed to read ${currentFile} content: `, error);
// return null;
// }
// }
// // private getTargetFile(currentFileContent: string): TFile | null {
// // const linkTextRegex = /::>\[\[(.*?)\]\]/i;
// // const targetNoteName = currentFileContent.match(linkTextRegex)?.at(1);
// // if (!targetNoteName) {
// // return null;
// // }
// // const targetNoteFile = this.app.metadataCache.getFirstLinkpathDest(
// // getLinkpath(targetNoteName),
// // ""
// // );
// // if (!targetNoteFile) {
// // new Notice(
// // "Target note not found. Create one and try again.",
// // 3500
// // );
// // console.error(
// // `No target note file found for target: ${targetNoteName}. You can create one manually and try again.`
// // );
// // return null;
// // }
// // return targetNoteFile;
// // }
// private async moveRedirectNote(
// redirectingNote: TFile | null
// ): Promise<void> {
// if (
// !redirectingNote ||
// redirectingNote.path === `_forwards/${redirectingNote.name}`
// ) {
// return;
// }
// // if (redirectingNote.path === `_forwards/${redirectingNote.name}`) {
// // return;
// // }
// new Notice(
// `Moving ${redirectingNote.name} to the _forwards folder.`,
// 2000
// );
// // If necessary, create _forwards folder
// if (!this.redirectsFolder) {
// await this.createRedirectsFolder();
// }
// try {
// this.isMovingNote = true;
// const redirectingNoteInFolder = await this.app.vault.copy(
// redirectingNote,
// `/_forwards/${redirectingNote.name}`
// );
// if (this.settings.openInNewTab) {
// await this.openTargetNote(redirectingNoteInFolder);
// // await this.app.workspace.openLinkText(
// // redirectingNoteInFolder.name,
// // redirectingNoteInFolder.path,
// // this.settings.openInNewTab,
// // {
// // active: this.settings.switchToNewTab,
// // }
// // );
// }
// // Delay deletion to avoid race condition where the original note is deleted before the new note is fully opened in the UI.
// setTimeout(async () => {
// await this.deleteNote(redirectingNote);
// this.isMovingNote = false;
// }, 500);
// } catch (error) {
// this.isMovingNote = false;
// console.error(error);
// }
// }
// private async deleteNote(orgRedirectingNote: TFile): Promise<void> {
// try {
// await this.app.fileManager.trashFile(orgRedirectingNote);
// } catch (error) {
// new Notice(
// "Failed to delete directing note from original location. Please delete manually.",
// 4500
// );
// console.error(error);
// }
// }
// handleFileOpen = async (file: TFile): Promise<void> => {
// if (this.isMovingNote) return;
// if (this.isBypassRedirect) {
// this.isBypassRedirect = false;
// return;
// }
// await this.redirect();
// };
// async changeSettings(newTab: boolean, switchToTab: boolean): Promise<void> {
// this.settings.openInNewTab = newTab;
// this.settings.switchToNewTab = switchToTab;
// await this.saveSettings();
// }
// async onload() {
// await this.loadSettings();
// this.addSettingTab(new RedirectSettingsTab(this.app, this));
// this.app.workspace.onLayoutReady(async () => {
// await this.createRedirectsFolder();
// await this.redirect();
// });
// this.app.workspace.on("file-open", this.handleFileOpen);
// this.addCommand({
// id: "paste-redirect-syntax",
// name: "Paste redirect syntax onto selection",
// editorCallback: (editor, view) => {
// const selection = editor.getSelection();
// editor.replaceSelection(`::>[[${selection}]]`);
// const { ch, line } = editor.getCursor();
// if (!selection) {
// editor.setCursor({
// ch: ch - 2,
// line: line,
// });
// }
// },
// });
// this.addCommand({
// id: "bypass-redirect",
// name: "Bypass redirect to target note",
// callback: () => {
// this.isBypassRedirect = true;
// new Notice("Bypassing redirects.");
// },
// });
// }
// onunload() {
// this.app.workspace.off("file-open", this.handleFileOpen);
// }
// async loadSettings() {
// try {
// this.settings = Object.assign(
// {},
// DEFAULT_SETTINGS,
// await this.loadData()
// );
// } catch (error) {
// console.error("Failed to load settings: ", error);
// }
// }
// async saveSettings() {
// try {
// await this.saveData(this.settings);
// } catch (error) {
// console.error("Failed to save settings: ", error);
// }
// }
// }

View file

@ -1,10 +1,10 @@
{
"id": "fast-forward-link",
"name": "FastForwardLink",
"version": "1.0.1",
"version": "1.1.0",
"minAppVersion": "0.15.0",
"description": "Fast-forward multiple links to a single target note. Create custom link shorthands (like `ps` > `photoshop`) to create synonyms, streamline navigation, and keep your vault organized.",
"author": "Idan Liberman",
"isDesktopOnly": false,
"fundingUrl": "https://buymeacoffee.com/idanlib"
}
}

View file

@ -1,6 +1,6 @@
{
"name": "fast-forward-link",
"version": "1.0.0",
"version": "1.1.0",
"description": "Forward multiple links to a single note with ease.",
"main": "main.js",
"scripts": {

View file

@ -1,3 +1,4 @@
{
"1.0.0": "0.15.0",
"1.1.0": "0.15.0"
}
}