From a6e9a972b25a04bb59a679ec18c7e1dc56e17118 Mon Sep 17 00:00:00 2001 From: Kevin Woo <3469532+kevinawoo@users.noreply.github.com> Date: Thu, 12 Jun 2025 00:48:02 -0700 Subject: [PATCH 1/5] fix: additional mobile toolbar space issue in 1.9.0 On iOS, the fix introduced in #158, didn't actually fix it for me. This resolves the issue for me on iOS, Obsidian v1.9.1 (207) --- src/styles/advanced-toolbar.scss | 1 + 1 file changed, 1 insertion(+) diff --git a/src/styles/advanced-toolbar.scss b/src/styles/advanced-toolbar.scss index 4363063..8aa0b81 100644 --- a/src/styles/advanced-toolbar.scss +++ b/src/styles/advanced-toolbar.scss @@ -16,6 +16,7 @@ position: sticky !important; z-index: 5; margin-bottom: var(--at-offset); + padding-bottom: 0 !important; } .mobile-toolbar-spacer { From b394ec8037bd7f99d6d82bf2ba7392851cf89d96 Mon Sep 17 00:00:00 2001 From: quorafind <951011105@qq.com> Date: Thu, 12 Jun 2025 18:22:54 +0800 Subject: [PATCH 2/5] fix: rebase issue --- package-lock.json | 4 ++++ package.json | 2 +- src/styles/advanced-toolbar.scss | 6 ++++++ 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/package-lock.json b/package-lock.json index 3644444..6bcc954 100644 --- a/package-lock.json +++ b/package-lock.json @@ -38,7 +38,11 @@ "obsidian": "latest", "tailwindcss": "^3.2.4", "tslib": "^2.4.1", +<<<<<<< HEAD "typescript": "^5.1.6" +======= + "typescript": "^4.9.5" +>>>>>>> 434cb68 (fix: issue with padding-bottom of multi-row and also issue with single row when enabling commander) } }, "node_modules/@codemirror/autocomplete": { diff --git a/package.json b/package.json index 406f87f..9f0dbba 100644 --- a/package.json +++ b/package.json @@ -41,7 +41,7 @@ "obsidian": "latest", "tailwindcss": "^3.2.4", "tslib": "^2.4.1", - "typescript": "^5.1.6" + "typescript": "^4.9.3" }, "dependencies": { "array-move": "^4.0.0", diff --git a/src/styles/advanced-toolbar.scss b/src/styles/advanced-toolbar.scss index 4363063..1f23a39 100644 --- a/src/styles/advanced-toolbar.scss +++ b/src/styles/advanced-toolbar.scss @@ -47,6 +47,7 @@ height: calc( var(--at-button-height) * var(--at-row-count) + var(--at-spacing) ) !important; + padding-bottom: 0; } .mobile-toolbar-options-list { height: calc( @@ -54,6 +55,11 @@ ) !important; } } +body:not(.AT-multirow) { + .mobile-toolbar { + position: absolute !important; + } +} .AT-no-toolbar { .mobile-toolbar { display: none; From 2f5b75df08672be4b0c115d6f9a16b505b55874b Mon Sep 17 00:00:00 2001 From: quorafind <951011105@qq.com> Date: Thu, 12 Jun 2025 18:26:59 +0800 Subject: [PATCH 3/5] revert: back to typescript 4.9.3 to prevent issue with preact --- package-lock.json | 20 ++++++++------------ 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/package-lock.json b/package-lock.json index 6bcc954..1de7f4a 100644 --- a/package-lock.json +++ b/package-lock.json @@ -38,11 +38,7 @@ "obsidian": "latest", "tailwindcss": "^3.2.4", "tslib": "^2.4.1", -<<<<<<< HEAD - "typescript": "^5.1.6" -======= - "typescript": "^4.9.5" ->>>>>>> 434cb68 (fix: issue with padding-bottom of multi-row and also issue with single row when enabling commander) + "typescript": "^4.9.3" } }, "node_modules/@codemirror/autocomplete": { @@ -3982,16 +3978,16 @@ } }, "node_modules/typescript": { - "version": "5.8.3", - "resolved": "https://registry.npmjs.org/typescript/-/typescript-5.8.3.tgz", - "integrity": "sha512-p1diW6TqL9L07nNxvRMM7hMMw4c5XOo/1ibL4aAIGmSAt9slTE1Xgw5KWuof2uTOvCg9BY7ZRi+GaF+7sfgPeQ==", + "version": "4.9.5", + "resolved": "https://registry.npmjs.org/typescript/-/typescript-4.9.5.tgz", + "integrity": "sha512-1FXk9E2Hm+QzZQ7z+McJiHL4NW1F2EzMu9Nq9i3zAaGqibafqYwCVU6WyWAuyQRRzOlxou8xZSyXLEN8oKj24g==", "dev": true, "bin": { "tsc": "bin/tsc", "tsserver": "bin/tsserver" }, "engines": { - "node": ">=14.17" + "node": ">=4.2.0" } }, "node_modules/unbox-primitive": { @@ -6945,9 +6941,9 @@ "peer": true }, "typescript": { - "version": "5.8.3", - "resolved": "https://registry.npmjs.org/typescript/-/typescript-5.8.3.tgz", - "integrity": "sha512-p1diW6TqL9L07nNxvRMM7hMMw4c5XOo/1ibL4aAIGmSAt9slTE1Xgw5KWuof2uTOvCg9BY7ZRi+GaF+7sfgPeQ==", + "version": "4.9.5", + "resolved": "https://registry.npmjs.org/typescript/-/typescript-4.9.5.tgz", + "integrity": "sha512-1FXk9E2Hm+QzZQ7z+McJiHL4NW1F2EzMu9Nq9i3zAaGqibafqYwCVU6WyWAuyQRRzOlxou8xZSyXLEN8oKj24g==", "dev": true }, "unbox-primitive": { From e5904608ed4aeae1269a1976513d16263068086b Mon Sep 17 00:00:00 2001 From: quorafind <951011105@qq.com> Date: Thu, 12 Jun 2025 18:51:25 +0800 Subject: [PATCH 4/5] revert: seems like set the padding-bottom to be zero should fix the issue that huge spacing of toolbar --- src/styles/advanced-toolbar.scss | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/styles/advanced-toolbar.scss b/src/styles/advanced-toolbar.scss index 1f23a39..f0b9fe4 100644 --- a/src/styles/advanced-toolbar.scss +++ b/src/styles/advanced-toolbar.scss @@ -55,11 +55,6 @@ ) !important; } } -body:not(.AT-multirow) { - .mobile-toolbar { - position: absolute !important; - } -} .AT-no-toolbar { .mobile-toolbar { display: none; From 119ccead086f77be7005a0f1caa845cb149ed0a7 Mon Sep 17 00:00:00 2001 From: quorafind <951011105@qq.com> Date: Thu, 12 Jun 2025 19:15:39 +0800 Subject: [PATCH 5/5] style: revert the padding-bottom in AT-multirow --- src/styles/advanced-toolbar.scss | 1 - 1 file changed, 1 deletion(-) diff --git a/src/styles/advanced-toolbar.scss b/src/styles/advanced-toolbar.scss index c2b2c28..8aa0b81 100644 --- a/src/styles/advanced-toolbar.scss +++ b/src/styles/advanced-toolbar.scss @@ -48,7 +48,6 @@ height: calc( var(--at-button-height) * var(--at-row-count) + var(--at-spacing) ) !important; - padding-bottom: 0; } .mobile-toolbar-options-list { height: calc(