From 93d1879affbd569b2b2647b6188233071653804f Mon Sep 17 00:00:00 2001 From: johnny1093 <46250921+jsmorabito@users.noreply.github.com> Date: Sat, 11 Jul 2026 10:39:03 -0400 Subject: [PATCH] fix: scope disabled-state CSS to also cover the native extra-setting-button The is-disabled CSS I added only targeted .cmdr-slider .clickable-icon, which is the wrapper class used by the custom Preact SliderComponent (General tab). The Advanced Toolbar tab's three sliders go through Obsidian's native Setting/ExtraButtonComponent API instead, which renders the reset icon as a plain .extra-setting-button - a different element entirely, not covered by that selector. Added a matching rule scoped to a new cmdr-advanced-toolbar-settings wrapper class on that tab's container. --- src/styles/styles.scss | 6 ++++++ src/ui/components/AdvancedToolbarSettings.tsx | 6 +++++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/src/styles/styles.scss b/src/styles/styles.scss index c3ba4a5..d5f5432 100644 --- a/src/styles/styles.scss +++ b/src/styles/styles.scss @@ -55,6 +55,12 @@ pointer-events: none; } +.cmdr-advanced-toolbar-settings .extra-setting-button.is-disabled { + opacity: 0.35; + cursor: default; + pointer-events: none; +} + .cmdr-menu-more-options { color: var(--text-muted); position: absolute; diff --git a/src/ui/components/AdvancedToolbarSettings.tsx b/src/ui/components/AdvancedToolbarSettings.tsx index b1fc17a..2dd6f39 100644 --- a/src/ui/components/AdvancedToolbarSettings.tsx +++ b/src/ui/components/AdvancedToolbarSettings.tsx @@ -297,7 +297,11 @@ export default function AdvancedToolbarSettings({ )} -
+
); }