mirror of
https://github.com/jsmorabito/obsidian-commander.git
synced 2026-07-22 06:40:31 +00:00
No description
CommandViewer, MacroViewer, and MobileModifyComponent are all plain function components (not classes), so `this` inside their handlers is undefined - this.forceUpdate() has never been able to succeed since the plugin's first release, it just throws before Preact ever gets a chance to visually update in place. The actual state mutation and settings.save() on each of these handlers already happens before the throwing line, so removing it doesn't change what the UI shows; it removes a guaranteed, silently-swallowed error on every add/ remove/reorder/rename/recolor action. Also drops mobileModifyComponent's cmdr-icon-changed listener, whose only job was calling the broken forceUpdate. Given this changes real code paths, worth a manual pass: add/remove/ reorder/rename commands and macros from the settings tab, and check the mobile icon-picker modal, to confirm nothing regresses now that the throw is gone. |
||
|---|---|---|
| .github | ||
| locale | ||
| scripts | ||
| src | ||
| .editorconfig | ||
| .gitignore | ||
| .npmrc | ||
| AGENTS.md | ||
| app.css | ||
| eslint.config.mts | ||
| LICENSE.md | ||
| manifest.json | ||
| package-lock.json | ||
| package.json | ||
| README.md | ||
| tailwind.config.js | ||
| tsconfig.json | ||
| versions.json | ||
| vitest.config.ts | ||
Commander is a plugin for Obsidian which allows you to add commands to different parts of the user interface.
Features
- add commands
- remove commands
- re order commands (via plugin settings menu)
- edit commands
- hide commands added by Obsidian or other plugins
- choose which devices commands appear on (for sync users)
Demo
How you can improve this Plugin
Feedback
Share feedback, issues, and ideas on Github, with our Commander feedback form, or tag the authors on Discord!
Adding translations
If you want to help and translate this Plugin to new languages, see locale/. Copy the English (en.json) File to your language file and start changing the sentences on the right.
Credits
- This plugin is being designed by Johnny ✨ and developed by phibr0
- Thank you to Kometenstaub and kzhovn for giving us permission to use the code from their plugins Customizable Page Header and Titlebar and Customizable Menu
- All designs for Commander were created using Penpot
