Fix #22 - missing certain callout icons
This commit is contained in:
Alan Grainger 2023-10-16 20:18:27 +02:00
commit b08558b33d
5 changed files with 9 additions and 7 deletions

View file

@ -1,7 +1,7 @@
{
"id": "share-note",
"name": "Share Note",
"version": "0.5.21",
"version": "0.5.22",
"minAppVersion": "0.15.0",
"description": "Instantly share a note, with the full theme and content exactly like you see in Reading View. Data is shared encrypted by default, and only you and the person you send it to have the key.",
"author": "Alan Grainger",

4
package-lock.json generated
View file

@ -1,12 +1,12 @@
{
"name": "share-note",
"version": "0.5.14",
"version": "0.5.22",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "share-note",
"version": "0.5.14",
"version": "0.5.22",
"license": "MIT",
"dependencies": {
"data-uri-to-buffer": "^6.0.1"

View file

@ -1,6 +1,6 @@
{
"name": "share-note",
"version": "0.5.21",
"version": "0.5.22",
"description": "Instantly share a note, with the full theme and content exactly like you see in Reading View. Data is shared encrypted by default, and only you and the person you send it to have the key.",
"main": "main.js",
"scripts": {

View file

@ -119,14 +119,15 @@ export default class Note {
// Get the callout icon from the CSS. I couldn't find any way to do this from the DOM,
// as the elements may be far down below the fold and are not populated.
const type = el.getAttribute('data-callout')
const icon = this.getCalloutIcon(selectorText => selectorText.includes(`data-callout="${type}"`)) || defaultCalloutType
let icon = this.getCalloutIcon(selectorText => selectorText.includes(`data-callout="${type}"`)) || defaultCalloutType
icon = icon.replace('lucide-', '')
// Replace the existing icon so we:
// a) don't get double-ups, and
// b) have a consistent style
const iconEl = el.querySelector('div.callout-icon')
const svgEl = iconEl?.querySelector('svg')
if (svgEl) {
svgEl.outerHTML = `<svg width="16" height="16" data-share-note-lucide="${icon.slice(7)}"></svg>`
svgEl.outerHTML = `<svg width="16" height="16" data-share-note-lucide="${icon}"></svg>`
}
}

View file

@ -20,5 +20,6 @@
"0.5.18": "0.15.0",
"0.5.19": "0.15.0",
"0.5.20": "0.15.0",
"0.5.21": "0.15.0"
"0.5.21": "0.15.0",
"0.5.22": "0.15.0"
}