From af3c3c05da0209460ffddb986ad76e3bcc509174 Mon Sep 17 00:00:00 2001 From: kotaindah55 Date: Thu, 20 Mar 2025 20:54:16 +0200 Subject: [PATCH] perf: empty containerEl on tab hide instead on display beginning Thus, it ensure there is no persist and remain unused element in the background. --- src/settings/interface/ExtendedSettingTab.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/settings/interface/ExtendedSettingTab.ts b/src/settings/interface/ExtendedSettingTab.ts index 973dd09..e26e666 100644 --- a/src/settings/interface/ExtendedSettingTab.ts +++ b/src/settings/interface/ExtendedSettingTab.ts @@ -41,7 +41,6 @@ export class ExtendedSettingTab extends PluginSettingTab { display(): void { let { containerEl } = this, { settings } = this.plugin; - containerEl.empty(); let settingsUIConfig = retrieveSettingUIConfigs(settings); this.drawFromConfig(settingsUIConfig, containerEl); this.isHidden = false; @@ -56,6 +55,7 @@ export class ExtendedSettingTab extends PluginSettingTab { this.refreshInternal = this.rebuildColorStyleRules = false; this.emptyTagSettingItems(); this.isHidden = true; + this.containerEl.empty(); super.hide(); } emptyTagSettingItems() {