obsidian-plugin/kwhittle_obsidian-github-tools
1
0
Fork 0
mirror of https://github.com/kwhittle/obsidian-github-tools.git synced 2026-07-22 07:44:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix second-round review issues

Browse source 
- Bump minAppVersion to 1.7.2 (revealLeaf became async at @since 1.7.2)
- Remove plugin name from settings heading (per Obsidian guidelines)
- Cast loadData() result to Partial<Settings> to fix unsafe any assignment

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
kry-kylewhittle 2026-06-13 12:09:43 +01:00
parent 0e6d173e8a
commit 766bdd6e42
2 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
main.ts
View file

@ -757,7 +757,7 @@ export default class GitHubWikiPlugin extends Plugin {
}
async loadSettings(): Promise<void> {
this.settings = Object.assign({}, DEFAULT_SETTINGS, await this.loadData());
this.settings = Object.assign({}, DEFAULT_SETTINGS, await this.loadData() as Partial<Settings>);
if (!this.settings.seenPRActivity) this.settings.seenPRActivity = {};
}
@ -1139,7 +1139,6 @@ class GitHubRepoSettingTab extends PluginSettingTab {
const { containerEl } = this;
containerEl.empty();
new Setting(containerEl).setName("GitHub Repo Tools").setHeading();
new Setting(containerEl).setName("Connection").setHeading();
new Setting(containerEl)

2
manifest.json
View file

@ -2,7 +2,7 @@
"id": "github-repo-tools",
"name": "GitHub Repo Tools",
"version": "1.0.0",
"minAppVersion": "1.1.3",
"minAppVersion": "1.7.2",
"description": "Monitor a GitHub repo — staleness alerts, PR dashboard, and activity notifications.",
"author": "Kyle Whittle",
"authorUrl": "https://github.com/kry-kylewhittle",