obsidian-plugin/lllin000_PaperForge
1
0
Fork 0
mirror of https://github.com/lllin000/PaperForge.git synced 2026-07-22 06:50:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(pr4): handle column_band=0 falsy correctly in score_legend_to_group

Browse source
This commit is contained in:
LLLin000 2026-07-04 22:34:50 +08:00
parent 5cac8d1e08
commit 17b02b8abf
2 changed files with 3 additions and 37 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
paperforge/worker/ocr_figures.py
View file

@ -1118,7 +1118,9 @@ def _score_legend_to_group(
# Skip for rotated captions (side captions sit in different column by design)
if not legend.get("_rotated_caption_prematch"):
legend_bbox = legend.get("bbox") or legend.get("block_bbox") or [0, 0, 0, 0]
group_band = group.get("column_band") or _group_column_band(group.get("media_blocks", []), page_width)
group_band = group.get("column_band")
if group_band is None:
group_band = _group_column_band(group.get("media_blocks", []), page_width)
legend_band = _column_band_id(legend_bbox, page_width)
if legend_band is not None and group_band is not None and legend_band != group_band:
return {

36
tests/test_ocr_figures.py
View file

@ -8320,42 +8320,6 @@ def test_build_figure_inventory_delegates_to_vnext(monkeypatch):
assert called["args"] == (blocks, 777, {1: []})
# ──────────────────────────────────────────────
# PR4: Column compatibility check for figure caption-asset pairing
# ──────────────────────────────────────────────
def test_column_compatible_cross_column_rejected() -> None:
from paperforge.worker.ocr_figures import _column_compatible_for_caption_asset
pw = 1200.0
left_bbox = [100, 100, 500, 200] # left column band = 0
right_bbox = [700, 100, 1100, 200] # right column band = 1
result = _column_compatible_for_caption_asset(left_bbox, right_bbox, pw)
assert result is False
def test_column_compatible_same_column() -> None:
from paperforge.worker.ocr_figures import _column_compatible_for_caption_asset
pw = 1200.0
left_bbox = [100, 100, 500, 200]
left_bbox2 = [100, 300, 500, 400]
assert _column_compatible_for_caption_asset(left_bbox, left_bbox2, pw)
def test_column_compatible_full_width() -> None:
from paperforge.worker.ocr_figures import _column_compatible_for_caption_asset
pw = 1200.0
full_bbox = [50, 100, 1150, 200] # 1100/1200 = 91.7% -> full-width
right_bbox = [700, 300, 1100, 400]
assert _column_compatible_for_caption_asset(full_bbox, right_bbox, pw)
def test_column_compatible_center_band() -> None:
from paperforge.worker.ocr_figures import _column_compatible_for_caption_asset
pw = 1200.0
center_bbox = [200, 100, 1000, 200] # center -> None band
right_bbox = [700, 300, 1100, 400] # right -> band 1
assert _column_compatible_for_caption_asset(center_bbox, right_bbox, pw)
def test_group_column_band_composite() -> None: