From 231d020fea4245fb96b16e2bbd51c40919d76d9c Mon Sep 17 00:00:00 2001
From: Wenzheng Jiang <jwzh.hi@gmail.com>
Date: Mon, 13 Oct 2025 04:19:59 +0900
Subject: [PATCH] Turn on memory feature by default (#1914)

* Turn on memory feature by default

* Ensure default values for enableRecentConversations and enableSavedMemory settings are applied correctly
---
 src/constants.ts      |  4 ++--
 src/settings/model.ts | 10 ++++++++--
 2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/src/constants.ts b/src/constants.ts
index 34da64b1..3414f640 100644
--- a/src/constants.ts
+++ b/src/constants.ts
@@ -792,9 +792,9 @@ export const DEFAULT_SETTINGS: CopilotSettings = {
   reasoningEffort: DEFAULT_MODEL_SETTING.REASONING_EFFORT,
   verbosity: DEFAULT_MODEL_SETTING.VERBOSITY,
   memoryFolderName: DEFAULT_MEMORY_FOLDER,
-  enableRecentConversations: false,
+  enableRecentConversations: true,
   maxRecentConversations: 30,
-  enableSavedMemory: false,
+  enableSavedMemory: true,
   enableInlineCitations: true,
 };
 
diff --git a/src/settings/model.ts b/src/settings/model.ts
index b454c12b..654b1890 100644
--- a/src/settings/model.ts
+++ b/src/settings/model.ts
@@ -380,12 +380,18 @@ export function sanitizeSettings(settings: CopilotSettings): CopilotSettings {
   }
 
   // Ensure enableRecentConversations has a default value
-  if (typeof sanitizedSettings.enableRecentConversations !== "boolean") {
+  if (
+    !sanitizedSettings.enableRecentConversations ||
+    typeof sanitizedSettings.enableRecentConversations !== "boolean"
+  ) {
     sanitizedSettings.enableRecentConversations = DEFAULT_SETTINGS.enableRecentConversations;
   }
 
   // Ensure enableSavedMemory has a default value
-  if (typeof sanitizedSettings.enableSavedMemory !== "boolean") {
+  if (
+    !sanitizedSettings.enableSavedMemory ||
+    typeof sanitizedSettings.enableSavedMemory !== "boolean"
+  ) {
     sanitizedSettings.enableSavedMemory = DEFAULT_SETTINGS.enableSavedMemory;
   }