obsidian-plugin/logancyang_obsidian-copilot
1
0
Fork 0
mirror of https://github.com/logancyang/obsidian-copilot.git synced 2026-07-22 07:50:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: pass timeRange to Miyo search path (#2267) (#2269)

Browse source 
* fix: pass timeRange to Miyo search path (#2267)

When Miyo is active, localSearchTool called performMiyoSearch without
the timeRange parameter, causing time-based queries like "what did I do
this week" to ignore date filters and return wrong results.

Thread timeRange through to performMiyoSearch, FilterRetriever, and
MiyoSemanticRetriever — all of which already support it.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* chore: gitignore .claude/worktrees/

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Logan Yang 2026-03-06 17:21:27 -08:00 committed by GitHub
parent a0ba6eb0a9
commit 41e2e552dd
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 27 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
.gitignore vendored
View file

@ -27,6 +27,7 @@ data.json
# Claude configuration
.claude/settings.local.json
.claude/worktrees/
# Development session tracking
TODO.md

40
src/tools/SearchTools.ts
View file

@ -388,34 +388,41 @@ async function performMiyoSearch({
query,
salientTerms,
returnAll = false,
timeRange,
}: {
query: string;
salientTerms: string[];
returnAll?: boolean;
timeRange?: { startTime: number; endTime: number };
}) {
const tagTerms = salientTerms.filter((term) => term.startsWith("#"));
const useExpandedLimits = returnAll || tagTerms.length > 0;
const useExpandedLimits = returnAll || timeRange !== undefined || tagTerms.length > 0;
const effectiveMaxK = useExpandedLimits ? RETURN_ALL_LIMIT : DEFAULT_MAX_SOURCE_CHUNKS;
// FilterRetriever for local tag/title matches
// FilterRetriever for local tag/title/time-range matches
const filterRetriever = new FilterRetriever(app, {
salientTerms,
timeRange,
maxK: effectiveMaxK,
returnAll: useExpandedLimits,
});
const filterDocs = await filterRetriever.getRelevantDocuments(query);
// Miyo retriever for server-side semantic search (no local lexical merge)
const miyoRetriever = RetrieverFactory.createMiyoRetriever(app, {
minSimilarityScore: useExpandedLimits ? 0.0 : 0.1,
maxK: effectiveMaxK,
salientTerms,
textWeight: TEXT_WEIGHT,
returnAll: useExpandedLimits,
useRerankerThreshold: 0.5,
tagTerms,
});
const miyoDocs = await miyoRetriever.getRelevantDocuments(query);
// When timeRange is set, filter results are the complete set — skip Miyo search
// (mirrors the non-Miyo path where main retriever is skipped for time-range queries)
let miyoDocs: import("@langchain/core/documents").Document[] = [];
if (!filterRetriever.hasTimeRange()) {
const miyoRetriever = RetrieverFactory.createMiyoRetriever(app, {
minSimilarityScore: useExpandedLimits ? 0.0 : 0.1,
maxK: effectiveMaxK,
salientTerms,
textWeight: TEXT_WEIGHT,
returnAll: useExpandedLimits,
useRerankerThreshold: 0.5,
tagTerms,
});
miyoDocs = await miyoRetriever.getRelevantDocuments(query);
}
logInfo(
`miyoSearch: ${filterDocs.length} filter + ${miyoDocs.length} miyo docs for query: "${query}"`
@ -462,7 +469,12 @@ const localSearchTool = createLangChainTool({
// Miyo handles search server-side — use separate path (no local lexical search)
if (RetrieverFactory.isMiyoActive()) {
logInfo("localSearch: Using Miyo search path");
return await performMiyoSearch({ query, salientTerms, returnAll: returnAll === true });
return await performMiyoSearch({
query,
salientTerms,
returnAll: returnAll === true,
timeRange,
});
}
const tagTerms = salientTerms.filter((term) => term.startsWith("#"));