obsidian-plugin/logancyang_obsidian-copilot
1
0
Fork 0
mirror of https://github.com/logancyang/obsidian-copilot.git synced 2026-07-22 07:50:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

chore(eslint): annotate disabled type-aware rules with violation counts (#2417)

Browse source 
Group the 14 disabled @typescript-eslint rules into Heavy / Medium / Quick-win
buckets with inline violation counts measured against src/**/*.{ts,tsx}. Makes
it obvious which rules (e.g. restrict-template-expressions at 1, no-base-to-string
at 7) are cheap follow-ups vs. the no-unsafe-* family that dominates the block.

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Zero Liu 2026-05-13 01:52:09 -07:00 committed by GitHub
parent a529387533
commit f7bcac3d86
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 23 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

37
eslint.config.mjs
View file

@ -82,20 +82,29 @@ export default [
// Disabled here because the codebase intentionally uses `any` / dynamic typing
// around Obsidian's untyped APIs and LangChain message shapes — flipping these
// on would require refactoring thousands of call sites with no functional gain.
"@typescript-eslint/no-unsafe-member-access": "off",
"@typescript-eslint/no-unsafe-assignment": "off",
"@typescript-eslint/no-unsafe-call": "off",
"@typescript-eslint/no-unsafe-argument": "off",
"@typescript-eslint/no-unsafe-return": "off",
"@typescript-eslint/no-unsafe-enum-comparison": "off",
"@typescript-eslint/no-base-to-string": "off",
"@typescript-eslint/no-redundant-type-constituents": "off",
"@typescript-eslint/restrict-template-expressions": "off",
"@typescript-eslint/unbound-method": "off",
"@typescript-eslint/no-misused-promises": "off",
"@typescript-eslint/no-floating-promises": "off",
"@typescript-eslint/no-unnecessary-type-assertion": "off",
"@typescript-eslint/await-thenable": "off",
//
// Violation counts (src/**/*.{ts,tsx}) are noted inline. Rules with low counts
// are candidates to enable in small follow-up PRs.
// --- Heavy: any-flow through Obsidian/LangChain APIs ---
"@typescript-eslint/no-unsafe-member-access": "off", // 2040 violations
"@typescript-eslint/no-unsafe-assignment": "off", // 879 violations
"@typescript-eslint/no-unsafe-call": "off", // 679 violations
"@typescript-eslint/no-unsafe-argument": "off", // 368 violations
"@typescript-eslint/no-unsafe-return": "off", // 187 violations
// --- Medium: promise / method ergonomics ---
"@typescript-eslint/unbound-method": "off", // 68 violations
"@typescript-eslint/no-misused-promises": "off", // 46 violations
"@typescript-eslint/no-unnecessary-type-assertion": "off", // 40 violations
"@typescript-eslint/no-floating-promises": "off", // 39 violations
"@typescript-eslint/await-thenable": "off", // 20 violations
// --- Quick wins: small enough to fix and enable in a single PR ---
"@typescript-eslint/no-unsafe-enum-comparison": "off", // 11 violations
"@typescript-eslint/no-base-to-string": "off", // 7 violations
"@typescript-eslint/no-redundant-type-constituents": "off", // 5 violations
"@typescript-eslint/restrict-template-expressions": "off", // 1 violation
// no-deprecated: defer — surface the warnings, but don't fail CI yet
"@typescript-eslint/no-deprecated": "off",