mirror of
https://github.com/logancyang/obsidian-copilot.git
synced 2026-07-22 07:50:24 +00:00
* fix(mobile): shim `process` so the bundle survives module-eval on mobile Follow-up to #2576 (preview issue #125). After the EventEmitter fix, mobile now crashes at load with "ReferenceError: Can't find variable: process". Cause: Agent Mode is desktop-only but its modules are statically imported, so they're evaluated on every platform. Several read the Node global `process` at module scope (e.g. `InstallCommandRow.tsx`'s `const DEFAULT_LABEL = process.platform === "win32" ? ...`, the codex/claude/opencode descriptors), and bundled Node deps read `process.env` at init. Mobile's WebView has no `process`, so evaluating any of them throws during import and kills the plugin. Fix: prepend a minimal `process` shim in the esbuild banner — `var process = globalThis.process || { env:{}, platform:"", ... }`. Desktop (Electron) has a real `globalThis.process` and uses it unchanged; mobile gets the stub, so module evaluation no longer throws. The desktop-only code paths that actually use `process` never run on mobile. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * chore(test-vault): copy-deploy into iCloud-synced vaults for mobile testing `npm run test:vault` symlinks main.js/styles.css by default, but iCloud syncs file contents, not link targets, so a symlinked build never reaches the phone. Detect iCloud vaults (path under "/Mobile Documents/") and copy real files instead, so deploying to an iCloud vault makes the build testable on Obsidian mobile. Mirrors the existing WSL copy-mode rule. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(mobile): keep agent mode off load path * test(mobile): add load smoke check * fix(mobile): share agent chat mode constant --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
129 lines
4.5 KiB
Bash
Executable file
129 lines
4.5 KiB
Bash
Executable file
#!/usr/bin/env bash
|
|
set -euo pipefail
|
|
|
|
OBSIDIAN_BIN="/Applications/Obsidian.app/Contents/MacOS/obsidian"
|
|
|
|
if [[ -z "${COPILOT_TEST_VAULT_PATH:-}" ]]; then
|
|
cat >&2 <<'EOF'
|
|
error: COPILOT_TEST_VAULT_PATH is not set.
|
|
|
|
Set it once at the user level (e.g. in ~/.zshrc or ~/.config/fish/config.fish)
|
|
to the absolute path of an Obsidian vault you've opened at least once:
|
|
|
|
export COPILOT_TEST_VAULT_PATH="$HOME/Obsidian/CopilotTestVault"
|
|
|
|
Then re-run: npm run test:vault
|
|
EOF
|
|
exit 1
|
|
fi
|
|
|
|
VAULT_PATH="$COPILOT_TEST_VAULT_PATH"
|
|
|
|
if [[ ! -d "$VAULT_PATH" ]]; then
|
|
echo "error: vault directory not found: $VAULT_PATH" >&2
|
|
exit 1
|
|
fi
|
|
|
|
if [[ ! -d "$VAULT_PATH/.obsidian" ]]; then
|
|
echo "error: $VAULT_PATH has no .obsidian/ folder." >&2
|
|
echo "Open the folder as a vault in Obsidian once, then re-run." >&2
|
|
exit 1
|
|
fi
|
|
|
|
WORKTREE_ROOT="$(cd "$(dirname "$0")/.." && pwd)"
|
|
cd "$WORKTREE_ROOT"
|
|
|
|
# Guard: refuse to run if the worktree lives inside the target vault. Otherwise
|
|
# the build artifacts and source tree become vault content, Obsidian indexes
|
|
# the whole repo on the next reload, and the plugin dir may coincide with the
|
|
# worktree (deploying onto itself).
|
|
WORKTREE_REAL="$(cd "$WORKTREE_ROOT" && pwd -P)"
|
|
VAULT_REAL="$(cd "$VAULT_PATH" && pwd -P)"
|
|
case "$WORKTREE_REAL" in
|
|
"$VAULT_REAL"|"$VAULT_REAL"/*)
|
|
cat >&2 <<EOF
|
|
error: the worktree is inside the test vault — refusing to deploy.
|
|
worktree: $WORKTREE_REAL
|
|
vault: $VAULT_REAL
|
|
Move the worktree outside the vault, or point \$COPILOT_TEST_VAULT_PATH
|
|
at a different vault, then re-run.
|
|
EOF
|
|
exit 1
|
|
;;
|
|
esac
|
|
|
|
# Deployment mode: symlinks by default (macOS / native Linux). Switch to file
|
|
# copy on WSL when the vault lives on a Windows-mounted filesystem — Obsidian
|
|
# on Windows can't resolve WSL-flavored POSIX symlinks stored on DrvFs/9p.
|
|
DEPLOY_MODE="link"
|
|
if [[ "$(uname -r 2>/dev/null)" == *[Mm]icrosoft* ]] && [[ "$VAULT_REAL" == /mnt/* ]]; then
|
|
DEPLOY_MODE="copy"
|
|
fi
|
|
# iCloud-synced vaults (Obsidian on iOS/iPadOS) can't use symlinks: iCloud
|
|
# uploads file contents, not link targets, so a symlinked main.js never reaches
|
|
# the phone. Copy real files so the mobile device receives the build.
|
|
if [[ "$VAULT_REAL" == *"/Mobile Documents/"* ]]; then
|
|
DEPLOY_MODE="copy"
|
|
fi
|
|
|
|
echo "==> Installing dependencies"
|
|
npm install --prefer-offline --no-audit --no-fund
|
|
|
|
echo "==> Building plugin"
|
|
npm run build
|
|
|
|
PLUGIN_ID="$(node -p "require('./manifest.json').id")"
|
|
if [[ -z "$PLUGIN_ID" ]]; then
|
|
echo "error: could not read plugin id from manifest.json" >&2
|
|
exit 1
|
|
fi
|
|
|
|
PLUGIN_DIR="$VAULT_PATH/.obsidian/plugins/$PLUGIN_ID"
|
|
mkdir -p "$PLUGIN_DIR"
|
|
|
|
echo "==> Deploying artifacts into $PLUGIN_DIR (mode: $DEPLOY_MODE)"
|
|
for f in main.js styles.css; do
|
|
if [[ ! -f "$WORKTREE_ROOT/$f" ]]; then
|
|
echo "error: expected build artifact missing: $WORKTREE_ROOT/$f" >&2
|
|
exit 1
|
|
fi
|
|
rm -f "$PLUGIN_DIR/$f"
|
|
if [[ "$DEPLOY_MODE" == "copy" ]]; then
|
|
cp -f "$WORKTREE_ROOT/$f" "$PLUGIN_DIR/$f"
|
|
else
|
|
ln -sfn "$WORKTREE_ROOT/$f" "$PLUGIN_DIR/$f"
|
|
fi
|
|
done
|
|
|
|
# Write a branch- and timestamp-tagged manifest.json (real file, not a symlink)
|
|
# so Obsidian's Community plugins list visibly reflects which worktree/branch
|
|
# is loaded and when this build was deployed.
|
|
BRANCH="$(git -C "$WORKTREE_ROOT" rev-parse --abbrev-ref HEAD 2>/dev/null || echo unknown)"
|
|
BUILD_TS="$(date +%Y%m%d-%H%M%S)"
|
|
echo "==> Writing branch-tagged manifest.json (branch: $BRANCH, build: $BUILD_TS)"
|
|
rm -f "$PLUGIN_DIR/manifest.json"
|
|
SRC="$WORKTREE_ROOT/manifest.json" DEST="$PLUGIN_DIR/manifest.json" BRANCH="$BRANCH" BUILD_TS="$BUILD_TS" node -e '
|
|
const fs = require("fs");
|
|
const m = JSON.parse(fs.readFileSync(process.env.SRC, "utf8"));
|
|
m.name = m.name + " [" + process.env.BRANCH + " @ " + process.env.BUILD_TS + "]";
|
|
m.description = "[branch: " + process.env.BRANCH + " | build: " + process.env.BUILD_TS + "] " + m.description;
|
|
fs.writeFileSync(process.env.DEST, JSON.stringify(m, null, 2) + "\n");
|
|
'
|
|
|
|
echo "==> Reloading plugin in Obsidian"
|
|
if [[ ! -x "$OBSIDIAN_BIN" ]]; then
|
|
echo "warning: Obsidian CLI not found at $OBSIDIAN_BIN; skipping reload." >&2
|
|
else
|
|
if ! "$OBSIDIAN_BIN" plugin:enable id="$PLUGIN_ID" >/dev/null 2>&1 \
|
|
|| ! "$OBSIDIAN_BIN" plugin:reload id="$PLUGIN_ID" >/dev/null 2>&1; then
|
|
echo "warning: Obsidian doesn't appear to be running. Start it and the symlinked plugin will load on next open." >&2
|
|
fi
|
|
fi
|
|
|
|
echo
|
|
echo "Done."
|
|
echo " worktree: $WORKTREE_ROOT"
|
|
echo " branch: $BRANCH"
|
|
echo " build: $BUILD_TS"
|
|
echo " vault: $VAULT_PATH"
|
|
echo " plugin: $PLUGIN_ID"
|