obsidian-plugin/lossless-group_image-gin
1
0
Fork 0
mirror of https://github.com/lossless-group/image-gin.git synced 2026-07-22 06:49:33 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
lossless-group_image-gin/styles.css
mpstaton cfbceba299 chore(marketplace): pass ObsidianReviewBot lint cleanly — v0.2.1 
Applies all required fixes from the bot's review of PR #12524
(obsidianmd/obsidian-releases). ESLint now passes 0 errors with the
Obsidian community ruleset; tsc passes; production build is clean.
3 warnings remain (FileManager.trashFile preference — non-blocking).

Lint setup:
- Adopted eslint-plugin-obsidianmd@^0.2.9 in eslint.config.mjs
- Mirrored the bot's rule surface locally so violations surface in
  `pnpm lint` instead of the marketplace PR thread
- Configured the ui/sentence-case rule with a brand allowlist
  (Recraft, Magnific, Freepik, Ideogram, ImageKit, Imgur, Anthropic,
  Claude, OpenAI, Obsidian, WebP, JSON, YAML, URL, API, CDN)

Code fixes (263 → 0):
- console.log/info → console.debug across all sources
- UI strings normalized to sentence case (~150 sites)
- Command IDs / names: dropped "image-gin-" plugin-id prefix on the
  drop-gate reset command; renamed problematic settings heading
  ("Image cache settings" → "Image cache")
- Settings tab section headers via setHeading() instead of <h2>/<h3>
- Inline element.style.* migrated to a new CSS class set in
  src/styles/marketplace-compliance.css (~60 sites collapsed to
  ~10 reusable classes: image-gin-row, image-gin-row-tight,
  image-gin-text-area + variants, image-gin-cache-stats,
  image-gin-error-text, image-gin-error-banner, image-gin-preview,
  image-gin-thumb, image-gin-hidden)
- TFile cast → instanceof check (BatchDirectoryConvertLocalToRemote)
- require('fs')/require('path') → ES imports (allowed since
  isDesktopOnly: true)
- Hardcoded ".obsidian/plugins/image-gin/..." paths replaced with
  ${vault.configDir}/plugins/image-gin/... (logger, imageCacheService)
- Async input handlers wrapped: addEventListener('input', () => void
  (async () => { ... })()) so the listener type matches
- forEach((opt) => dd.addOption(...)) blocks made void-returning
- JSON.parse results typed as unknown then narrowed
- Logger console-method dispatch rewritten as a switch instead of
  dynamic console[level] indexing
- Replaced builtin-modules dev-dependency with node:module's
  builtinModules — same data, no extra package
- DragEventCopy/PasteEventCopy classes (which used 'instanceof' on
  user classes) replaced with sentinel-tagged factory functions
  (makeSyntheticDragEvent / isSyntheticDropEvent) so we don't trip
  the obsidianmd/prefer-instanceof rule for non-Obsidian classes

Bumps version to 0.2.1.

Plan + design rationale:
context-v/issues/Obsidian-Review-Bot-Feedback-on-Perplexed-Submission.md
context-v/reminders/Obsidian-Marketplace-Compliance.md

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-09 03:47:52 -05:00

1 line
14 KiB
CSS
Raw Blame History

.magnific-modal{width:90vw;max-width:1100px;box-sizing:border-box}.magnific-modal .modal-content{padding:1.5rem 1.75rem}.magnific-search-container{display:flex;gap:10px;margin-bottom:20px}.magnific-search-container input[type=text]{flex:1;padding:8px 12px;border:1px solid var(--background-modifier-border);border-radius:4px;background-color:var(--background-primary);color:var(--text-normal)}.magnific-search-container button{padding:8px 16px;background-color:var(--interactive-accent);color:var(--text-on-accent);border:none;border-radius:4px;cursor:pointer}.magnific-search-container button:hover{background-color:var(--interactive-accent-hover)}.magnific-grid{display:grid;grid-template-columns:repeat(auto-fill,minmax(240px,1fr));gap:18px;margin-top:20px}.magnific-image-container{display:flex;flex-direction:column;gap:10px;border:1px solid var(--background-modifier-border);border-radius:8px;padding:10px;background-color:var(--background-primary);transition:transform .18s ease,box-shadow .18s ease,border-color .18s ease;cursor:pointer;overflow:hidden}.magnific-image-container:hover{transform:translateY(-2px);box-shadow:0 6px 16px #0000002e;border-color:var(--interactive-accent)}.magnific-thumbnail{width:100%;aspect-ratio:1 / 1;object-fit:cover;border-radius:6px;background-color:var(--background-secondary);display:block}.magnific-title{margin:0;font-size:.9em;line-height:1.3;color:var(--text-normal);display:-webkit-box;-webkit-line-clamp:2;-webkit-box-orient:vertical;overflow:hidden;min-height:2.4em}.magnific-select-button{margin-top:auto;padding:6px 12px;background-color:var(--interactive-accent);color:var(--text-on-accent);border:none;border-radius:4px;cursor:pointer;font-size:.85em;align-self:flex-start}.magnific-select-button:hover{background-color:var(--interactive-accent-hover)}.magnific-error{color:var(--text-error);padding:10px;background-color:var(--background-modifier-error);border-radius:4px;border-left:3px solid var(--text-error)}.magnific-status{color:var(--text-muted);font-style:italic;text-align:center;padding:20px}.magnific-no-results{color:var(--text-muted);text-align:center;padding:20px;font-style:italic}.magnific-error-message{color:var(--text-error);padding:10px;background-color:var(--background-modifier-error);border-radius:4px;border-left:3px solid var(--text-error);margin:10px 0}.image-gin-drop-gate-modal{width:90vw;max-width:720px;max-height:88vh}.image-gin-drop-gate-modal .modal-content{padding:0;display:flex;flex-direction:column;max-height:calc(88vh - 60px)}.image-gin-drop-gate-modal .idg-destinations{flex:1 1 auto;overflow-y:auto}.image-gin-drop-gate-modal .idg-header{padding:1.25rem 1.5rem .75rem;border-bottom:1px solid var(--background-modifier-border)}.image-gin-drop-gate-modal .idg-title{margin:0 0 .35rem;font-size:1.25rem;font-weight:600}.image-gin-drop-gate-modal .idg-subtitle{margin:0;color:var(--text-muted);font-size:.95rem}.image-gin-drop-gate-modal .idg-file-list{display:flex;flex-direction:column;gap:.35rem;padding:.85rem 1.5rem;background:var(--background-secondary);border-bottom:1px solid var(--background-modifier-border);max-height:8rem;overflow-y:auto;flex-shrink:0}.image-gin-drop-gate-modal .idg-file-row{display:flex;justify-content:space-between;gap:1rem;font-size:.85rem}.image-gin-drop-gate-modal .idg-file-name{overflow:hidden;text-overflow:ellipsis;white-space:nowrap;color:var(--text-normal);font-family:var(--font-monospace)}.image-gin-drop-gate-modal .idg-file-meta{color:var(--text-muted);flex-shrink:0}.image-gin-drop-gate-modal .idg-destinations{display:flex;flex-direction:column;gap:.4rem;padding:1rem 1.5rem}.image-gin-drop-gate-modal .idg-destination{display:flex;align-items:flex-start;gap:.75rem;padding:.85rem 1rem;border:1px solid var(--background-modifier-border);border-radius:6px;cursor:pointer;transition:border-color .12s ease,background .12s ease}.image-gin-drop-gate-modal .idg-destination:hover:not(.idg-destination-disabled){border-color:var(--interactive-accent);background:var(--background-modifier-hover)}.image-gin-drop-gate-modal .idg-destination-disabled{opacity:.5;cursor:not-allowed}.image-gin-drop-gate-modal .idg-destination-disabled .idg-destination-hint{color:var(--text-error, var(--text-muted));font-style:italic;font-size:.78rem;margin-top:.2rem}.image-gin-drop-gate-modal .idg-destination input[type=radio]{margin-top:.2rem;accent-color:var(--interactive-accent)}.image-gin-drop-gate-modal .idg-destination-text{display:flex;flex-direction:column;gap:.15rem;min-width:0}.image-gin-drop-gate-modal .idg-destination-label{font-weight:600;color:var(--text-normal)}.image-gin-drop-gate-modal .idg-destination-desc{font-size:.8rem;color:var(--text-muted);line-height:1.35}.image-gin-drop-gate-modal .idg-remember{display:flex;align-items:center;gap:.5rem;padding:0 1.5rem .75rem;color:var(--text-muted);font-size:.85rem;cursor:pointer}.image-gin-drop-gate-modal .idg-footer{display:flex;justify-content:flex-end;gap:.5rem;padding:.85rem 1.5rem;border-top:1px solid var(--background-modifier-border);background:var(--background-secondary)}.image-gin-drop-gate-modal .idg-cancel,.image-gin-drop-gate-modal .idg-insert{padding:.4rem 1rem;border-radius:4px;font-size:.9rem;cursor:pointer;border:1px solid var(--background-modifier-border);background:var(--background-primary);color:var(--text-normal)}.image-gin-drop-gate-modal .idg-cancel:hover{background:var(--background-modifier-hover)}.image-gin-drop-gate-modal .idg-insert.mod-cta{background:var(--interactive-accent);color:var(--text-on-accent);border-color:var(--interactive-accent)}.image-gin-drop-gate-modal .idg-insert.mod-cta:hover{background:var(--interactive-accent-hover)}.image-gin-hidden{display:none}.image-gin-row{display:flex;align-items:center;justify-content:space-between}.image-gin-row-with-margin{display:flex;align-items:center;justify-content:space-between;margin-bottom:1rem}.image-gin-row-tight{display:flex;align-items:center;gap:.5rem}.image-gin-text-area{width:100%;min-height:200px;font-family:var(--font-monospace)}.image-gin-text-area-md{width:100%;font-family:var(--font-monospace)}.image-gin-cache-stats{margin-top:10px;padding:10px;background-color:var(--background-secondary);border-radius:5px}.image-gin-cache-stats-title{font-weight:700;margin-bottom:5px}.image-gin-error-text{color:var(--text-error)}.image-gin-error-banner{color:var(--text-error);margin:10px 0;padding:10px;border-left:3px solid var(--text-error);background-color:var(--background-modifier-error)}.image-gin-thumb{max-width:100px;max-height:100px}.image-gin-preview{white-space:pre-wrap;padding:8px;background-color:var(--background-secondary);border-radius:4px;font-size:.85em}.image-gin-modal,.batch-directory-modal,.magnific-modal{min-height:60vh}.image-gin-modal h2,.batch-directory-modal h2,.magnific-modal h2{margin-top:0;padding-bottom:.75rem;border-bottom:1px solid var(--background-modifier-border);color:var(--text-normal);font-size:1.5rem;font-weight:600}.image-gin-modal{--modal-padding: 1.5rem;--border-color: var(--background-modifier-border);--hover-bg: var(--background-modifier-hover);--active-bg: var(--background-modifier-active);width:90vw;max-width:880px;box-sizing:border-box}.image-gin-modal .modal-content{padding:var(--modal-padding)}.image-gin-header{display:flex;justify-content:space-between;align-items:center;margin-bottom:1.5rem;padding-bottom:.75rem;border-bottom:1px solid var(--border-color)}.image-gin-title{margin:0;color:var(--text-normal);font-size:1.5rem;font-weight:600}.image-gin-section{margin-bottom:1.5rem;border:1px solid var(--border-color);border-radius:6px;overflow:hidden}.image-gin-section-header{padding:.75rem 1rem;background-color:var(--background-secondary);border-bottom:1px solid var(--border-color);font-weight:600}.image-gin-section-content{padding:1rem}.image-gin-textarea{width:100%;min-height:100px;resize:vertical;padding:.5rem;border:1px solid var(--border-color);border-radius:4px;background:var(--background-primary);color:var(--text-normal)}.image-gin-textarea:focus{border-color:var(--interactive-accent);box-shadow:0 0 0 1px var(--interactive-accent);outline:none}.image-gin-toggle-group{display:flex;flex-direction:column;gap:.5rem}.image-gin-toggle-item{display:flex;align-items:center;padding:.5rem;border-radius:4px;transition:background-color .2s ease}.image-gin-toggle-item:hover{background-color:var(--hover-bg)}.image-gin-toggle-item .toggle-container{margin-right:.75rem}.image-gin-progress{margin:1rem 0;padding:1rem;background-color:var(--hover-bg);border-radius:4px;text-align:center}.image-gin-progress-text{color:var(--text-normal);font-weight:500;margin:0}.image-gin-button{width:100%;padding:.75rem 1.5rem;background:var(--interactive-accent);color:var(--text-on-accent);border:none;border-radius:4px;font-size:1rem;font-weight:500;cursor:pointer;transition:background-color .2s ease,transform .1s ease}.image-gin-button:disabled{opacity:.6;cursor:not-allowed}.image-gin-button:not(:disabled):hover{background-color:var(--interactive-accent-hover);transform:translateY(-1px)}.image-gin-button:not(:disabled):active{transform:translateY(0)}.modal-section{margin-bottom:2rem;border:1px solid var(--background-modifier-border);border-radius:8px;overflow:hidden;background-color:var(--background-primary)}.modal-section h3{margin:0;padding:1rem;background-color:var(--background-secondary);color:var(--text-normal);font-size:1.1rem;font-weight:600;border-bottom:1px solid var(--background-modifier-border)}.modal-section .setting-item{padding:1rem;border-bottom:1px solid var(--background-modifier-border-hover);background-color:var(--background-primary);transition:background-color .2s ease}.modal-section .setting-item:last-child{border-bottom:none}.modal-section .setting-item:hover{background-color:var(--background-primary-alt)}.batch-directory-modal{width:90vw;max-width:1000px;box-sizing:border-box}.batch-directory-modal .modal-content{padding:1.5rem}.batch-directory-modal .modal-section{margin-bottom:2rem}.batch-directory-modal .directory-input{background-color:var(--background-primary-alt);border:2px solid var(--interactive-accent);border-radius:6px;padding:.75rem;margin-bottom:1rem}.batch-directory-modal .directory-input input[type=text]{width:100%;font-family:var(--font-monospace);font-size:.95rem;font-weight:500}.batch-directory-modal .batch-operation{padding:1rem;border-left:3px solid var(--interactive-accent);margin-bottom:1rem;background-color:var(--background-secondary-alt)}.batch-directory-modal .batch-operation-title{font-weight:600;color:var(--text-normal);margin-bottom:.5rem}.batch-directory-modal .batch-operation-description{color:var(--text-muted);font-size:.9rem;margin-bottom:.75rem;line-height:1.4}.batch-directory-modal .batch-inputs{display:flex;gap:.75rem;margin-bottom:.75rem;flex-wrap:wrap}.batch-directory-modal .batch-inputs input[type=text]{flex:1;min-width:150px;padding:.5rem;border:1px solid var(--background-modifier-border);border-radius:4px;background-color:var(--background-primary);color:var(--text-normal)}.batch-directory-modal .batch-button{padding:.5rem 1.5rem;border:1px solid var(--interactive-accent);border-radius:4px;background-color:var(--interactive-accent);color:var(--text-on-accent);cursor:pointer;transition:all .2s ease}.batch-directory-modal .batch-button:hover{background-color:var(--interactive-accent-hover);transform:translateY(-1px)}.batch-directory-modal .batch-button.secondary{background-color:var(--background-secondary);border-color:var(--background-modifier-border);color:var(--text-normal)}.batch-directory-modal .batch-button.secondary:hover{background-color:var(--background-modifier-hover)}.batch-directory-modal .batch-button:active{transform:translateY(0)}.batch-directory-modal .analysis-section{background-color:var(--background-secondary-alt)}.batch-directory-modal .analysis-section h3{background-color:var(--background-modifier-success);color:var(--text-normal)}.batch-directory-modal .stats-display{padding:1rem;background-color:var(--background-primary);border:1px solid var(--background-modifier-border);border-radius:4px;font-family:var(--font-monospace);font-size:.9rem;line-height:1.6;margin-top:.75rem}.flex-row{display:flex;gap:.75rem;align-items:center;flex-wrap:wrap}.flex-column{display:flex;flex-direction:column;gap:.5rem}.text-muted{color:var(--text-muted);font-size:.9rem}.text-accent{color:var(--interactive-accent);font-weight:500}.margin-bottom-small{margin-bottom:.5rem}.margin-bottom-medium{margin-bottom:1rem}.margin-bottom-large{margin-bottom:1.5rem}.progress-indicator{display:inline-block;width:16px;height:16px;border:2px solid var(--interactive-accent);border-top:2px solid transparent;border-radius:50%;animation:spin 1s linear infinite;margin-right:.5rem}@keyframes spin{0%{transform:rotate(0)}to{transform:rotate(360deg)}}.status-badge{display:inline-block;padding:.2rem .5rem;border-radius:12px;font-size:.75rem;font-weight:600;text-transform:uppercase;letter-spacing:.5px}.status-badge.success{background-color:var(--background-modifier-success);color:var(--text-on-accent)}.status-badge.warning{background-color:var(--background-modifier-error);color:var(--text-on-accent)}.status-badge.info{background-color:var(--interactive-accent);color:var(--text-on-accent)}@media(max-width:768px){.modal{padding:1rem;max-width:100%}.batch-directory-modal .batch-inputs{flex-direction:column}.batch-directory-modal .batch-inputs input[type=text]{min-width:100%}.current-file-modal .text-case-buttons{flex-direction:column}.current-file-modal .text-case-buttons button{min-width:100%}.current-file-modal .setting-item-control{flex-direction:column;align-items:stretch}}.theme-dark .modal-section{border-color:var(--background-modifier-border)}.theme-dark .modal-section h3{background-color:var(--background-secondary)}.theme-dark .batch-directory-modal .batch-operation{background-color:var(--background-secondary);border-left-color:var(--interactive-accent)}.theme-light .modal-section{box-shadow:0 1px 3px #0000001a}.theme-light .batch-directory-modal .batch-operation{background-color:var(--background-primary-alt)}@media(max-width:600px){.image-gin-modal{padding:1rem}.image-gin-title{font-size:1.25rem}.image-gin-section-content{padding:.75rem}}
Reference in a new issue View git blame Copy permalink