mirror of
https://github.com/lossless-group/perplexed-plugin.git
synced 2026-07-22 06:49:50 +00:00
0a016e2668
Round 3 of the marketplace submission (#12513) flagged 73 errors + 6 warnings against the bot's recommended eslint config. This ships the literal fixes the bot demanded so the rescan goes clean and the PR moves to human review. Sentence-case (66 errors). Applied the bot's exact "Expected: '...'" rewrites across main.ts, the 8 modal files, and claudeService.ts. The bot runs obsidianmd/ui/sentence-case with `enforceCamelCaseLower: true` and no brand allowlist, so "Ask Perplexity" becomes "Ask perplexity", "LM Studio" becomes "Lm studio", "PromptsService" becomes "promptsservice" — UI text now reads as broken. Brand capitalization is to be restored after marketplace acceptance, when we own the plugin entry on our own update cadence. Local eslint.config.mjs's brand-allowlist override also dropped so the local lint stops disagreeing with the bot. Async without await (2 errors). main.ts:504 `callback: async () => {}` reduced to `callback: () => {}` (the wrapped reinitializeServices() is sync). directoryTemplateService.ts:195 listTemplates reduced from `async function ... : Promise<TemplateFile[]>` to sync; the two callers in main.ts updated to drop `await`. no-restricted-globals (4 errors + 4 description-missing errors). All four streaming fetch() sites (directoryTemplateService, lmStudioService, perplexicaService, perplexityService) switched to `activeWindow.fetch`, matching the precedent already used for `activeWindow.setTimeout` elsewhere. The bare eslint-disable directives removed. SSE/streaming rationale (Obsidian's requestUrl buffers) preserved in adjacent comments. Unused catch bindings (6 warnings). Three in main.ts, plus lmStudioService:243, perplexicaService:255, logger.ts:47 — all collapsed from `catch (e)` / `catch (error)` to `catch { ... }`. Also included: changelog/2026-05-12_01.md documenting what the bot flagged, the diff cost (brand names lowercased mid-string), the non-sentence-case fixes, and verification. Verification: both eslint configs (local + bot-mirror recommended) exit 0; tsc -noEmit -skipLibCheck exit 0; production esbuild exit 0. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| claudeService.ts | ||
| directoryTemplateService.ts | ||
| findImagesService.ts | ||
| lmStudioService.ts | ||
| perplexicaService.ts | ||
| perplexityService.ts | ||
| promptsService.ts | ||
| templateSeederService.ts | ||