From c00f9951e630dd68eebdbcc086d229d4eb067cce Mon Sep 17 00:00:00 2001 From: Maximilian Ertl Date: Thu, 9 May 2024 20:55:31 +0200 Subject: [PATCH] fix: use default note type when creating folder note from click event The click event handlers would call `createFolderNote` with an undefined `extension` parameter, which will ultimately lead to the specified Template not being applied due to a mismatch between the actually created and specified file extensions here: https://github.com/LostPaul/obsidian-folder-notes/blob/945c25f97e0fe64c5a5140a6a6f6c719814f5320/src/functions/folderNoteFunctions.ts#L112 This change explicitly sets the extension parameter to whatever is specified in the settings as default, to prevent that error from happening. --- src/events/handleClick.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/events/handleClick.ts b/src/events/handleClick.ts index fdfceb6..8839e61 100644 --- a/src/events/handleClick.ts +++ b/src/events/handleClick.ts @@ -37,7 +37,7 @@ export async function handleViewHeaderClick(event: MouseEvent, plugin: FolderNot return; } else if (event.altKey || Keymap.isModEvent(event) === 'tab') { if ((plugin.settings.altKey && event.altKey) || (plugin.settings.ctrlKey && Keymap.isModEvent(event) === 'tab')) { - await createFolderNote(plugin, folderPath, true, undefined, true); + await createFolderNote(plugin, folderPath, true, plugin.settings.folderNoteType, true); addCSSClassToTitleEL(folderPath, 'has-folder-note', plugin); removeCSSClassFromEL(folderPath, 'has-not-folder-note', plugin); return; @@ -87,7 +87,7 @@ export async function handleFolderClick(event: MouseEvent, plugin: FolderNotesPl } } else if (event.altKey || Keymap.isModEvent(event) === 'tab') { if ((plugin.settings.altKey && event.altKey) || (plugin.settings.ctrlKey && Keymap.isModEvent(event) === 'tab')) { - await createFolderNote(plugin, folderPath, true, undefined, true); + await createFolderNote(plugin, folderPath, true, plugin.settings.folderNoteType, true); addCSSClassToTitleEL(folderPath, 'has-folder-note', plugin); removeCSSClassFromEL(folderPath, 'has-not-folder-note', plugin); return;