From c72697b81bc1d1e3133477a7f97be0ffe0c8eef0 Mon Sep 17 00:00:00 2001
From: Lost Paul <70213368+LostPaul@users.noreply.github.com>
Date: Sat, 1 Jun 2024 16:18:45 +0200
Subject: [PATCH] Option to disable the sidebar on desktop

Added a setting to also disable the sidebar from automatically opening when you click on a folder name in the path on desktop
---
 src/events/handleClick.ts    |  4 ++--
 src/settings/PathSettings.ts | 16 ++++++++++++++--
 src/settings/SettingsTab.ts  | 10 ++++++++--
 3 files changed, 24 insertions(+), 6 deletions(-)

diff --git a/src/events/handleClick.ts b/src/events/handleClick.ts
index 53c935e..2d9ace1 100644
--- a/src/events/handleClick.ts
+++ b/src/events/handleClick.ts
@@ -28,9 +28,9 @@ export async function handleViewHeaderClick(event: MouseEvent, plugin: FolderNot
 		await openFolderNote(plugin, folderNote, event).then(async () => {
 			// @ts-ignore
 			const fileExplorerPlugin = plugin.app.internalPlugins.getEnabledPluginById('file-explorer');
-			if (fileExplorerPlugin && Platform.isMobile && plugin.settings.openSidebarWhenClickingOnPath) {
+			if (fileExplorerPlugin && Platform.isMobile && plugin.settings.openSidebar.mobile) {
 				setTimeout(() => { fileExplorerPlugin.revealInFolder(folderNote); }, 200);
-			} else if (fileExplorerPlugin) {
+			} else if (fileExplorerPlugin && Platform.isDesktop && plugin.settings.openSidebar.desktop) {
 				fileExplorerPlugin.revealInFolder(folderNote);
 			}
 		});
diff --git a/src/settings/PathSettings.ts b/src/settings/PathSettings.ts
index 6b3f511..0a2be77 100644
--- a/src/settings/PathSettings.ts
+++ b/src/settings/PathSettings.ts
@@ -20,9 +20,21 @@ export async function renderPath(settingsTab: SettingsTab) {
         .setDesc('Open the sidebar when opening a folder note through the path on mobile')
         .addToggle((toggle) =>
             toggle
-                .setValue(settingsTab.plugin.settings.openSidebarWhenClickingOnPath)
+                .setValue(settingsTab.plugin.settings.openSidebar.mobile)
                 .onChange(async (value) => {
-                    settingsTab.plugin.settings.openSidebarWhenClickingOnPath = value;
+                    settingsTab.plugin.settings.openSidebar.mobile = value;
+                    await settingsTab.plugin.saveSettings();
+                })
+        );
+
+    new Setting(containerEl)
+        .setName('Open sidebar when opening a folder note through path (Desktop only)')
+        .setDesc('Open the sidebar when opening a folder note through the path on desktop')
+        .addToggle((toggle) =>
+            toggle
+                .setValue(settingsTab.plugin.settings.openSidebar.desktop)
+                .onChange(async (value) => {
+                    settingsTab.plugin.settings.openSidebar.desktop = value;
                     await settingsTab.plugin.saveSettings();
                 })
         );
diff --git a/src/settings/SettingsTab.ts b/src/settings/SettingsTab.ts
index 1918550..0986f53 100644
--- a/src/settings/SettingsTab.ts
+++ b/src/settings/SettingsTab.ts
@@ -59,7 +59,10 @@ export interface FolderNotesSettings {
 	hideCollapsingIcon: boolean;
 	ignoreAttachmentFolder: boolean;
 	tabManagerEnabled: boolean;
-	openSidebarWhenClickingOnPath: boolean;
+	openSidebar: {
+		mobile: boolean;
+		desktop: boolean;
+	}
 }
 
 export const DEFAULT_SETTINGS: FolderNotesSettings = {
@@ -150,7 +153,10 @@ export const DEFAULT_SETTINGS: FolderNotesSettings = {
 	hideCollapsingIcon: false,
 	tabManagerEnabled: true,
 	ignoreAttachmentFolder: true,
-	openSidebarWhenClickingOnPath: false,
+	openSidebar: {
+		mobile: false,
+		desktop: true,
+	}
 };
 
 export class SettingsTab extends PluginSettingTab {