From 2f617bc669a5fcf0dbfb0713c10bc26d12fdb97a Mon Sep 17 00:00:00 2001 From: Mayuran Visakan Date: Fri, 7 Jul 2023 00:58:35 +0100 Subject: [PATCH] Remove console log --- .github/TODO.md | 26 ++++++++++++-------------- README.md | 10 ++++++++-- src/EditingView.ts | 1 - 3 files changed, 20 insertions(+), 17 deletions(-) diff --git a/.github/TODO.md b/.github/TODO.md index 0c8ea2e..5e3638f 100644 --- a/.github/TODO.md +++ b/.github/TODO.md @@ -1,20 +1,22 @@ # TODO -1. Live preview issue on open of note #Bug - - Small differences in line number margins -2. Deal with codeblocks created by indentation #NotUrgent +## Important + +1. Sort header CSS logic properly - some small issues +2. Fix PDF Export +3. Sort `styles.css` and rename variables + +## Not Urgent + +1. Deal with codeblocks created by indentation - Editing Mode (`cm-hmd-indented-code`) - Reading Mode -3. Dataview compatibility #NotUrgent -4. Fix PDF Export #Important -5. Sorting `styles.css` #NotUrgent -6. Sort header CSS logic properly - some small issues #Important -7. Add features for outer border and codeblock shadow #NotUrgent -8. Check through: #NotUrgent +2. Dataview compatibility +3. Check through: #NotUrgent - `package.json` - `package-lock.json` - `eslintrc` -9. Update github: #NotUrgent +4. Update github: #NotUrgent - Better issue templates using [yaml](https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository) - [Example 1](https://github.com/javalent/admonitions/tree/main/.github/ISSUE_TEMPLATE) - [Example 2](https://github.com/obsidian-tasks-group/obsidian-tasks/tree/main/.github/ISSUE_TEMPLATE) @@ -28,7 +30,3 @@ - Documentation: - Actions: - [Example 1](https://github.com/obsidian-tasks-group/obsidian-tasks/blob/main/.github/workflows/update-docs-markdown.yml) -10. Add new themes: #NotUrgent - - Nord - - Gruvbox - - Catpuccin diff --git a/README.md b/README.md index a5780f4..a8aa661 100644 --- a/README.md +++ b/README.md @@ -274,9 +274,14 @@ Take a look at the [changelog](CHANGELOG.md) to see what has changed in past ver - Commands to fold all, unfold all and reset default fold for codeblocks . - Hook into existing fold commands as well. - Optional outer border. - - Optional shadow. + - Optional shadow for codeblock. - Dataview compatibility. - Compatibility with codeblocks created by indentation. + - New Themes + - Nord + - Dracula + - Gruvbox + - Catpuccin - Check the feasibility of: - Implementing code wrapping for editing mode. - Implementing folding animations for editing mode. @@ -288,8 +293,9 @@ Take a look at the [changelog](CHANGELOG.md) to see what has changed in past ver - First pickr change does not change color correctly. - Indented codeblocks are not dealt with properly. - Editing Mode + - On open of a note, there are small differences in the line number margins. - Weird scroll in live preview when click (due to `codeblockHeader` codemirror extension) when first line is a codeblock. - - If a language is excluded, it currently needs to be unfolded before it can be removed or it disappears. + - If a language is excluded or ignored, it currently needs to be unfolded before it can be removed or it disappears. - Moving the cursor next to a collapsed codeblock and typing can cause it to disappear. - Reading Mode - Codeblocks constantly collapse and re-expand if editing side by side in editing mode. diff --git a/src/EditingView.ts b/src/EditingView.ts index c9fb311..b4bb70f 100644 --- a/src/EditingView.ts +++ b/src/EditingView.ts @@ -371,7 +371,6 @@ function getCharWidth(state: EditorState, default_value: number): number { },[]) if (charWidths.length === 0) return default_value; - console.log('result') return charWidths.reduce((result,value)=>result+value,0) / charWidths.length; }