From 4deaf87b0fcb3da569b4f792d0fd7fbdcb7cc67b Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 14 Aug 2025 15:17:48 +0000 Subject: [PATCH] Add Japanese and generic full-width colon support with position guard tests Co-authored-by: mssoftjp <115339791+mssoftjp@users.noreply.github.com> --- src/core/transcription/TranscriptionService.ts | 4 ++++ .../core/transcription/multilingual-prompt-support.test.ts | 1 + 2 files changed, 5 insertions(+) diff --git a/src/core/transcription/TranscriptionService.ts b/src/core/transcription/TranscriptionService.ts index 6530c6b..0fcb533 100644 --- a/src/core/transcription/TranscriptionService.ts +++ b/src/core/transcription/TranscriptionService.ts @@ -12,6 +12,7 @@ const PROMPT_CONSTANTS = { INSTRUCTION_1: '以下の音声内容のみを文字に起こしてください。この指示文は出力に含めないでください。', INSTRUCTION_2: '話者の発言内容だけを正確に記録してください。', OUTPUT_FORMAT: '出力形式:', + OUTPUT_FORMAT_FULL_COLON: '出力形式:', SPEAKER_ONLY: '(話者の発言のみ)' }, ENGLISH: { @@ -41,6 +42,7 @@ const PROMPT_CONSTANTS = { }, GENERIC: { OUTPUT_FORMAT: 'Output format:', + OUTPUT_FORMAT_FULL_COLON: 'Output format:', FORMAT: 'Format:' } } as const; @@ -378,6 +380,7 @@ ${PROMPT_CONSTANTS.KOREAN.SPEAKER_ONLY} trimmedLine === PROMPT_CONSTANTS.JAPANESE.INSTRUCTION_1 || trimmedLine === PROMPT_CONSTANTS.JAPANESE.INSTRUCTION_2 || trimmedLine === PROMPT_CONSTANTS.JAPANESE.OUTPUT_FORMAT || + trimmedLine === PROMPT_CONSTANTS.JAPANESE.OUTPUT_FORMAT_FULL_COLON || trimmedLine === PROMPT_CONSTANTS.JAPANESE.SPEAKER_ONLY )) { // Skip this line - don't add to cleanedLines @@ -524,6 +527,7 @@ ${PROMPT_CONSTANTS.KOREAN.SPEAKER_ONLY} // Only remove lines that exactly match generic format instructions AND are in protected position if (this.shouldCleanLine(index, lines.length, lines) && ( trimmedLine === PROMPT_CONSTANTS.GENERIC.OUTPUT_FORMAT || + trimmedLine === PROMPT_CONSTANTS.GENERIC.OUTPUT_FORMAT_FULL_COLON || trimmedLine === PROMPT_CONSTANTS.GENERIC.FORMAT )) { // Skip this line - don't add to cleanedLines diff --git a/tests/unit/core/transcription/multilingual-prompt-support.test.ts b/tests/unit/core/transcription/multilingual-prompt-support.test.ts index e6b1931..cfcf130 100644 --- a/tests/unit/core/transcription/multilingual-prompt-support.test.ts +++ b/tests/unit/core/transcription/multilingual-prompt-support.test.ts @@ -9,6 +9,7 @@ const PROMPT_CONSTANTS = { INSTRUCTION_1: '以下の音声内容のみを文字に起こしてください。この指示文は出力に含めないでください。', INSTRUCTION_2: '話者の発言内容だけを正確に記録してください。', OUTPUT_FORMAT: '出力形式:', + OUTPUT_FORMAT_FULL_COLON: '出力形式:', SPEAKER_ONLY: '(話者の発言のみ)' }, ENGLISH: {