Allow duplicate auto-review summaries

This commit is contained in:
murashit 2026-05-19 16:16:18 +09:00
parent 59137dd99e
commit 0897ddb33a
4 changed files with 14 additions and 8 deletions

View file

@ -128,7 +128,7 @@ function autoReviewSummariesForTurns(items: DisplayItem[]): Map<string, string[]
const summary = item.text.trim();
if (!summary) continue;
const summaries = byTurn.get(item.turnId) ?? [];
if (!summaries.includes(summary)) summaries.push(summary);
summaries.push(summary);
byTurn.set(item.turnId, summaries);
}
return byTurn;

View file

@ -1567,10 +1567,6 @@
margin: 2px 0 0;
}
.codex-panel__user-input-radio:checked + .codex-panel__user-input-option-label {
color: var(--text-accent);
}
.codex-panel__user-input-option-description {
grid-column: 2;
color: var(--text-muted);

View file

@ -1076,11 +1076,21 @@ describe("display block grouping keeps work logs subordinate to conversation mes
turnId: "t1",
state: "completed",
},
{
id: "review-2",
kind: "reviewResult",
role: "tool",
text: "Auto-review approved: npm test",
turnId: "t1",
state: "completed",
},
{ id: "a1", kind: "message", role: "assistant", text: "done", turnId: "t1" },
];
const assistantBlock = displayBlocksForItems(items, null).find((block) => block.type === "item" && block.item.role === "assistant");
expect(assistantBlock).toMatchObject({ item: { autoReviewSummaries: ["Auto-review approved: npm test"] } });
expect(assistantBlock).toMatchObject({
item: { autoReviewSummaries: ["Auto-review approved: npm test", "Auto-review approved: npm test"] },
});
});
});

View file

@ -1636,7 +1636,7 @@ describe("pending request renderer decisions", () => {
text: "Done",
turnId: "turn",
markdown: true,
autoReviewSummaries: ["Auto-review approved: npm test"],
autoReviewSummaries: ["Auto-review approved: npm test", "Auto-review approved: npm test"],
},
],
openDetails: new Set(),
@ -1647,7 +1647,7 @@ describe("pending request renderer decisions", () => {
const element = block.render();
expect(element.querySelector(".codex-panel__auto-reviews summary")?.textContent).toBe("Auto-reviewed 1 request");
expect(element.querySelector(".codex-panel__auto-reviews summary")?.textContent).toBe("Auto-reviewed 2 requests");
expect(element.querySelector(".codex-panel__auto-reviews")?.textContent).toContain("Auto-review approved: npm test");
});