obsidian-plugin/murashit_codex-panel
1
0
Fork 0
mirror of https://github.com/murashit/codex-panel.git synced 2026-07-22 06:57:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Enforce app-server RPC boundary policy

Browse source
This commit is contained in:
murashit 2026-06-30 19:03:04 +09:00
parent 783b375617
commit 82ef80ece4
4 changed files with 37 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
biome.jsonc
View file

@ -86,8 +86,8 @@
]
},
{
"path": "./scripts/grit/runtime/no-app-server-projection-rpcs.grit",
"includes": ["**/src/features/chat/application/**/*.ts"]
"path": "./scripts/grit/runtime/no-app-server-direct-rpcs.grit",
"includes": ["**/src/**/*.ts", "**/src/**/*.tsx", "!**/src/app-server/**", "!**/src/features/chat/app-server/**"]
},
// Workspace and feature coordination boundaries.
{

5
scripts/grit/runtime/no-app-server-direct-rpcs.grit Normal file
View file

@ -0,0 +1,5 @@
language js
`$target.request($...)` as $stmt where {
register_diagnostic(span=$stmt, message="Keep direct app-server RPC calls behind app-server services and chat app-server adapters.", severity="error")
}

11
scripts/grit/runtime/no-app-server-projection-rpcs.grit
View file

@ -1,11 +0,0 @@
language js
or {
`$client.request("thread/resume", $...)` as $stmt,
`$client.request("thread/turns/list", $...)` as $stmt,
`$client.request("thread/fork", $...)` as $stmt,
`$client.request("thread/rollback", $...)` as $stmt
} where {
$client <: r"^(?:client|[A-Za-z_$][A-Za-z0-9_$]*Client)$",
register_diagnostic(span=$stmt, message="Keep app-server projection RPCs behind app-server facades; consume Panel-owned snapshots or view models here.", severity="error")
}

36
tests/scripts/grit-policy.test.mjs
View file

@ -42,6 +42,7 @@ const DOM_EVENTS_IMPORT_MESSAGE = "Import DOM event listener helpers only from e
const CHAT_SHELL_READ_MODEL_IMPORT_MESSAGE =
"Import chat panel signal read models only from the shell and panel surface rendering adapters.";
const CHAT_SIGNAL_TYPE_REFERENCE_MESSAGE = "Keep Preact signal types inside the chat panel read-model and surface rendering adapter layer.";
const APP_SERVER_DIRECT_RPC_MESSAGE = "Keep direct app-server RPC calls behind app-server services and chat app-server adapters.";
let appServerBoundaryPolicyReportPromise;
let renderingAndCssPolicyReportPromise;
@ -950,14 +951,14 @@ export const read = listThreads;
expect(pluginDiagnostics(report, "src/app-server/services/allowed.ts")).toEqual([]);
});
it("keeps chat application app-server projection RPCs behind facades", async () => {
it("keeps direct app-server RPCs behind app-server boundary adapters", async () => {
const report = await appServerBoundaryPolicyReport();
expect(pluginMessages(report, "src/features/chat/application/threads/history.ts")).toEqual([
"Keep app-server projection RPCs behind app-server facades; consume Panel-owned snapshots or view models here.",
]);
expect(pluginMessages(report, "src/features/chat/application/threads/history.ts")).toEqual([APP_SERVER_DIRECT_RPC_MESSAGE]);
expect(pluginMessages(report, "src/features/chat/host/bundles/connection-bundle.ts")).toEqual([APP_SERVER_DIRECT_RPC_MESSAGE]);
expect(pluginMessages(report, "src/settings/runtime-config.ts")).toEqual([APP_SERVER_DIRECT_RPC_MESSAGE]);
expect(pluginDiagnostics(report, "src/app-server/services/threads.ts")).toEqual([]);
expect(pluginDiagnostics(report, "src/features/chat/host/bundles/connection-bundle.ts")).toEqual([]);
expect(pluginDiagnostics(report, "src/features/chat/app-server/transports/threads.ts")).toEqual([]);
});
it("keeps CSS on design tokens and scoped selectors", async () => {
@ -1126,7 +1127,7 @@ async function createAppServerBoundaryPolicyReport() {
"no-domain-outer-layer-imports.grit",
"no-lower-level-feature-imports.grit",
"no-app-server-connection-boundary-imports.grit",
"no-app-server-projection-rpcs.grit",
"no-app-server-direct-rpcs.grit",
]);
await writeFile(
path.join(cwd, "src/features/chat/domain/generated-thread.ts"),
@ -1397,6 +1398,27 @@ import type { AppServerClient } from "../../../../app-server/connection/client";
export async function resume(client: AppServerClient): Promise<void> {
await client.request("thread/resume", { threadId: "thread", cwd: "/vault" });
}
`.trimStart(),
);
await writeFile(
path.join(cwd, "src/settings/runtime-config.ts"),
`
import type { AppServerClient } from "../app-server/connection/client";
export async function read(client: AppServerClient): Promise<void> {
await client.request("config/read", { cwd: "/vault", includeLayers: true });
}
`.trimStart(),
);
await mkdir(path.join(cwd, "src/features/chat/app-server/transports"), { recursive: true });
await writeFile(
path.join(cwd, "src/features/chat/app-server/transports/threads.ts"),
`
import type { AppServerClient } from "../../../../app-server/connection/client";
export async function read(client: AppServerClient): Promise<void> {
await client.request("thread/turns/list", { threadId: "thread", cursor: null, limit: 20 });
}
`.trimStart(),
);
return biomeLint(
@ -1431,6 +1453,8 @@ export async function resume(client: AppServerClient): Promise<void> {
"src/features/chat/application/threads/history.ts",
"src/app-server/services/threads.ts",
"src/features/chat/host/bundles/connection-bundle.ts",
"src/settings/runtime-config.ts",
"src/features/chat/app-server/transports/threads.ts",
],
cwd,
);