mirror of
https://github.com/murashit/codex-panel.git
synced 2026-07-22 06:57:10 +00:00
442 lines
17 KiB
TypeScript
442 lines
17 KiB
TypeScript
import { describe, expect, it, vi } from "vitest";
|
|
import type { CatalogModel, CatalogSkillMetadata } from "../../src/app-server/protocol/catalog";
|
|
import { AppServerQueryCache } from "../../src/app-server/query/cache";
|
|
import type { AppServerQueryContext } from "../../src/app-server/query/keys";
|
|
import type { ModelMetadata, SkillMetadata } from "../../src/domain/catalog/metadata";
|
|
import { emptyRuntimeConfigSnapshot, type RuntimeConfigSnapshot } from "../../src/domain/runtime/config";
|
|
import type { RateLimitSnapshot } from "../../src/domain/runtime/metrics";
|
|
import {
|
|
createServerDiagnostics,
|
|
diagnosticProbeError,
|
|
diagnosticProbeOk,
|
|
diagnosticsWithProbe,
|
|
} from "../../src/domain/server/diagnostics";
|
|
import type { SharedServerMetadata } from "../../src/domain/server/metadata";
|
|
|
|
describe("AppServerQueryCache", () => {
|
|
it("stores metadata snapshots without replacing failed resource values with stale values", () => {
|
|
const cache = new AppServerQueryCache();
|
|
const context = cacheContext();
|
|
const goodMetadata = metadata({
|
|
availableSkills: [skillMetadata("writer")],
|
|
rateLimit: rateLimit(42),
|
|
});
|
|
|
|
cache.writeAppServerMetadata(context, goodMetadata);
|
|
expect(cache.appServerMetadataSnapshot(context)?.availableModels.map((model) => model.model)).toEqual(["gpt-5.5"]);
|
|
|
|
cache.writeAppServerMetadata(
|
|
context,
|
|
metadata({
|
|
availableModels: [modelMetadata("gpt-5.6")],
|
|
availableSkills: [skillMetadata("stale-skill")],
|
|
rateLimit: rateLimit(90),
|
|
skillsProbeStatus: "failed",
|
|
rateLimitProbeStatus: "failed",
|
|
}),
|
|
);
|
|
|
|
expect(cache.appServerMetadataSnapshot(context)?.availableModels.map((model) => model.model)).toEqual(["gpt-5.6"]);
|
|
expect(cache.appServerMetadataSnapshot(context)?.availableSkills.map((skill) => skill.name)).toEqual(["stale-skill"]);
|
|
expect(cache.appServerMetadataSnapshot(context)?.rateLimit?.primary?.usedPercent).toBe(90);
|
|
expect(cache.appServerMetadataSnapshot(context)?.serverDiagnostics.probes["skills/list"].status).toBe("failed");
|
|
expect(cache.appServerMetadataSnapshot(context)?.serverDiagnostics.probes["account/rateLimits/read"].status).toBe("failed");
|
|
|
|
cache.writeAppServerMetadata(context, metadata({ availableModels: [], modelProbeStatus: "failed" }));
|
|
expect(cache.appServerMetadataSnapshot(context)?.availableModels.map((model) => model.model)).toEqual(["gpt-5.6"]);
|
|
expect(cache.appServerMetadataSnapshot(context)?.serverDiagnostics.probes["model/list"].status).toBe("failed");
|
|
});
|
|
|
|
it("does not accept failed metadata model payloads as model cache truth", () => {
|
|
const cache = new AppServerQueryCache();
|
|
const context = cacheContext();
|
|
|
|
cache.writeAppServerMetadata(
|
|
context,
|
|
metadata({
|
|
availableModels: [modelMetadata("failed-model")],
|
|
availableSkills: [skillMetadata("writer")],
|
|
rateLimit: rateLimit(90),
|
|
modelProbeStatus: "failed",
|
|
rateLimitProbeStatus: "failed",
|
|
}),
|
|
);
|
|
|
|
const cached = cache.appServerMetadataSnapshot(context);
|
|
expect(cached?.runtimeConfig).not.toBeNull();
|
|
expect(cached?.serverDiagnostics.probes["model/list"].status).toBe("failed");
|
|
expect(cached?.availableModels).toEqual([]);
|
|
expect(cached?.availableSkills.map((skill) => skill.name)).toEqual(["writer"]);
|
|
expect(cached?.rateLimit?.primary?.usedPercent).toBe(90);
|
|
expect(cache.modelsSnapshot(context)).toBeNull();
|
|
});
|
|
|
|
it("does not share or store snapshots before the cache context is complete", async () => {
|
|
const cache = new AppServerQueryCache();
|
|
const context = cacheContext({ codexPath: "" });
|
|
|
|
await expect(cache.fetchActiveThreads(context)).resolves.toEqual([]);
|
|
cache.setActiveThreads(context, [thread("applied")]);
|
|
cache.writeAppServerMetadata(context, metadata());
|
|
|
|
expect(cache.activeThreadsSnapshot(context)).toBeNull();
|
|
expect(cache.appServerMetadataSnapshot(context)).toBeNull();
|
|
expect(cache.modelsSnapshot(context)).toBeNull();
|
|
});
|
|
|
|
it("stores successful empty model snapshots as shared cache truth", () => {
|
|
const cache = new AppServerQueryCache();
|
|
const context = cacheContext();
|
|
|
|
cache.writeAppServerMetadata(context, metadata({ availableModels: [modelMetadata("gpt-5.6")] }));
|
|
cache.writeAppServerMetadata(context, metadata({ availableModels: [] }));
|
|
|
|
expect(cache.appServerMetadataSnapshot(context)?.availableModels).toEqual([]);
|
|
expect(cache.modelsSnapshot(context)).toEqual([]);
|
|
});
|
|
|
|
it("does not reuse metadata or model snapshots across app-server cache contexts", () => {
|
|
const cache = new AppServerQueryCache();
|
|
const context = cacheContext();
|
|
|
|
cache.writeAppServerMetadata(context, metadata());
|
|
|
|
expect(cache.appServerMetadataSnapshot(cacheContext({ vaultPath: "/other-vault" }))).toBeNull();
|
|
expect(cache.appServerMetadataSnapshot(cacheContext({ codexPath: "/opt/codex" }))).toBeNull();
|
|
expect(cache.modelsSnapshot(cacheContext({ vaultPath: "/other-vault" }))).toBeNull();
|
|
expect(cache.modelsSnapshot(cacheContext({ codexPath: "/opt/codex" }))).toBeNull();
|
|
});
|
|
|
|
it("stores successful empty thread list snapshots as shared cache truth", async () => {
|
|
const fetchThreads = vi.fn().mockResolvedValue([]);
|
|
const cache = cacheWithThreads(fetchThreads);
|
|
const context = cacheContext();
|
|
|
|
cache.setActiveThreads(context, [thread("cached")]);
|
|
cache.setActiveThreads(context, []);
|
|
|
|
expect(cache.activeThreadsSnapshot(context)).toEqual([]);
|
|
|
|
await expect(cache.refreshActiveThreads(context)).resolves.toEqual([]);
|
|
expect(cache.activeThreadsSnapshot(context)).toEqual([]);
|
|
expect(fetchThreads).toHaveBeenCalledOnce();
|
|
});
|
|
|
|
it("keeps active and archived thread list snapshots separate", async () => {
|
|
const fetchThreads = vi.fn((_context: AppServerQueryContext, archived: boolean) =>
|
|
Promise.resolve(archived ? [thread("archived", true)] : [thread("active")]),
|
|
);
|
|
const cache = cacheWithThreads(fetchThreads);
|
|
const context = cacheContext();
|
|
|
|
await expect(cache.refreshActiveThreads(context)).resolves.toEqual([thread("active")]);
|
|
await expect(cache.refreshArchivedThreads(context)).resolves.toEqual([thread("archived", true)]);
|
|
|
|
expect(cache.activeThreadsSnapshot(context)).toEqual([thread("active")]);
|
|
expect(cache.archivedThreadsSnapshot(context)).toEqual([thread("archived", true)]);
|
|
expect(fetchThreads).toHaveBeenNthCalledWith(1, context, false);
|
|
expect(fetchThreads).toHaveBeenNthCalledWith(2, context, true);
|
|
});
|
|
|
|
it("keys thread list refresh snapshots by app-server query context", async () => {
|
|
const oldContext = cacheContext({ codexPath: "codex-old" });
|
|
const newContext = cacheContext({ codexPath: "codex-new" });
|
|
const oldRefresh = deferred<readonly ReturnType<typeof thread>[]>();
|
|
const newRefresh = deferred<readonly ReturnType<typeof thread>[]>();
|
|
const fetchThreads = vi.fn((context: AppServerQueryContext) =>
|
|
context.codexPath === "codex-old" ? oldRefresh.promise : newRefresh.promise,
|
|
);
|
|
const cache = cacheWithThreads(fetchThreads);
|
|
|
|
const oldPromise = cache.refreshActiveThreads(oldContext);
|
|
const newPromise = cache.refreshActiveThreads(newContext);
|
|
|
|
oldRefresh.resolve([thread("old-thread")]);
|
|
await expect(oldPromise).resolves.toEqual([thread("old-thread")]);
|
|
expect(cache.activeThreadsSnapshot(oldContext)?.map((item) => item.id)).toEqual(["old-thread"]);
|
|
|
|
newRefresh.resolve([thread("new-thread")]);
|
|
await expect(newPromise).resolves.toEqual([thread("new-thread")]);
|
|
expect(cache.activeThreadsSnapshot(newContext)?.map((item) => item.id)).toEqual(["new-thread"]);
|
|
expect(cache.activeThreadsSnapshot(oldContext)?.map((item) => item.id)).toEqual(["old-thread"]);
|
|
});
|
|
|
|
it("stores in-flight thread list refreshes under the captured app-server cache context", async () => {
|
|
const context = cacheContext({ codexPath: "codex-captured" });
|
|
const capturedContext = { ...context };
|
|
const refresh = deferred<readonly ReturnType<typeof thread>[]>();
|
|
const cache = cacheWithThreads(() => refresh.promise);
|
|
|
|
const promise = cache.refreshActiveThreads(context);
|
|
context.codexPath = "codex-mutated";
|
|
|
|
refresh.resolve([thread("captured")]);
|
|
await expect(promise).resolves.toEqual([thread("captured")]);
|
|
|
|
expect(cache.activeThreadsSnapshot(capturedContext)?.map((item) => item.id)).toEqual(["captured"]);
|
|
expect(cache.activeThreadsSnapshot(context)).toBeNull();
|
|
});
|
|
|
|
it("fetches app-server metadata through the query cache and syncs model snapshots", async () => {
|
|
const context = cacheContext();
|
|
const cache = cacheWithClient({
|
|
readEffectiveConfig: vi.fn().mockResolvedValue({}),
|
|
listModels: vi.fn().mockResolvedValue({ data: [catalogModel("gpt-meta")] }),
|
|
listSkills: vi.fn().mockResolvedValue({ data: [{ skills: [catalogSkill("writer")] }] }),
|
|
readAccountRateLimits: vi.fn().mockResolvedValue({ rateLimits: appServerRateLimit(64), rateLimitsByLimitId: null }),
|
|
});
|
|
|
|
const metadata = await cache.refreshAppServerMetadata(context);
|
|
|
|
expect(metadata?.availableModels.map((model) => model.model)).toEqual(["gpt-meta"]);
|
|
expect(metadata?.availableSkills.map((skill) => skill.name)).toEqual(["writer"]);
|
|
expect(metadata?.rateLimit?.primary?.usedPercent).toBe(64);
|
|
expect(metadata?.serverDiagnostics.probes["model/list"].status).toBe("ok");
|
|
expect(cache.modelsSnapshot(context)?.map((model) => model.model)).toEqual(["gpt-meta"]);
|
|
});
|
|
|
|
it("shares in-flight model fetches between metadata and models queries", async () => {
|
|
const context = cacheContext();
|
|
const modelRefresh = deferred<{ data: CatalogModel[] }>();
|
|
const listModels = vi.fn(() => modelRefresh.promise);
|
|
const cache = cacheWithClient({
|
|
readEffectiveConfig: vi.fn().mockResolvedValue({}),
|
|
listModels,
|
|
listSkills: vi.fn().mockResolvedValue({ data: [{ skills: [] }] }),
|
|
readAccountRateLimits: vi.fn().mockResolvedValue({ rateLimits: appServerRateLimit(0), rateLimitsByLimitId: null }),
|
|
});
|
|
|
|
const metadataPromise = cache.refreshAppServerMetadata(context);
|
|
await flushMicrotasks();
|
|
const modelsPromise = cache.fetchModels(context);
|
|
await flushMicrotasks();
|
|
|
|
expect(listModels).toHaveBeenCalledOnce();
|
|
|
|
modelRefresh.resolve({ data: [catalogModel("gpt-shared")] });
|
|
|
|
await expect(modelsPromise).resolves.toMatchObject([{ model: "gpt-shared" }]);
|
|
await expect(metadataPromise).resolves.toMatchObject({
|
|
availableModels: [{ model: "gpt-shared" }],
|
|
});
|
|
expect(listModels).toHaveBeenCalledOnce();
|
|
expect(cache.modelsSnapshot(context)?.map((model) => model.model)).toEqual(["gpt-shared"]);
|
|
});
|
|
|
|
it("keeps query-cached models when app-server metadata model refresh fails", async () => {
|
|
const context = cacheContext();
|
|
const cache = cacheWithClient({
|
|
readEffectiveConfig: vi.fn().mockResolvedValue({}),
|
|
listModels: vi.fn().mockRejectedValue(new Error("offline")),
|
|
listSkills: vi.fn().mockResolvedValue({ data: [{ skills: [] }] }),
|
|
readAccountRateLimits: vi.fn().mockResolvedValue({ rateLimits: appServerRateLimit(0), rateLimitsByLimitId: null }),
|
|
});
|
|
cache.writeAppServerMetadata(context, metadata({ availableModels: [modelMetadata("gpt-cached")] }));
|
|
|
|
const metadataSnapshot = await cache.refreshAppServerMetadata(context);
|
|
|
|
expect(metadataSnapshot?.availableModels.map((model) => model.model)).toEqual(["gpt-cached"]);
|
|
expect(metadataSnapshot?.serverDiagnostics.probes["model/list"].status).toBe("failed");
|
|
expect(cache.modelsSnapshot(context)?.map((model) => model.model)).toEqual(["gpt-cached"]);
|
|
});
|
|
|
|
it("clears thread list snapshots by context", () => {
|
|
const cache = new AppServerQueryCache();
|
|
const context = cacheContext();
|
|
|
|
cache.setActiveThreads(context, [thread("thread")]);
|
|
|
|
expect(cache.activeThreadsSnapshot(context)).toEqual([thread("thread")]);
|
|
|
|
cache.clearContext(context);
|
|
|
|
expect(cache.activeThreadsSnapshot(context)).toBeNull();
|
|
});
|
|
|
|
it("does not merge local thread list updates into in-flight app-server snapshots", async () => {
|
|
const context = cacheContext();
|
|
const refresh = deferred<readonly ReturnType<typeof thread>[]>();
|
|
const cache = cacheWithThreads(() => refresh.promise);
|
|
|
|
cache.setActiveThreads(context, [thread("thread"), thread("other")]);
|
|
const promise = cache.refreshActiveThreads(context);
|
|
await flushMicrotasks();
|
|
|
|
cache.updateActiveThreads(context, (threads) => threads?.filter((item) => item.id !== "thread") ?? null);
|
|
refresh.resolve([thread("thread"), thread("other")]);
|
|
|
|
await expect(promise).resolves.toEqual([thread("thread"), thread("other")]);
|
|
expect(cache.activeThreadsSnapshot(context)).toEqual([thread("thread"), thread("other")]);
|
|
});
|
|
});
|
|
|
|
function cacheContext(overrides: Partial<AppServerQueryContext> = {}): AppServerQueryContext {
|
|
return {
|
|
codexPath: "codex",
|
|
vaultPath: "/vault",
|
|
...overrides,
|
|
};
|
|
}
|
|
|
|
function cacheWithThreads(
|
|
fetchThreads: (context: AppServerQueryContext, archived: boolean) => Promise<readonly ReturnType<typeof thread>[]>,
|
|
): AppServerQueryCache {
|
|
return new AppServerQueryCache({
|
|
clientRunner: {
|
|
runWithClient: async (context, operation) => {
|
|
return operation({
|
|
listThreads: async (_cwd: string, options: { archived?: boolean }) => ({
|
|
data: await fetchThreads(context, options.archived ?? false),
|
|
nextCursor: null,
|
|
}),
|
|
} as never);
|
|
},
|
|
},
|
|
});
|
|
}
|
|
|
|
function cacheWithClient(client: Record<string, unknown>): AppServerQueryCache {
|
|
return new AppServerQueryCache({
|
|
clientRunner: {
|
|
runWithClient: async (_context, operation) => operation(client as never),
|
|
},
|
|
});
|
|
}
|
|
|
|
function metadata(
|
|
overrides: {
|
|
availableModels?: readonly ModelMetadata[];
|
|
availableSkills?: readonly SkillMetadata[];
|
|
rateLimit?: RateLimitSnapshot | null;
|
|
runtimeConfig?: RuntimeConfigSnapshot | null;
|
|
modelProbeStatus?: "ok" | "failed";
|
|
skillsProbeStatus?: "ok" | "failed";
|
|
rateLimitProbeStatus?: "ok" | "failed";
|
|
} = {},
|
|
): SharedServerMetadata {
|
|
let diagnostics = createServerDiagnostics();
|
|
diagnostics = diagnosticsWithProbe(
|
|
diagnostics,
|
|
overrides.modelProbeStatus === "failed"
|
|
? diagnosticProbeError("model/list", new Error("offline"), 1)
|
|
: diagnosticProbeOk("model/list", "1 models", 1),
|
|
);
|
|
diagnostics = diagnosticsWithProbe(
|
|
diagnostics,
|
|
overrides.skillsProbeStatus === "failed"
|
|
? diagnosticProbeError("skills/list", new Error("offline"), 1)
|
|
: diagnosticProbeOk("skills/list", "0 skills", 1),
|
|
);
|
|
diagnostics = diagnosticsWithProbe(
|
|
diagnostics,
|
|
overrides.rateLimitProbeStatus === "failed"
|
|
? diagnosticProbeError("account/rateLimits/read", new Error("offline"), 1)
|
|
: diagnosticProbeOk("account/rateLimits/read", "available", 1),
|
|
);
|
|
return {
|
|
runtimeConfig: overrides.runtimeConfig ?? emptyRuntimeConfigSnapshot(),
|
|
availableModels: overrides.availableModels ?? [modelMetadata("gpt-5.5")],
|
|
availableSkills: overrides.availableSkills ?? [],
|
|
rateLimit: overrides.rateLimit ?? null,
|
|
serverDiagnostics: diagnostics,
|
|
};
|
|
}
|
|
|
|
function skillMetadata(name: string): SkillMetadata {
|
|
return { name, description: "", path: `/tmp/${name}`, enabled: true };
|
|
}
|
|
|
|
function rateLimit(usedPercent: number): RateLimitSnapshot {
|
|
return {
|
|
limitId: "codex",
|
|
limitName: "Codex",
|
|
primary: { usedPercent, windowDurationMins: 300, resetsAt: 1 },
|
|
secondary: null,
|
|
individualLimit: null,
|
|
rateLimitReachedType: null,
|
|
};
|
|
}
|
|
|
|
function modelMetadata(model: string): ModelMetadata {
|
|
return {
|
|
id: model,
|
|
model,
|
|
displayName: model,
|
|
description: "",
|
|
hidden: false,
|
|
supportedReasoningEfforts: [],
|
|
defaultReasoningEffort: "medium",
|
|
inputModalities: [],
|
|
additionalSpeedTiers: [],
|
|
serviceTiers: [],
|
|
defaultServiceTier: null,
|
|
isDefault: false,
|
|
};
|
|
}
|
|
|
|
function catalogModel(model: string): CatalogModel {
|
|
return {
|
|
id: model,
|
|
model,
|
|
displayName: model,
|
|
description: "",
|
|
hidden: false,
|
|
supportedReasoningEfforts: [],
|
|
defaultReasoningEffort: "medium",
|
|
inputModalities: ["text"],
|
|
additionalSpeedTiers: [],
|
|
serviceTiers: [],
|
|
defaultServiceTier: null,
|
|
isDefault: false,
|
|
};
|
|
}
|
|
|
|
function catalogSkill(name: string): CatalogSkillMetadata {
|
|
return {
|
|
name,
|
|
description: "",
|
|
path: `/tmp/${name}`,
|
|
enabled: true,
|
|
};
|
|
}
|
|
|
|
function appServerRateLimit(usedPercent: number): RateLimitSnapshot {
|
|
return {
|
|
limitId: "codex",
|
|
limitName: "Codex",
|
|
primary: { usedPercent, windowDurationMins: 300, resetsAt: null },
|
|
secondary: null,
|
|
individualLimit: null,
|
|
rateLimitReachedType: null,
|
|
};
|
|
}
|
|
|
|
function thread(id: string, archived = false) {
|
|
return {
|
|
id,
|
|
preview: "",
|
|
name: null,
|
|
archived,
|
|
createdAt: 1,
|
|
updatedAt: 1,
|
|
};
|
|
}
|
|
|
|
interface Deferred<T> {
|
|
promise: Promise<T>;
|
|
resolve: (value: T) => void;
|
|
}
|
|
|
|
function deferred<T>(): Deferred<T> {
|
|
let resolve: (value: T) => void = () => undefined;
|
|
const promise = new Promise<T>((settle) => {
|
|
resolve = settle;
|
|
});
|
|
return { promise, resolve };
|
|
}
|
|
|
|
async function flushMicrotasks(): Promise<void> {
|
|
for (let index = 0; index < 10; index += 1) {
|
|
await Promise.resolve();
|
|
}
|
|
}
|