From 5327ed61efa06629a5fdccbda6abab44a9d8999b Mon Sep 17 00:00:00 2001 From: Nathan Smith Date: Sun, 30 Jun 2024 14:38:53 -0400 Subject: [PATCH] =?UTF-8?q?=F0=9F=94=A8=20refactor:=20#102=20Sonar=20linti?= =?UTF-8?q?ng?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/github/api.ts | 2 +- src/github/github.ts | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/src/github/api.ts b/src/github/api.ts index 434f150..bcfd00f 100644 --- a/src/github/api.ts +++ b/src/github/api.ts @@ -67,7 +67,7 @@ export class GitHubApi { do { match = linkRelPattern.exec(link); logger.debug(match); - if (match && match.groups) { + if (match?.groups) { const params = new URLSearchParams(match.groups.qp); const page = parseInt(params.get("page") ?? ""); const per_page = parseInt(params.get("per_page") ?? ""); diff --git a/src/github/github.ts b/src/github/github.ts index b9ed84b..ef2b0ab 100644 --- a/src/github/github.ts +++ b/src/github/github.ts @@ -51,7 +51,6 @@ export function getIssue(org: string, repo: string, issue: number, skipCache = f return api.getIssue(org, repo, issue, getToken(org), skipCache); } -// TODO: Cache this response export function getMyIssues( params: QueryParams, org?: string, @@ -89,7 +88,6 @@ export function getMyIssues( return api.listIssuesForToken(listParams, account.token, skipCache); } -// TODO: Cache this response export function getIssuesForRepo( params: QueryParams, org: string, @@ -133,7 +131,6 @@ export function getPullRequest( return api.getPullRequest(org, repo, pullRequest, getToken(org), skipCache); } -// TODO: Cache this response export function getPullRequestsForRepo( params: QueryParams, org: string,