obsidian-plugin/ninglg_light-mindmap
1
0
Fork 0
mirror of https://github.com/ninglg/light-mindmap.git synced 2026-07-22 06:51:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: correct sibling reorder index calculation in _moveNode

Browse source
This commit is contained in:
ninglg 2026-07-09 11:41:39 +08:00
parent 8ee63cd4c7
commit 10b7d53909
1 changed files with 26 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
main.js
View file

@ -1486,12 +1486,34 @@ class LightMindMapPlugin extends obsidian.Plugin {
}
_moveNode(overlay, sourceNode, targetNode, position) {
// 1. Remove from original parent
// 1. Calculate target index BEFORE removing source (important for same-parent reorder)
let targetParent, insertIndex;
if (position === 'child') {
// Moving to become a child of target
targetParent = targetNode;
insertIndex = -1; // Will be pushed to end
} else {
// Moving before/after target (same parent)
targetParent = targetNode.parent;
const targetIndex = targetParent.children.indexOf(targetNode);
insertIndex = position === 'before' ? targetIndex : targetIndex + 1;
// Adjust index if source is before target in same parent (removal shifts indices)
if (targetParent === sourceNode.parent) {
const sourceIndex = targetParent.children.indexOf(sourceNode);
if (sourceIndex < insertIndex) {
insertIndex--;
}
}
}
// 2. Remove from original parent
const sourceParent = sourceNode.parent;
const sourceIndex = sourceParent.children.indexOf(sourceNode);
sourceParent.children.splice(sourceIndex, 1);
// 2. Insert at new position
// 3. Insert at new position
if (position === 'child') {
sourceNode.parent = targetNode;
targetNode.children.push(sourceNode);
@ -1500,17 +1522,14 @@ class LightMindMapPlugin extends obsidian.Plugin {
targetNode.collapsed = false;
}
} else {
const targetParent = targetNode.parent;
const targetIndex = targetParent.children.indexOf(targetNode);
const insertIndex = position === 'before' ? targetIndex : targetIndex + 1;
sourceNode.parent = targetParent;
targetParent.children.splice(insertIndex, 0, sourceNode);
}
// 3. Update node depths
// 4. Update node depths
this._updateNodeDepths(sourceNode);
// 4. Persist and re-render
// 5. Persist and re-render
this._persistAndRelayout(overlay);
}