obsidian-plugin/panatgithub_AnkiHeadingSync
1
0
Fork 0
mirror of https://github.com/panatgithub/AnkiHeadingSync.git synced 2026-07-22 06:51:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: 调整卡片类型设置文案与启用计数 / fix card-types copy and enabled count

Browse source
This commit is contained in:
Dusk 2026-04-25 23:51:05 +08:00
parent b6e59c8eec
commit cb2873e379
2 changed files with 114 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

108
src/presentation/settings/PluginSettingTab.test.ts
View file

@ -725,6 +725,16 @@ describe("PluginSettingTab", () => {
expect(() => queryByDataset(tab.containerEl, "cardTypeMarker", "semantic-qa")).toThrow("Element not found");
});
it("does not render the legacy card-types description copy", async () => {
const plugin = new FakePlugin();
const tab = new AnkiHeadingSyncSettingTab(plugin as never);
tab.display();
await expandCard(tab, "card-types");
expect(collectTexts(tab.containerEl)).not.toContain("直接编辑识别规则，修改后自动保存。");
});
it("auto saves toggle, heading, note type and field mapping edits", async () => {
const plugin = new FakePlugin();
const tab = new AnkiHeadingSyncSettingTab(plugin as never);
@ -1049,6 +1059,104 @@ describe("PluginSettingTab", () => {
expect(collectTexts(tab.containerEl).some((text) => text.includes("和本页缓存的 2 个模板不一致"))).toBe(false);
});
it("counts only enabled visible card types with cached fields in the status summary", async () => {
const plugin = new FakePlugin();
plugin.settings = normalizePluginSettings({
...plugin.settings,
ankiNoteTypeCache: ["Basic", "Custom Cloze", QA_GROUP_USER_MODEL_NAME],
ankiModelFieldCache: {
Basic: {
fieldNames: ["Front", "Back", "Extra"],
loadedAt: 100,
},
"Custom Cloze": {
fieldNames: ["Text", "Extra", "Hint"],
loadedAt: 100,
},
[QA_GROUP_USER_MODEL_NAME]: {
fieldNames: ["题目", "标题", "问题01", "答案01"],
loadedAt: 100,
},
},
cardTypeConfigs: {
...plugin.settings.cardTypeConfigs,
basic: {
...plugin.settings.cardTypeConfigs.basic,
enabled: true,
noteType: "Basic",
},
"qa-group": {
...plugin.settings.cardTypeConfigs["qa-group"],
enabled: true,
noteType: QA_GROUP_USER_MODEL_NAME,
},
cloze: {
...plugin.settings.cardTypeConfigs.cloze,
enabled: false,
noteType: "Custom Cloze",
},
},
});
plugin.noteModels = ["Basic", "Custom Cloze", QA_GROUP_USER_MODEL_NAME];
const tab = new AnkiHeadingSyncSettingTab(plugin as never);
tab.display();
await expandCard(tab, "card-types");
await flushPromises();
expect(collectTexts(tab.containerEl).some((text) => text.includes("当前使用缓存的 3 个笔记模板，已选择并配置 2 个卡片模式。"))).toBe(true);
const clozeToggle = queryByDataset(tab.containerEl, "cardTypeEnabled", "cloze");
clozeToggle.checked = true;
await clozeToggle.trigger("change");
expect(collectTexts(tab.containerEl).some((text) => text.includes("当前使用缓存的 3 个笔记模板，已选择并配置 3 个卡片模式。"))).toBe(true);
});
it("excludes enabled card types without cached fields from the configured count", async () => {
const plugin = new FakePlugin();
plugin.settings = normalizePluginSettings({
...plugin.settings,
ankiNoteTypeCache: ["Basic", "Custom Cloze", QA_GROUP_USER_MODEL_NAME],
ankiModelFieldCache: {
Basic: {
fieldNames: ["Front", "Back", "Extra"],
loadedAt: 100,
},
[QA_GROUP_USER_MODEL_NAME]: {
fieldNames: ["题目", "标题", "问题01", "答案01"],
loadedAt: 100,
},
},
cardTypeConfigs: {
...plugin.settings.cardTypeConfigs,
basic: {
...plugin.settings.cardTypeConfigs.basic,
enabled: true,
noteType: "Basic",
},
"qa-group": {
...plugin.settings.cardTypeConfigs["qa-group"],
enabled: true,
noteType: QA_GROUP_USER_MODEL_NAME,
},
cloze: {
...plugin.settings.cardTypeConfigs.cloze,
enabled: true,
noteType: "Custom Cloze",
},
},
});
plugin.noteModels = ["Basic", "Custom Cloze", QA_GROUP_USER_MODEL_NAME];
const tab = new AnkiHeadingSyncSettingTab(plugin as never);
tab.display();
await expandCard(tab, "card-types");
await flushPromises();
expect(collectTexts(tab.containerEl).some((text) => text.includes("当前使用缓存的 3 个笔记模板，已选择并配置 2 个卡片模式。"))).toBe(true);
});
it("switching note type immediately reuses cached field names", async () => {
const plugin = new FakePlugin();
plugin.settings = normalizePluginSettings({

9
src/presentation/settings/PluginSettingTab.ts
View file

@ -283,7 +283,6 @@ export class AnkiHeadingSyncSettingTab extends PluginSettingTab {
private renderCardTypesCard(containerEl: HTMLElement): void {
this.hydrateVisibleCardTypeCaches();
this.maybeStartNoteTypeCacheCheck();
containerEl.createEl("p", { text: t("settings.cards.cardTypes.desc") });
const actionRow = containerEl.createDiv();
actionRow.style.display = "flex";
@ -1012,8 +1011,12 @@ export class AnkiHeadingSyncSettingTab extends PluginSettingTab {
private countConfiguredCardTypes(ankiModelFieldCache: AnkiHeadingSyncPlugin["settings"]["ankiModelFieldCache"]): number {
return VISIBLE_CARD_TYPE_CONFIG_IDS.reduce((configuredCount, configId) => {
const selectedModelName = this.plugin.settings.cardTypeConfigs[configId].noteType;
return configuredCount + (ankiModelFieldCache[selectedModelName] ? 1 : 0);
const config = this.plugin.settings.cardTypeConfigs[configId];
if (!config.enabled) {
return configuredCount;
}
return configuredCount + (ankiModelFieldCache[config.noteType] ? 1 : 0);
}, 0);
}