From d9e039e16fd77796920573ab3a055ec4ae6542f6 Mon Sep 17 00:00:00 2001 From: poanse <50020771+poanse@users.noreply.github.com> Date: Sat, 16 May 2026 06:45:22 +0300 Subject: [PATCH] fixed warnings from automatic review --- esbuild.config.mjs | 2 -- package-lock.json | 42 +++++++++----------------- package.json | 1 - src/Context.svelte.ts | 11 ++++--- src/DraggingManager.svelte.ts | 2 +- src/NodePositionsCalculator.ts | 2 +- src/components/TaskmapContainer.svelte | 2 +- src/helpers/FolderSuggest.ts | 2 +- src/helpers/LinkSuggest.ts | 2 +- 9 files changed, 26 insertions(+), 40 deletions(-) diff --git a/esbuild.config.mjs b/esbuild.config.mjs index bab5723..8b9e917 100644 --- a/esbuild.config.mjs +++ b/esbuild.config.mjs @@ -1,6 +1,5 @@ import esbuild from "esbuild"; import process from "process"; -import builtins from "builtin-modules"; import esbuildSvelte from "esbuild-svelte"; import { sveltePreprocess } from "svelte-preprocess"; import fs from "fs"; @@ -54,7 +53,6 @@ const context = await esbuild.context({ "@lezer/common", "@lezer/highlight", "@lezer/lr", - ...builtins, ], format: "cjs", target: "es2022", diff --git a/package-lock.json b/package-lock.json index c0b9220..8b35033 100644 --- a/package-lock.json +++ b/package-lock.json @@ -6,7 +6,7 @@ "packages": { "": { "name": "obsidian-taskmap", - "version": "0.1.3", + "version": "0.1.5", "license": "MIT", "dependencies": { "@napolab/alpha-blend": "^2.0.0", @@ -24,7 +24,6 @@ "@types/node": "latest", "@typescript-eslint/eslint-plugin": "latest", "@typescript-eslint/parser": "latest", - "builtin-modules": "latest", "esbuild": "latest", "esbuild-svelte": "^0.9.3", "eslint": "^9.39.2", @@ -1898,19 +1897,6 @@ "balanced-match": "^1.0.0" } }, - "node_modules/builtin-modules": { - "version": "5.0.0", - "resolved": "https://registry.npmjs.org/builtin-modules/-/builtin-modules-5.0.0.tgz", - "integrity": "sha512-bkXY9WsVpY7CvMhKSR6pZilZu9Ln5WDrKVBUXf2S443etkmEO4V58heTecXcUIsNsi4Rx8JUO4NfX1IcQl4deg==", - "dev": true, - "license": "MIT", - "engines": { - "node": ">=18.20" - }, - "funding": { - "url": "https://github.com/sponsors/sindresorhus" - } - }, "node_modules/call-bind": { "version": "1.0.8", "resolved": "https://registry.npmjs.org/call-bind/-/call-bind-1.0.8.tgz", @@ -2215,9 +2201,9 @@ } }, "node_modules/devalue": { - "version": "5.7.1", - "resolved": "https://registry.npmjs.org/devalue/-/devalue-5.7.1.tgz", - "integrity": "sha512-MUbZ586EgQqdRnC4yDrlod3BEdyvE4TapGYHMW2CiaW+KkkFmWEFqBUaLltEZCGi0iFXCEjRF0OjF0DV2QHjOA==", + "version": "5.8.1", + "resolved": "https://registry.npmjs.org/devalue/-/devalue-5.8.1.tgz", + "integrity": "sha512-4CXDYRBGqN+57wVJkuXBYmpAVUSg3L6JAQa/DFqm238G73E1wuyc/JhGQJzN7vUf/CMphYau2zXbfWzDR5aTEw==", "license": "MIT" }, "node_modules/dunder-proto": { @@ -3377,9 +3363,9 @@ "license": "MIT" }, "node_modules/fast-uri": { - "version": "3.1.0", - "resolved": "https://registry.npmjs.org/fast-uri/-/fast-uri-3.1.0.tgz", - "integrity": "sha512-iPeeDKJSWf4IEOasVVrknXpaBV0IApz/gp7S2bb7Z4Lljbl2MGJRqInZiUrQwV16cpzw/D3S5j5Julj/gT52AA==", + "version": "3.1.2", + "resolved": "https://registry.npmjs.org/fast-uri/-/fast-uri-3.1.2.tgz", + "integrity": "sha512-rVjf7ArG3LTk+FS6Yw81V1DLuZl1bRbNrev6Tmd/9RaroeeRRJhAt7jg/6YFxbvAQXUCavSoZhPPj6oOx+5KjQ==", "dev": true, "funding": [ { @@ -4848,9 +4834,9 @@ } }, "node_modules/postcss": { - "version": "8.5.6", - "resolved": "https://registry.npmjs.org/postcss/-/postcss-8.5.6.tgz", - "integrity": "sha512-3Ybi1tAuwAP9s0r1UQ2J4n5Y0G05bJkpUIO0/bI9MhwmD70S5aTWbXGBwxHrelT+XM1k6dM0pk+SwNkpTRN7Pg==", + "version": "8.5.14", + "resolved": "https://registry.npmjs.org/postcss/-/postcss-8.5.14.tgz", + "integrity": "sha512-SoSL4+OSEtR99LHFZQiJLkT59C5B1amGO1NzTwj7TT1qCUgUO6hxOvzkOYxD+vMrXBM3XJIKzokoERdqQq/Zmg==", "dev": true, "funding": [ { @@ -5720,9 +5706,9 @@ } }, "node_modules/svelte": { - "version": "5.55.3", - "resolved": "https://registry.npmjs.org/svelte/-/svelte-5.55.3.tgz", - "integrity": "sha512-dS1N+i3bA1v+c4UDb750MlN5vCO82G6vxh8HeTsPsTdJ1BLsN1zxSyDlIdBBqUjqZ/BxEwM8UrFf98aaoVnZFQ==", + "version": "5.55.7", + "resolved": "https://registry.npmjs.org/svelte/-/svelte-5.55.7.tgz", + "integrity": "sha512-ymI5ykLPwIHW839E053FQbI1G+jnRFJEw3Kv5Y4njixVWywQBx+NUFpkkKyk5LIb36Fg9DVXSYpqiGekLD0hyw==", "license": "MIT", "peer": true, "dependencies": { @@ -5735,7 +5721,7 @@ "aria-query": "5.3.1", "axobject-query": "^4.1.0", "clsx": "^2.1.1", - "devalue": "^5.6.4", + "devalue": "^5.8.1", "esm-env": "^1.2.1", "esrap": "^2.2.4", "is-reference": "^3.0.3", diff --git a/package.json b/package.json index 3e08de5..32fb72c 100644 --- a/package.json +++ b/package.json @@ -19,7 +19,6 @@ "@types/node": "latest", "@typescript-eslint/eslint-plugin": "latest", "@typescript-eslint/parser": "latest", - "builtin-modules": "latest", "esbuild": "latest", "esbuild-svelte": "^0.9.3", "eslint": "^9.39.2", diff --git a/src/Context.svelte.ts b/src/Context.svelte.ts index 55c579e..55aa69e 100644 --- a/src/Context.svelte.ts +++ b/src/Context.svelte.ts @@ -180,7 +180,7 @@ export class Context { public finishTaskDragging = (e: PointerEvent, updatePositions = false) => { this.draggedTaskId = NoTaskId; - this.taskDraggingManager.onPointerUp(e); + this.taskDraggingManager.onPointerUp(); if (updatePositions) { this.updateTaskPositions(); } @@ -315,7 +315,7 @@ export class Context { const taskIdSet: ReadonlySet = new SvelteSet( this.taskPositions.map((t) => t.taskId), ); - this.positions.forEach((v, k) => { + this.positions.forEach((_v, k) => { if (k != NoTaskId && !taskIdSet.has(k)) { this.taskPositions.push({ taskId: k, @@ -426,8 +426,11 @@ export class Context { this.app.workspace .getLeavesOfType(TASKMAP_VIEW_TYPE) .map((leaf) => leaf.view) - .filter((view) => view instanceof TaskmapView) - .forEach((view) => view.debouncedSave()); + .forEach((view) => { + if (view instanceof TaskmapView) { + view.debouncedSave(); + } + }); } public addTask(parentId: TaskId): void { diff --git a/src/DraggingManager.svelte.ts b/src/DraggingManager.svelte.ts index 7fe314c..b58ef7d 100644 --- a/src/DraggingManager.svelte.ts +++ b/src/DraggingManager.svelte.ts @@ -27,7 +27,7 @@ export class DraggingManager { } }; - public onPointerUp = (e: PointerEvent) => { + public onPointerUp = () => { console.debug(`DraggingManager pointerUp: ${this.deltaX}`); this.reset(); }; diff --git a/src/NodePositionsCalculator.ts b/src/NodePositionsCalculator.ts index 64d0f64..428212b 100644 --- a/src/NodePositionsCalculator.ts +++ b/src/NodePositionsCalculator.ts @@ -321,7 +321,7 @@ export class NodePositionsCalculator { rootChildrenByPriority.set(idx, id); }); - rootChildrenByPriority.forEach((priority, chId) => { + rootChildrenByPriority.forEach((_priority, chId) => { const x = taskById.get(chId)!; if (this.RowIndex(x) === 0) { const neighbourId = diff --git a/src/components/TaskmapContainer.svelte b/src/components/TaskmapContainer.svelte index 334c1f2..d5ee9fe 100644 --- a/src/components/TaskmapContainer.svelte +++ b/src/components/TaskmapContainer.svelte @@ -132,7 +132,7 @@ viewportEl!.focus(); e.stopPropagation(); } - draggingManager.onPointerUp(e); + draggingManager.onPointerUp(); context.finishTaskDragging(e, true); } diff --git a/src/helpers/FolderSuggest.ts b/src/helpers/FolderSuggest.ts index 032d35e..40355c4 100644 --- a/src/helpers/FolderSuggest.ts +++ b/src/helpers/FolderSuggest.ts @@ -33,7 +33,7 @@ export class FolderSuggest extends AbstractInputSuggest { } renderSuggestion(file: TFolder, el: HTMLElement) { - el.createEl("div", { text: file.path }); + el.createDiv({ text: file.path }); el.createEl("small", { text: file.path, cls: "text-muted" }); } diff --git a/src/helpers/LinkSuggest.ts b/src/helpers/LinkSuggest.ts index ad0198d..d348880 100644 --- a/src/helpers/LinkSuggest.ts +++ b/src/helpers/LinkSuggest.ts @@ -45,7 +45,7 @@ export class LinkSuggest extends AbstractInputSuggest { } renderSuggestion(file: TFile, el: HTMLElement) { - el.createEl("div", { text: file.basename }); + el.createDiv({ text: file.basename }); el.createEl("small", { text: file.path, cls: "text-muted" }); }